From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] Modus themes 1.2.0 Date: Thu, 04 Mar 2021 18:41:19 +0000 Message-ID: <87ft1aoj74.fsf@tcd.ie> References: <87im9fgm27.fsf@protesilaos.com> <87sg6po0yd.fsf_-_@protesilaos.com> <83czxt2fpd.fsf@gnu.org> <87h7m0n0em.fsf@protesilaos.com> <83v9agryuz.fsf@gnu.org> <87tupyw83e.fsf@protesilaos.com> <83zgzqncxx.fsf@gnu.org> <874khwn1qf.fsf@protesilaos.com> <603b8171.1c69fb81.aa664.7f40@mx.google.com> <87mtvoxsvs.fsf@protesilaos.com> <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com> <83eegz7xcx.fsf@gnu.org> <87o8g3exjv.fsf@protesilaos.com> <603d053a.1c69fb81.f4cb8.fb14@mx.google.com> <87h7luga3p.fsf@protesilaos.com> <87o8g2bg89.fsf@tcd.ie> <87r1kyrtrl.fsf@protesilaos.com> <878s75x2uk.fsf@tcd.ie> <87o8g0ryfz.fsf@tcd.ie> <6040d37e.1c69fb81.63467.ad62@mx.google.com> <87wnun9dgo.fsf_-_@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39206"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45068@debbugs.gnu.org, Mauro Aranda To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 19:42:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHsvM-000A2K-7D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 19:42:12 +0100 Original-Received: from localhost ([::1]:50604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHsvL-00025u-4H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 13:42:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHsvC-00024R-TK for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 13:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48666) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHsvB-0006ZX-Jo for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 13:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHsvB-0004Mx-Hb for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 13:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 18:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.161488329016761 (code B ref 45068); Thu, 04 Mar 2021 18:42:01 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 4 Mar 2021 18:41:30 +0000 Original-Received: from localhost ([127.0.0.1]:60212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHsug-0004MH-E3 for submit@debbugs.gnu.org; Thu, 04 Mar 2021 13:41:30 -0500 Original-Received: from mail-wr1-f44.google.com ([209.85.221.44]:39639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHsue-0004M2-74 for 45068@debbugs.gnu.org; Thu, 04 Mar 2021 13:41:29 -0500 Original-Received: by mail-wr1-f44.google.com with SMTP id b18so22315282wrn.6 for <45068@debbugs.gnu.org>; Thu, 04 Mar 2021 10:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Auy2v7BtxIxadVQnDE6EBWedeE8lPiIKqei4f2RdZVo=; b=DjV4mqLSFOEY6lf760jgZjpgL7VKg8ZoSYu9nL1+dyxJFZd1Xpo9XHlusSAUPYUAdF +Bddafx99zqnct+Dcr6EMLjlP1QCbhcVqpTsaRcx68SvPsYUncITRB95+W43ECMLAlch CRaefBoS0KEOjY+g5XIRUU6tdET4/ZYaqNPHysSig1X8pNLly+ueRe4hS0Dzdg6WisM/ K6QdYRBAL9uwevax3kC9akzzYT1t5VOH1DgFx3tnpEg7uvLzXpjWu0iJHgKs+MX6BSuI bOqc8WUd6hKndiGHRafQobW7fJ9Vq3+LoBdHwQh/MDqDez0v0Z2LmjFDYezTqGJ+ZOE+ o/Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Auy2v7BtxIxadVQnDE6EBWedeE8lPiIKqei4f2RdZVo=; b=knreGb52RPhJuGWwSYS/DitUj52/9Nv/+VKJzGaeu501zoxJxtVlcI7MCygHqP/VVZ CpE2wfV1xc/HP5feZ8/Txp/7pmBAg2DMmR4RyYtMVPpyuPP6i9O7V8vcQvfXh2OJYE4s dooBIKAJULtTCcYCQyqO+I16kQ6hS6L/bC0xk56hzd1SQk3xrT3fI6x1+osBEmNkhx6B LTYOvh/ptNKTefGc5TZF8hBGHeZ0HOAiWoaEtnqVYhns2PHWnexpDZdlK0Win+z2gG6K 9ccL3RNtYj8qNZFChvFF1nK9YMr55ZDDaz4vUtHqoEL3jmhWZSN2yysY++lfqHMcmlyx Pr2g== X-Gm-Message-State: AOAM532uZjWzfE0rQWwVSHSdNxDF0uu5yUIan4impcXHogri3NhY+wT1 DHtxperIc3xrsT+0LPgqO7KCTg== X-Google-Smtp-Source: ABdhPJzNok3OcI/Kv6c2EE//1dvhwn79hekHq+IhQZi+Q/PLWrfW5X1KqaUXpteoDsWpIpUHfDjT0w== X-Received: by 2002:adf:ed46:: with SMTP id u6mr5457585wro.350.1614883282252; Thu, 04 Mar 2021 10:41:22 -0800 (PST) Original-Received: from localhost ([51.37.98.190]) by smtp.gmail.com with ESMTPSA id p11sm124246wrs.80.2021.03.04.10.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 10:41:21 -0800 (PST) In-Reply-To: <87wnun9dgo.fsf_-_@protesilaos.com> (Protesilaos Stavrou's message of "Thu, 04 Mar 2021 16:54:15 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201439 Archived-At: Protesilaos Stavrou writes: > As noted earlier, please find attached the patch that upgrades the > themes to their newest version 1.2.0. I tested it with Basil's latest > patch for 'require-theme', though it still works with the variant of > that function currently in trunk. Thanks, they're looking good! Just a couple of nits from me below. > For your convenience, I also attach a note that I intend to post on > emacs-devel: it warns about the minor backward-incompatible refactoring > of some symbols and offers an overview of what is now available. > +Before you load a theme, it is necessary to require the main library: >=20=20 > #+begin_src emacs-lisp > +(require 'modus-themes) > #+end_src Is this always true? Because M-x load-theme RET modus-{operandi,vivendi} RET works fine here with your patch, and users can set variables even before they're defined - defvar and defcustom only change the symbol's value if it's unbound. Maybe this node should clarify which users/setups/use-cases this applies to? Similarly with other suggestions below like this one: (require 'modus-themes) (require 'modus-operandi-theme) (require 'modus-vivendi-theme) which surely won't work with the built-in themes. > ++ Ideas and user feedback :: Aaron Jensen, Adam Spiers, Adrian Manea, > + Alex Griffin, Alex Peitsinis, Alexey Shmalko, Alok Singh, Anders > + Johansson, Andr=C3=A9 Alexandre Gomes, Arif Rezai, Basil L. Contovoune= sios, ^^ Hopefully Org's Texinfo export can one day be taught that this is not the end of a sentence ;). > +(require 'cl-lib) In theory this should be wrapped in eval-when-compile, but it doesn't make a difference for now since built-in themes are not byte-compiled. > +(deftheme modus-vivendi > + "Accessible and customizable light theme (WCAG AAA standard). ^^^^^ dark Thanks, --=20 Basil