From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45474: Icomplete exhibiting in recursive minibuffer when it =?UTF-8?Q?shouldn=E2=80=99t?= Date: Fri, 16 Apr 2021 00:11:10 +0300 Organization: LINKOV.NET Message-ID: <87fszrz21d.fsf@mail.linkov.net> References: <3ed97a9c53e0a5d4fef8@heytings.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33584"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Dario Gjorgjevski , 45474@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 15 23:13:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lX9IT-0008dR-Og for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Apr 2021 23:13:09 +0200 Original-Received: from localhost ([::1]:50778 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX9IS-00017D-Qv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Apr 2021 17:13:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX9IM-00016r-74 for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 17:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56040) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lX9IL-0003KD-Vd for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 17:13:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lX9IL-0002G5-Q2 for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 17:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Apr 2021 21:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45474 X-GNU-PR-Package: emacs Original-Received: via spool by 45474-submit@debbugs.gnu.org id=B45474.16185211618655 (code B ref 45474); Thu, 15 Apr 2021 21:13:01 +0000 Original-Received: (at 45474) by debbugs.gnu.org; 15 Apr 2021 21:12:41 +0000 Original-Received: from localhost ([127.0.0.1]:39353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX9I1-0002FX-FG for submit@debbugs.gnu.org; Thu, 15 Apr 2021 17:12:41 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX9Hy-0002FI-Ha for 45474@debbugs.gnu.org; Thu, 15 Apr 2021 17:12:40 -0400 X-Originating-IP: 91.129.111.204 Original-Received: from mail.gandi.net (m91-129-111-204.cust.tele2.ee [91.129.111.204]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id E71E260003; Thu, 15 Apr 2021 21:12:30 +0000 (UTC) In-Reply-To: <3ed97a9c53e0a5d4fef8@heytings.org> (Gregory Heytings's message of "Thu, 15 Apr 2021 17:40:04 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204100 Archived-At: >> If the M-: is not in a recursive minibuffer, everything is OK since >> icomplete-simple-completing-p returns nil. > > Indeed; patch attached. Ideally this should be done inside > icomplete-minibuffer-setup, but if we did this (by checking > minibuffer-completing-symbol), it would prevent icomplete-mode from being > active in the opposite situation: M-: followed by C-x C-f. > > @@ -1754,7 +1754,9 @@ read--expression > (set-syntax-table emacs-lisp-mode-syntax-table) > (add-hook 'completion-at-point-functions > #'elisp-completion-at-point nil t) > - (run-hooks 'eval-expression-minibuffer-setup-hook)) > + (run-hooks 'eval-expression-minibuffer-setup-hook) > + ;; if we enter a recursive minibuffer, disable icomplete (bug#45474) > + (setq-local icomplete-mode nil)) Is this really specific only to read--expression? I can reproduce the same issue with any command that doesn't use completion, e.g. C-x C-f C-x f.