From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Date: Wed, 28 Apr 2021 08:19:31 +0200 Message-ID: <87fszbnd70.fsf@gmail.com> References: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> <83lf93h6x1.fsf@gnu.org> <20210427193253.ourhlr3nxdem3e6t@E15-2016.optimum.net> <83k0ongnc7.fsf@gnu.org> <20210428030025.75hiu5zgrll2qzeq@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9613"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48072@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 28 08:22:59 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbdb8-0002Ma-8u for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 08:22:58 +0200 Original-Received: from localhost ([::1]:48432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbdb7-0004Wv-BL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 02:22:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbdYK-00033x-34 for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 02:20:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40010) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbdYI-0004rm-JU for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 02:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbdYI-00057D-EK for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 02:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Apr 2021 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48072-submit@debbugs.gnu.org id=B48072.161959078219625 (code B ref 48072); Wed, 28 Apr 2021 06:20:02 +0000 Original-Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 06:19:42 +0000 Original-Received: from localhost ([127.0.0.1]:51556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbdXx-00056T-Rq for submit@debbugs.gnu.org; Wed, 28 Apr 2021 02:19:42 -0400 Original-Received: from mail-wm1-f51.google.com ([209.85.128.51]:33552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbdXu-00056D-Vh for 48072@debbugs.gnu.org; Wed, 28 Apr 2021 02:19:40 -0400 Original-Received: by mail-wm1-f51.google.com with SMTP id a22-20020a05600c2256b0290142870824e9so2009107wmm.0 for <48072@debbugs.gnu.org>; Tue, 27 Apr 2021 23:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=WHemVZQ+1JWlLemEMB+4cFminULz5+E9H4sAu6xQ/7A=; b=I+RPIajRzPNpuXPBYeoe/UTrCbgWMpSMX6khCGQYnlGkrHeMiGdspBzMdsXuyW7lmj VWWlCLFoDCqOZZVg2AdgE6DmlG41t22RYLKxUMXYiyrb/A6mYBdnG8C1zhWe8t+xe2MG DA2po9ffOkzWar2u2jVsdM9cov/VVLbDZgnj0DG02YKZeFpYNSX73U6/VXMGQNOUH795 2ifVNKcER84T/x5anJyZWwvof/XOLvH7KVXs/1VAqO4ZW59gJ7oSplE6K1JRTlzeBzTA L6g42X0TBxaAz/jEPvDPzbHGlDE+OxNSMmX28U05EiFD1GYlGpSHDapmQMC+QMU1JQHG fUEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=WHemVZQ+1JWlLemEMB+4cFminULz5+E9H4sAu6xQ/7A=; b=IyvpJN5jq/9mwkWNEKEGv+UHrYsGrnoR7syzTL7zoSSujCUdaEszjW4YjBfsMsDBoL 0d2pSoQkfHmEFVWifiETSekBLO8LlAPoiac4XhiDPOEdklawOH9LfMrwT+CDnak4Sa7l jrRlSdOABT+D6Yrx96Zrm41ug2c+VmhlExMnej6Fn5fg55YNCZZh/h1Wd5t0GKeM25f1 lIE0pQer0JiVaSytlh5j5oXcZAjmlImoUVublRdA55cFJI/cuAoXs+l3CLbbNUlIar8U xET7NI/YRvBRYTqylC4RBdrEY8T74HRhY08MCTiG7wl0r8NxgTdK7bF9XvYTtkVv9hVh 89BA== X-Gm-Message-State: AOAM533R0s0L9/X83KvsNzB9fax3fy0NitjxuNCHYBAjOkGYva1o/Qus VKFRpKPY2qXsdqL9CxUKOTTZ7yxQJsA= X-Google-Smtp-Source: ABdhPJwz0ONj31dru9jj7fZhGSAh3cqOSHEAnDvkWmrTeTtQCnRO25whv2gK/gAHP7MXxAbMJwL74A== X-Received: by 2002:a05:600c:b4b:: with SMTP id k11mr2486381wmr.129.1619590772867; Tue, 27 Apr 2021 23:19:32 -0700 (PDT) Original-Received: from amdahl30 ([2a01:e0a:20e:d340:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id y5sm7072366wrm.61.2021.04.27.23.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 23:19:32 -0700 (PDT) In-Reply-To: <20210428030025.75hiu5zgrll2qzeq@E15-2016.optimum.net> (Boruch Baum's message of "Tue, 27 Apr 2021 23:00:25 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205081 Archived-At: Boruch Baum writes: >> > > This is certainly a mistake: a valid shell command doesn't have to be >> > > a file that executable-find is able to find. Shells are known to >> > > support all kinds of internal and magic commands. >> > >> > My testing indicates otherwise. >> >> Would you care to share the details of that testing, please? > > I evaluated shell-command-to-string for shell aliases and shell > functions, all of which returned error of type 'command not found'. That > would indicate that the class of 'internal commands' aren't valid in the > current state of emacs. Shell builtins seem to work though: M-: (shell-command-to-string "type echo") "echo is a shell builtin " M-: (shell-command-to-string "which type") "which: no type in (=E2=80=A6) "