From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#48179: bookmark-fontify [PATCH] Date: Thu, 06 May 2021 10:58:16 +0200 Message-ID: <87fsz01bo7.fsf@gnus.org> References: <20210503001358.mjafsjlumdamrlvh@E15-2016.optimum.net> <87zgxcdzh3.fsf@gnus.org> <20210503091204.qhc2tda76wh6345w@E15-2016.optimum.net> <87im40cgxz.fsf@gnus.org> <20210503095828.66mcqkxyznb2vdja@E15-2016.optimum.net> <87v97yan85.fsf@gnus.org> <87lf8uan2m.fsf@gnus.org> <87zgxan7lx.fsf@tcd.ie> <878s4t8up2.fsf@gnus.org> <8735v1jrit.fsf@tcd.ie> <20210505170853.locsnpxoth7fukeq@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32614"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 48179@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 10:59:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leZqp-0008Gt-6K for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 10:59:19 +0200 Original-Received: from localhost ([::1]:41486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leZqj-0006F4-8x for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 04:59:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58280) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leZqY-0006Es-AZ for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 04:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53761) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leZqY-0006KO-3o for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 04:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leZqY-00059u-3E for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 04:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 08:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 48179-submit@debbugs.gnu.org id=B48179.162029150819818 (code B ref 48179); Thu, 06 May 2021 08:59:02 +0000 Original-Received: (at 48179) by debbugs.gnu.org; 6 May 2021 08:58:28 +0000 Original-Received: from localhost ([127.0.0.1]:37074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZpz-00059a-RE for submit@debbugs.gnu.org; Thu, 06 May 2021 04:58:28 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leZpx-00059U-LR for 48179@debbugs.gnu.org; Thu, 06 May 2021 04:58:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v2d1zuOspGL3PFqzTVfzV9TkbqFeY2GQK6VaFu+h4mo=; b=TCEFsAJ7KNtSU3hgcxYqKIhoEH 7/m+ZvQfEf0xFzq37MepZxt2cRM0oRbrKC66CCsk98u2u7fVZu0s4n/UFss8L+4N3lvDqe59gi5rx 0vOb03/4W+2rj4Hs0lkQUJMePaMsiwDje3KxEcbfYH0Xb4E7txQffeixGF+qh8fv4sYw=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leZpp-00059Y-8y; Thu, 06 May 2021 10:58:19 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUyNzg9QUM5PkEt MjUnLC9dX2HRzs6wr6/Av75MT1Ftb3CQkZHp5uV+gID///9zwziWAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+UFBgg1JPf3h+IAAAF0SURBVDjLrZQ/T4NAGMavvl26iU52UvkCr56adDMpDMXFpQNOTnXQ wZgUkuqscy1Li4ODmrS42oF2lZiUT+CnEXr8uTtg8x0IvD+ee+457iA1RVF2iVwbCvdA14XiG5C0 KRXaeVPQQNqnyK4oC6jsIgFaMhS7rxAAigIkWzVlfw8KFnrP6tmP9gi4cGtg3C/6vhUBlEG/S9xl GQias+u57RRyGOHtwdP7QxkIdkw3dEBeEiNc1T9uAgeKisv6ZyiAxDx83X4J46GktTJWp+REVLDk xreGZ4EVASmHfjV5O/ZsJwuIKbBn04n9pWY5MuB3ZxfzO7XwzfVpY+CNz1UuH3PvTDeXPyZRs9li IuksBk3/EGOAInDchT8kvDkDreeG92sOBZBEBE1jX59FQX7/8BsrVxQ2nCzhD0IVwNgxWlYKFOQj 0jLHw3FU3RGIIJ0HAUmR2yDKAjY3oAVASqw5EamoSlLi8B9V+hch5EhLqt0Wsv8BKqKedXq3OdkA AAAldEVYdGRhdGU6Y3JlYXRlADIwMjEtMDUtMDZUMDg6NTM6MzYrMDA6MDBbkxCZAAAAJXRFWHRk YXRlOm1vZGlmeQAyMDIxLTA1LTA2VDA4OjUzOjM2KzAwOjAwKs6oJQAAAABJRU5ErkJggg== X-Now-Playing: Zola Jesus's _New Amsterdam_: "Dog" In-Reply-To: <20210505170853.locsnpxoth7fukeq@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 5 May 2021 13:08:53 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205778 Archived-At: Boruch Baum writes: > 5) Throughout my prior patches, I had been using variable > 'buffer-file-name' to compare against the value for the 'filename' > key in bookmarks' alists. That is wrong, in the sense that it's only > correct for buffers visiting files. The correct comparator seems to > be the output of function (bookmark-buffer-file-name), see there, > which will cover all cases of all buffers. With that change, it's > probably wrong to perform 'expand-file-name' when performing any > comparison. Right. Can you submit a patch to fix that? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no