From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 12/15] Set buffer_defaults fields without a default to Qunbound Date: Fri, 07 May 2021 09:20:33 -0400 Message-ID: <87fsyyr87y.fsf@catern.com> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-13-sbaugh@catern.com> <83a6p6ddur.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22387"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 15:21:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf0Pn-0005jI-Md for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 15:21:11 +0200 Original-Received: from localhost ([::1]:44980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf0Pm-0006M0-Mh for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 09:21:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf0Pe-0006Kj-T9 for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lf0Pe-0006Wm-KR for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lf0Pe-0006jf-Ge for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 09:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162039363925863 (code B ref 48264); Fri, 07 May 2021 13:21:02 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 7 May 2021 13:20:39 +0000 Original-Received: from localhost ([127.0.0.1]:43869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf0PH-0006j5-4z for submit@debbugs.gnu.org; Fri, 07 May 2021 09:20:39 -0400 Original-Received: from venus.catern.com ([68.183.49.163]:60302) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf0PF-0006iz-C9 for 48264@debbugs.gnu.org; Fri, 07 May 2021 09:20:37 -0400 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1620393636; bh=F3qjhXmbxeIU88xil+IzFVn+lL18J0pOULlbEMBJEn0=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=IvSCnnLBaskgGr9G4a6MvbfGoyNJZwA0d3utUarsaDGO+ZmBg+kHFe8Kch/CRVGow p2T0m4CZYPWMA36eLP5K83/F0/UF9C/b0lU/TOeejmEdIVRsnc7q75bZbgWaE2IXIP VXmwRBJfGE/Vvj1LQ9m3sZDxAKgp5Sb2OaNcXfTE= Original-Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id B03542E9752; Fri, 7 May 2021 13:20:34 +0000 (UTC) In-Reply-To: <83a6p6ddur.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205935 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> + if (!(offset == PER_BUFFER_VAR_OFFSET (syntax_table) >> + || offset == PER_BUFFER_VAR_OFFSET (category_table))) > > Please add a comment here about these two exemptions. (And I cannot > say that I like such kludges; why doe we need it?) The syntax_table and category_table fields in buffer_defaults are used through Vstandard_syntax_table and Vstandard_category_table (which are just aliases to the fields in buffer_defaults); the initialization for syntax.c and category.c runs before buffer.c, so they're already set at this point. I could reorder the initialization if you'd prefer that? Or move the initialization into buffer.c?