unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#48761: perl-mode: "$temp" colored differently.
@ 2021-05-31 13:08 積丹尼 Dan Jacobson
  2021-06-01  6:26 ` Lars Ingebrigtsen
  2021-06-01  6:27 ` Lars Ingebrigtsen
  0 siblings, 2 replies; 6+ messages in thread
From: 積丹尼 Dan Jacobson @ 2021-05-31 13:08 UTC (permalink / raw)
  To: 48761

In perl-mode: $temp, @temp are colored differently. E.g., in
my (@AA, @temp, @barf, $temp, $x);

Caused by:
     ;; Fontify declarators and prefixes as types.
     ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators
     ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#48761: perl-mode: "$temp" colored differently.
  2021-05-31 13:08 bug#48761: perl-mode: "$temp" colored differently 積丹尼 Dan Jacobson
@ 2021-06-01  6:26 ` Lars Ingebrigtsen
  2021-06-01  6:27 ` Lars Ingebrigtsen
  1 sibling, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-06-01  6:26 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 48761

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> In perl-mode: $temp, @temp are colored differently. E.g., in
> my (@AA, @temp, @barf, $temp, $x);

I can reproduce this in Emacs 27, but not in Emacs 28:



-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#48761: perl-mode: "$temp" colored differently.
  2021-05-31 13:08 bug#48761: perl-mode: "$temp" colored differently 積丹尼 Dan Jacobson
  2021-06-01  6:26 ` Lars Ingebrigtsen
@ 2021-06-01  6:27 ` Lars Ingebrigtsen
  2021-06-01  8:17   ` Harald Jörg
  1 sibling, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-06-01  6:27 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 48761

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> In perl-mode: $temp, @temp are colored differently. E.g., in
> my (@AA, @temp, @barf, $temp, $x);

I can reproduce this in Emacs 27, but not in Emacs 28:


[-- Attachment #2: Type: image/png, Size: 10610 bytes --]

[-- Attachment #3: Type: text/plain, Size: 137 bytes --]


So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#48761: perl-mode: "$temp" colored differently.
  2021-06-01  6:27 ` Lars Ingebrigtsen
@ 2021-06-01  8:17   ` Harald Jörg
  2021-06-01  8:32     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 6+ messages in thread
From: Harald Jörg @ 2021-06-01  8:17 UTC (permalink / raw)
  To: 48761; +Cc: Lars Ingebrigtsen, 積丹尼 Dan Jacobson

Lars Ingebrigtsen <larsi@gnus.org> writes:

> 積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
>
>> In perl-mode: $temp, @temp are colored differently. E.g., in
>> my (@AA, @temp, @barf, $temp, $x);
>
> I can reproduce this in Emacs 27, but not in Emacs 28:

I was too slow responding :/

This was patched with Bug#46024, which also has a list of other
"keywords" which have been removed from perl-mode: anon, argument,
supersede, let, and temp (sic!).
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=46024

It is still the case that perl-mode treats a few variables which have
names like "legal" perl keywords as keywords and not as variables: for
example $my, @our, %sub, &package.  That would require a different
patch, but these names are much less likely to occur in the wild.

> So I'm closing this bug report.

Different symptom, but same patch: I guess this should be merged?
-- 
Cheers,
haj





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#48761: perl-mode: "$temp" colored differently.
  2021-06-01  8:17   ` Harald Jörg
@ 2021-06-01  8:32     ` Lars Ingebrigtsen
  2021-06-01 11:05       ` Harald Jörg
  0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-06-01  8:32 UTC (permalink / raw)
  To: Harald Jörg; +Cc: 48761, 積丹尼 Dan Jacobson

haj@posteo.de (Harald Jörg) writes:

> Different symptom, but same patch: I guess this should be merged?

Sure; go ahead.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#48761: perl-mode: "$temp" colored differently.
  2021-06-01  8:32     ` Lars Ingebrigtsen
@ 2021-06-01 11:05       ` Harald Jörg
  0 siblings, 0 replies; 6+ messages in thread
From: Harald Jörg @ 2021-06-01 11:05 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 48761

Lars Ingebrigtsen <larsi@gnus.org> writes:

> haj@posteo.de (Harald Jörg) writes:
>
>> Different symptom, but same patch: I guess this should be merged?
>
> Sure; go ahead.

Done!
--
Cheers,
haj





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-06-01 11:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-31 13:08 bug#48761: perl-mode: "$temp" colored differently 積丹尼 Dan Jacobson
2021-06-01  6:26 ` Lars Ingebrigtsen
2021-06-01  6:27 ` Lars Ingebrigtsen
2021-06-01  8:17   ` Harald Jörg
2021-06-01  8:32     ` Lars Ingebrigtsen
2021-06-01 11:05       ` Harald Jörg

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).