From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#21695: 25.0.50; Change most occurrences of `setq' in Emacs manual to `customize-set-variable'? Really? Date: Mon, 13 Sep 2021 11:18:11 +0200 Message-ID: <87fsu8esvg.fsf@gnus.org> References: <97d3ff2c-9e72-4004-88a9-08130ac99a74@default> <87v93avtoe.fsf@gnus.org> <87r1dyvtav.fsf@gnus.org> <87mtolx6de.fsf@gnus.org> <87ilz9x5c8.fsf@gnus.org> <87y284rb1z.fsf@gnus.org> <0d48a23084a8b0435f37@heytings.org> <83h7eqf9wx.fsf@gnu.org> <0d48a230848de1d1b255@heytings.org> <83ee9uf82a.fsf@gnu.org> <0d48a23084cf7a569554@heytings.org> <83czpef6hj.fsf@gnu.org> <0d48a2308486fe146f77@heytings.org> <87a6khj6s5.fsf@gnus.org> <97113ce8badac94c846f@heytings.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13801"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 21695@debbugs.gnu.org, hmelman@gmail.com, rms@gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 13 11:19:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPi7M-0003PD-9U for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 11:19:12 +0200 Original-Received: from localhost ([::1]:52656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPi7K-0006uh-L9 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 05:19:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPi7C-0006uR-Qb for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 05:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32846) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPi7C-0005bd-IO for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 05:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPi7C-0003MX-7z for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 05:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Sep 2021 09:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21695 X-GNU-PR-Package: emacs Original-Received: via spool by 21695-submit@debbugs.gnu.org id=B21695.163152470112861 (code B ref 21695); Mon, 13 Sep 2021 09:19:02 +0000 Original-Received: (at 21695) by debbugs.gnu.org; 13 Sep 2021 09:18:21 +0000 Original-Received: from localhost ([127.0.0.1]:44392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPi6X-0003LM-Fw for submit@debbugs.gnu.org; Mon, 13 Sep 2021 05:18:21 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:56276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPi6V-0003L4-N6 for 21695@debbugs.gnu.org; Mon, 13 Sep 2021 05:18:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mOw+nchPzftjIcAY8yGdz9Xuu3A52FCfw7jZIe0SpEY=; b=kjwu6x7m3oJZXBYCE3utxcycnB ciDD1jz9DtJ+1hF6BWhA/Xl6LwpB+IwgJbLvuf3Dckkm8hF3MJ88hY4fwsLvT8xGWoHRiIhv0A4Fq CYSgctuzxElOd/aiUYv1ko+j9ejPBJwkuhQZWvbdOvH4GPCiRPlfEtz8hK3Ox0sijBnM=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPi6N-0007Gx-GL; Mon, 13 Sep 2021 11:18:13 +0200 In-Reply-To: <97113ce8badac94c846f@heytings.org> (Gregory Heytings's message of "Mon, 13 Sep 2021 09:11:11 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214210 Archived-At: Gregory Heytings writes: > No, (latin1-display 'latin-2) does not raise a warning with the patch, > because latin1-disp.el is bytecompiled, and Fsetq is not used when > bytecompiled code is executed (bytecompiled code only uses Fset). Right. But it's perfectly valid to run uncompiled code, and these warnings would be false positives in that case. > That being said, I would say that using (setq latin1-display t) when > latin1-display has a :set is always a bug, in the init file, > interactively, or in built-in code (bytecompiled or not), and that > (set 'latin1-display t) should be used instead. WDYT? I have not studied the code -- I just picked a variable at random. The point is that code in a package will commonly use setq on the user options to implement the code, and this is how it should be. (Also note that your patch will issue a bunch of warnings if the user does an `eval-buffer' after loading .emacs into a buffer and then evaling it (in a running Emacs).) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no