From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50642: 27.2; autoload xref-pulse-momentarily Date: Sat, 18 Sep 2021 16:14:04 +0200 Message-ID: <87fsu2rmxf.fsf@gnus.org> References: <1BC3E278-B041-4D01-AA25-706FD01CD1E7@gmail.com> <9F48766D-5656-422E-9608-C1F7203FB8E5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31920"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50642@debbugs.gnu.org, Dmitry Gutov To: Howard Melman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 18 16:15:51 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRb8B-00087K-8D for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 16:15:51 +0200 Original-Received: from localhost ([::1]:60998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mRb89-0005UQ-JZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Sep 2021 10:15:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mRb7O-0004wj-OW for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 10:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mRb7O-0003BN-H8 for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 10:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mRb7O-0003BX-Cr for bug-gnu-emacs@gnu.org; Sat, 18 Sep 2021 10:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Sep 2021 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50642 X-GNU-PR-Package: emacs Original-Received: via spool by 50642-submit@debbugs.gnu.org id=B50642.163197445512105 (code B ref 50642); Sat, 18 Sep 2021 14:15:02 +0000 Original-Received: (at 50642) by debbugs.gnu.org; 18 Sep 2021 14:14:15 +0000 Original-Received: from localhost ([127.0.0.1]:36358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRb6d-00039A-34 for submit@debbugs.gnu.org; Sat, 18 Sep 2021 10:14:15 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mRb6b-00038u-IJ for 50642@debbugs.gnu.org; Sat, 18 Sep 2021 10:14:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=j2AYAnRhm3mz4cayQmLwG31wPgtQE2aOkxhwMKq8VDw=; b=c9vZ3ebTvh4+ork9LgkO8/KgM9 PooaS167pg51f4rhtZ4XR9DFJSbxaesJ6ATtnGGyzWVV1e19xnp4cu+7JKAj9rFiVQpxVgwJhnj6U zxi8WGRANtiFZbJ92Ri1FrNBFpSb0VqZao7UM4ENNGtN2P9lASLhQyICldBZsvyIEzdk=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mRb6T-00041s-3T; Sat, 18 Sep 2021 16:14:07 +0200 In-Reply-To: <9F48766D-5656-422E-9608-C1F7203FB8E5@gmail.com> (Howard Melman's message of "Fri, 17 Sep 2021 21:48:47 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214635 Archived-At: Howard Melman writes: >> Well, um. I don't really mind but xref-pulse-momentarily was >> designed to pulse after a jump to an xref location. That's why it >> refers to xref--current-item in its implementation. Yeah, that's the wrong function to use here, so the Consult documentation should be altered. > I do still think it would be nice for pulse.el to define a function > suitable for use in a jump-like hook that take no arguments and pulses > the current line or maybe symbol. The former is trival, but if > pulse-momentary-highlight-one-line allowed it's POINT argument to be > optional, emacs could provide it for everyone. It seems like in Emacs > 27 all the callers of it just pass (point) anyway. I've now made POINT optional in Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no