From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49700: 27.2; [PATCH] Refactor minibuffer aborting Date: Mon, 20 Sep 2021 08:01:32 +0200 Message-ID: <87fstzkcoz.fsf@gnus.org> References: <87pmvaar0a.fsf@miha-pc> <87im0qrmxe.fsf@miha-pc> <87eeb6b3av.fsf@miha-pc> <87pmt6ho20.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29984"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: miha@kamnitnik.top, 49700@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 20 08:02:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSCNk-0007aG-Kx for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 08:02:24 +0200 Original-Received: from localhost ([::1]:33474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSCNj-00089C-Ca for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 02:02:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSCNO-00083g-Rg for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 02:02:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57373) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSCNO-0004ez-Gx for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 02:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSCNO-00047j-EF for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 02:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Sep 2021 06:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49700 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49700-submit@debbugs.gnu.org id=B49700.163211770615013 (code B ref 49700); Mon, 20 Sep 2021 06:02:02 +0000 Original-Received: (at 49700) by debbugs.gnu.org; 20 Sep 2021 06:01:46 +0000 Original-Received: from localhost ([127.0.0.1]:40676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSCN8-0003tm-0h for submit@debbugs.gnu.org; Mon, 20 Sep 2021 02:01:46 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:57658) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSCN5-0003nw-A0 for 49700@debbugs.gnu.org; Mon, 20 Sep 2021 02:01:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dMmfCh+Qj4szo0UmpBfyUdN9bXqnXV2I5uGeJxl/NGk=; b=eV7eHJhXrKhUQ9GGaBWyusBZ2t K23YJpFdmilTXd/TxS5C+lAv/GLixB4vGWPcf7dJuCIeYRN+hyoW1j3FvlfFNZPG7K+CzlF4wKHXJ CPU4yXZ5gkkdigF0q4N8Fsmma2TCW0MTQ4kddwsfrgNbfHDgXcieIjo4XT+V6BWxz134=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSCMu-0005yI-Ud; Mon, 20 Sep 2021 08:01:35 +0200 In-Reply-To: (Alan Mackenzie's message of "Sun, 19 Sep 2021 19:30:24 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214819 Archived-At: Alan Mackenzie writes: > Apologies for loosing track of this thread a few weeks ago. > > I spent quite some time trying to find things wrong with your latest > patch, but couldn't. ;-) So although I haven't fully tested it, I would > be in favour of merging it to master. Thanks for doing the code review. I've applied the patch and tested it here, and it doesn't seem to lead to any regressions here, so I went ahead and pushed the two patches to Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no