From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 50344@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>,
Filipp Gunbin <fgunbin@fastmail.fm>
Subject: bug#50344: C-x v keybinding for vc-print-branch-log
Date: Wed, 06 Oct 2021 10:29:18 +0300 [thread overview]
Message-ID: <87fstevcfl.fsf@mail.linkov.net> (raw)
In-Reply-To: <30b7d470-26b1-7d7a-2d43-9e85059c1fc5@yandex.ru> (Dmitry Gutov's message of "Wed, 6 Oct 2021 03:37:01 +0300")
>>> The command could have a mode for specifying START-POINT, so for Git the
>>> command becomes "git checkout -b new-branch-name START-POINT". This
>>> could be on C-u (unless there're other frequent "customization" cases).
>> The existing API method has no argument for START-POINT.
>> Maybe every backend could handle its prefix arg directly
>> from current-prefix-arg? For example,
>> (defun vc-git-create-tag (dir name branchp)
>> (if current-prefix-arg (completion-read "Start point: ") ...
>
> Maybe we should add a new argument, an optional one. Then backends which
> don't support it can continue working without 'C-u' (we can make sure to
> call them with appropriate number of arguments) but will obviously fail
> when passed an extra argument. We could even catch the error and report
> that the backend doesn't support this feature.
We need to add new optional arguments to another VC-API methods anyway, e.g.
(vc-call-backend backend 'revision-completion-table files)
needs a new argument 'branchp' to avoid the recently added hack
'vc-git-revision-complete-only-branches' that can't be used
in the new command 'vc-switch-branch' by 'vc-read-revision'
(that also needs a new argument 'branchp').
> But maybe the command should prompt for START-POINT by default: one doesn't
> create branches that often to be bothered by an extra RET, and it can be
> useful to verify the branch you are branching off of every time you do
> it. That would be my preferred behavior. And the implementation could be
> the same if we manage to treat RET as unspecified START-POINT.
Prompting for START-POINT by default is ok. The problem is how to handle
existing backends after adding new optional arguments to VC-API methods.
Maybe first to call with an extra argument, catch an error, then call again
without an extra argument?
next prev parent reply other threads:[~2021-10-06 7:29 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 18:43 bug#50344: C-x v keybinding for vc-print-branch-log Juri Linkov
2021-09-02 23:24 ` Dmitry Gutov
2021-09-03 8:15 ` Juri Linkov
2021-09-03 12:26 ` Dmitry Gutov
2021-09-03 16:18 ` Juri Linkov
2021-09-03 16:41 ` Dmitry Gutov
2021-09-04 6:33 ` Lars Ingebrigtsen
2021-09-05 16:28 ` Juri Linkov
2021-09-06 8:25 ` Lars Ingebrigtsen
2021-09-06 15:19 ` Juri Linkov
2021-09-07 15:05 ` Lars Ingebrigtsen
2021-09-08 2:58 ` Dmitry Gutov
2021-09-08 8:00 ` Lars Ingebrigtsen
2021-09-08 11:59 ` Dmitry Gutov
2021-09-09 17:39 ` Juri Linkov
2021-09-09 23:18 ` Dmitry Gutov
2021-09-10 6:46 ` Juri Linkov
2021-09-10 11:27 ` Dmitry Gutov
2021-09-10 10:32 ` Lars Ingebrigtsen
2021-09-10 11:26 ` Dmitry Gutov
2021-09-13 7:47 ` Juri Linkov
2021-10-07 7:21 ` Juri Linkov
2021-10-07 7:47 ` Eli Zaretskii
2021-10-07 7:58 ` Juri Linkov
2021-10-07 8:28 ` Eli Zaretskii
2021-10-07 11:12 ` Dmitry Gutov
2021-10-07 12:56 ` Eli Zaretskii
2021-10-07 13:06 ` Dmitry Gutov
2021-10-07 13:21 ` Eli Zaretskii
2021-10-07 13:26 ` Dmitry Gutov
2021-10-07 13:50 ` Eli Zaretskii
2021-10-07 17:36 ` Juri Linkov
2021-10-07 18:22 ` Eli Zaretskii
2021-10-07 21:49 ` Dmitry Gutov
2021-10-12 12:48 ` Filipp Gunbin
2021-10-13 1:45 ` Dmitry Gutov
2021-10-13 10:12 ` Filipp Gunbin
2021-10-13 23:37 ` Dmitry Gutov
2021-12-24 11:56 ` Philip Kaludercic
2021-12-24 12:03 ` Dmitry Gutov
2021-12-24 13:57 ` Philip Kaludercic
2021-12-24 23:45 ` Dmitry Gutov
2021-12-25 11:37 ` Philip Kaludercic
2021-12-25 12:08 ` Dmitry Gutov
2022-09-09 5:46 ` Sean Whitton
2022-09-09 6:29 ` Juri Linkov
2022-09-09 17:09 ` Lars Ingebrigtsen
2022-09-11 15:10 ` Juri Linkov
2022-09-11 15:25 ` Lars Ingebrigtsen
2022-09-12 18:07 ` Juri Linkov
2022-09-12 18:21 ` Eli Zaretskii
2022-09-12 19:13 ` Juri Linkov
2022-09-13 12:24 ` Eli Zaretskii
2022-09-12 18:57 ` Sean Whitton
2021-10-07 13:11 ` Robert Pluim
2021-10-07 13:51 ` Filipp Gunbin
2021-10-07 9:57 ` Gregory Heytings
2021-10-07 11:14 ` Dmitry Gutov
2021-10-07 11:25 ` Gregory Heytings
2021-10-07 11:35 ` Dmitry Gutov
2021-10-07 11:42 ` Gregory Heytings
2021-10-07 12:25 ` Kévin Le Gouguec
2021-10-07 12:42 ` Filipp Gunbin
2021-10-07 12:53 ` Dmitry Gutov
2021-10-07 13:11 ` Eli Zaretskii
2021-10-07 12:51 ` Eli Zaretskii
2021-10-07 17:30 ` Juri Linkov
2021-10-07 18:25 ` Eli Zaretskii
2021-09-16 11:46 ` Filipp Gunbin
2021-09-16 11:54 ` Dmitry Gutov
2021-09-17 15:15 ` Filipp Gunbin
2021-09-18 0:09 ` bug#50643: " Dmitry Gutov
2021-09-18 19:03 ` Juri Linkov
2021-09-19 0:01 ` Dmitry Gutov
2021-09-19 17:04 ` bug#50643: " Juri Linkov
2021-09-20 0:33 ` Dmitry Gutov
2021-09-20 6:49 ` bug#50643: " Juri Linkov
2021-09-20 16:53 ` Dmitry Gutov
2021-09-20 17:31 ` Filipp Gunbin
2021-09-20 15:59 ` bug#50643: " Filipp Gunbin
2021-10-05 17:43 ` Juri Linkov
2021-10-06 0:37 ` Dmitry Gutov
2021-10-06 7:29 ` Juri Linkov [this message]
2021-10-07 0:57 ` Dmitry Gutov
2021-10-06 16:28 ` Juri Linkov
2021-10-07 0:47 ` Dmitry Gutov
2021-10-07 12:46 ` Filipp Gunbin
2021-10-07 12:55 ` Robert Pluim
2021-10-07 17:27 ` Juri Linkov
2021-09-08 2:50 ` Dmitry Gutov
2021-09-08 7:53 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fstevcfl.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=50344@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=fgunbin@fastmail.fm \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).