From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51652: Acknowledgement (29.0.50; [PATCH] Fix C-r inside xwidget isearch) Date: Sun, 07 Nov 2021 14:30:33 +0800 Message-ID: <87fss8wk8m.fsf@yahoo.com> References: <87lf20wkiw.fsf@yahoo.com> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25066"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) To: 51652@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 07 07:31:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjbhv-0006KM-Ub for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 07:31:12 +0100 Original-Received: from localhost ([::1]:56022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjbhu-0002CB-0g for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 01:31:10 -0500 Original-Received: from [2001:470:142:3::10] (port=38700 helo=eggs.gnu.org) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjbhm-0002Bl-Fr for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 01:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjbhm-0000K5-7M for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 01:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjbhm-0005BZ-0j for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 01:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Nov 2021 06:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51652 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51652-submit@debbugs.gnu.org id=B51652.163626665219917 (code B ref 51652); Sun, 07 Nov 2021 06:31:01 +0000 Original-Received: (at 51652) by debbugs.gnu.org; 7 Nov 2021 06:30:52 +0000 Original-Received: from localhost ([127.0.0.1]:51583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjbhc-0005BB-7s for submit@debbugs.gnu.org; Sun, 07 Nov 2021 01:30:52 -0500 Original-Received: from sonic304-20.consmr.mail.ne1.yahoo.com ([66.163.191.146]:38949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjbhZ-0005As-DZ for 51652@debbugs.gnu.org; Sun, 07 Nov 2021 01:30:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636266643; bh=j2c/p2vgNuC6+Giik/tjGGI+SHLXfGhOG+Vdb/EO2pg=; h=From:To:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=LxhBQFVM38rRLYYGFlheV/NvFIIqc8T1V54REE1hIgWkrHrbFpgDJ6CSRjUHW80gaPXXw09YDt6z2iVd7cWVqR65qjbiox5D49MfzMcXGlw6nlevulBfhwETQW4ieGoetcmht1TfizwfVXtqSGajDLNv0xOdKl5zneCpYcFjKdFaZl7EwHNRyybuEwGMiDc6UtZ1yEovLJ2nXMKb3e62V9DQuh1TEh87XhqdmHYnB3iX+oo6qeGwYxI+bR6yPdTgeHoz3uv/CS0+SHW7tjtVNRBrou7BLanQI6Pl9NS3A1jKhVwcaBfAbVQOT9Pd2YKduW2vHnVQbMqx0SFCuYdTzw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636266643; bh=Sx55Q2HWi54H+drmpckgJ4uSMtawzGoJhscjscS8/Fi=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=NG3xnIvSpkF1hY36CS0ME5koV6GQAtwE8alDuu5vadjyPw9EI/U116nOWExzY+xiBhPdcRCCJ+kb55qeLz+qfWDDPJZs6e0809UAV2gUrbPeRQLiD2fiUq3/B+/N5XO/KqhJwEurL4P0QCcIqh3fPcSPiF08wR0WplaWfvzHSJu7+yNmYyXROtBcoqPsY55/o1YSh7uNPRQq2cfQWgLa/FsJ9AVV4iMOIeIerUkIgIxLrssVVJdH+1LkD7sr2utEAbAtnCYyjYl+FXdoBAWFp5VIfs1v8o8oHPhmQFv0T7jHQjNS8ACa44erweOiUmklsWgy9wbmZxw0RZZmjhx3OQ== X-YMail-OSG: BeipXJUVM1mTpIYCcOpUTD541xEKZAKeVknQpPUxdCWn85Q3PoyrYB4hwossbWt .1eL1xCy0M9JrVwZqWvl6.mgC8_vn3pb5g.rV11Bj1t8JRJrQ2JEKOoCqbJZ3r7Iqfkz6d01uM1B ICoEp4bxM47xe2sRBwjoDOekjdsUCmhCUjh5gRJKIs8mFuDYEwsSFknvue5gwUyOsPR2kxyrSz5o .mT7F1jabjqn9D3HGIlI_AtuDiE2_areh59zK4hOnJxE1GRmhuZ9xurZd08WESrb3AiXhAm8CNHv YLifb4gzFvn6atQwy5lE7.wbIL5qF3NINU38LfQZBYCH8MDiFFOqOU6eIlna65ov.LsI_1K5hXlv D_..QO8.Vmji7v.Bkdksxc4vjZOAi7CedDGTm78vPxfofKimeGZO30og_aDkw359Z9NWij6b2xmG NCyWFjccZEf.Qn8Rb_Aw6oiFX2sfKZ3QBZrbDUIEzK1zrkBbBLDngL0a.gdRJFkQqQtaj7hQADUE OztqePssdDz5XgbFD.tdtiC_.zbaRGkTzCNTxQvUJiHWNDpc5_cEabdDPA4sY_SpAmgdBXLaOGNw p02pU9EsiHv.9Lcj3n8fZDDGhBJHu3JX4cfcuxxTpW3..lRMkzRssT8SwixPC9Paviva4oRnbAqb u6WhKO1hSBcwaUqDR19xzh_r995bkNzT_z5cw665HzoxyKFWdaRhSj94yyx3hMS2C9KHkL4iP90Q ISTcTvCjZZigoHt_V6ZOj9PuEErIDtNZyaF._RTgsGksJYLRUAQwmZsvlU3IpObXnhWmgOyxCflJ l6XjZLH98M5jHOcQz9T8Hf31X4L7S8SeWHZcZj3adZ X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Sun, 7 Nov 2021 06:30:43 +0000 Original-Received: by kubenode510.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID d8a395b2350f0f30c17b2696f0b72167; Sun, 07 Nov 2021 06:30:36 +0000 (UTC) In-Reply-To: (GNU bug Tracking System's message of "Sun, 07 Nov 2021 06:25:02 +0000") X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219203 Archived-At: --=-=-= Content-Type: text/plain help-debbugs@gnu.org (GNU bug Tracking System) writes: > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > Your message has been sent to the package maintainer(s): > bug-gnu-emacs@gnu.org > > If you wish to submit further information on this problem, please > send it to 51652@debbugs.gnu.org. > > Please do not send mail to help-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. Here's something else I caught: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Free-find-text-in-correct-procedure.patch >From 518f879a2ee2c0fb355187de7bdca0e67fe07aca Mon Sep 17 00:00:00 2001 From: Po Lu Date: Sun, 7 Nov 2021 14:28:37 +0800 Subject: [PATCH] Free find text in correct procedure * src/xwidget.c (Fxwidget_webkit_previous_result): Don't free find text. (Fxwidget_webkit_finish_search): Free find text here instead. --- src/xwidget.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/xwidget.c b/src/xwidget.c index 7944ca5c4b..5384938461 100644 --- a/src/xwidget.c +++ b/src/xwidget.c @@ -2001,12 +2001,6 @@ DEFUN ("xwidget-webkit-previous-result", Fxwidget_webkit_previous_result, webview = WEBKIT_WEB_VIEW (xw->widget_osr); controller = webkit_web_view_get_find_controller (webview); webkit_find_controller_search_previous (controller); - - if (xw->find_text) - { - xfree (xw->find_text); - xw->find_text = NULL; - } unblock_input (); #endif @@ -2039,6 +2033,12 @@ DEFUN ("xwidget-webkit-finish-search", Fxwidget_webkit_finish_search, webview = WEBKIT_WEB_VIEW (xw->widget_osr); controller = webkit_web_view_get_find_controller (webview); webkit_find_controller_search_finish (controller); + + if (xw->find_text) + { + xfree (xw->find_text); + xw->find_text = NULL; + } unblock_input (); #endif -- 2.31.1 --=-=-= Content-Type: text/plain Thanks. And sorry for all the noise. --=-=-=--