From: Ihor Radchenko <yantar92@gmail.com>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 51941@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#51941: Detect duplication of ERT tests
Date: Wed, 24 Nov 2021 17:29:02 +0800 [thread overview]
Message-ID: <87fsrlc36p.fsf@localhost> (raw)
In-Reply-To: <5AA13574-8ED8-450E-8F92-1C374A2717AB@acm.org>
Mattias Engdegård <mattiase@acm.org> writes:
> 24 nov. 2021 kl. 08.30 skrev Ihor Radchenko <yantar92@gmail.com>:
>
>> This change breaks test code when a test file is "required" multiple
>> times. In particular, Org mode tests cannot run with latest Emacs.
>
> We'll have to do something about that then. Would you tell me more precisely what those Org tests do and why?
> ('require' is supposed to be idempotent; maybe you are missing a 'provide' somewhere?)
In Org 9.5, we have test-oc.el. That file requires a macro defined in
test-ox.el:
In test-oc.el:
;; We need `org-test-with-parsed-data' macro.
(require 'test-ox "../testing/lisp/test-ox.el")
The load sequence is:
1. load-file test-oc
1.1. test-oc requires test-ox
2. load file test-ox triggers error:
Debugger entered--Lisp error: (error "Test ‘test-org-export/bind-keyword’ redefined")
Hope it helps.
Best,
Ihor
next prev parent reply other threads:[~2021-11-24 9:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 10:16 bug#51941: Detect duplication of ERT tests Mattias Engdegård
2021-11-18 10:35 ` Lars Ingebrigtsen
2021-11-18 11:54 ` Mattias Engdegård
2021-11-18 11:58 ` Lars Ingebrigtsen
2021-11-18 17:44 ` Lars Ingebrigtsen
2021-11-18 17:53 ` Philipp Stephani
2021-11-18 19:13 ` Mattias Engdegård
2021-11-18 19:34 ` Lars Ingebrigtsen
2021-11-18 19:43 ` Mattias Engdegård
2021-11-18 22:51 ` Glenn Morris
2021-11-19 5:28 ` Lars Ingebrigtsen
2021-11-19 9:33 ` Mattias Engdegård
2021-11-20 8:38 ` Lars Ingebrigtsen
2021-11-20 8:49 ` Mattias Engdegård
2021-11-24 7:30 ` Ihor Radchenko
2021-11-24 8:52 ` Mattias Engdegård
2021-11-24 9:29 ` Ihor Radchenko [this message]
2021-11-24 10:00 ` Mattias Engdegård
2021-11-24 12:16 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsrlc36p.fsf@localhost \
--to=yantar92@gmail.com \
--cc=51941@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).