unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
@ 2020-12-20  4:53 Michael Heerdegen
  2020-12-21  4:56 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 27+ messages in thread
From: Michael Heerdegen @ 2020-12-20  4:53 UTC (permalink / raw)
  To: 45330; +Cc: Eric Abrahamsen, Lars Ingebrigtsen


Hi,

sorry if I had already reported this and a fix is on the way.  Or had it
been fixed and has reappeared, or even my fault this time?

I'm doing something like

  (debbugs-gnu-search "debbugs" '((subject . "debbugs")) nil nil nil)

and when I hit RET over a bug's line I get this error:

| Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
|   gnus-summary-goto-subject(0)
|   gnus-summary-last-subject()
|   gnus-summary-highlight-line()
|   gnus-summary-insert-line([0 "" "" "05 Apr 2001 23:33:09 +0400" "" "" 0 0 "" nil] 0 nil t 90 t nil "" nil 1)
|   gnus-update-summary-mark-positions()
|   gnus-summary-read-group-1("nndoc+ephemeral:bug#36903" t t nil nil nil)
|   gnus-summary-read-group("nndoc+ephemeral:bug#36903" t t nil nil nil nil)
|   gnus-group-read-group(t t "nndoc+ephemeral:bug#36903" nil)
|   gnus-group-read-ephemeral-group("nndoc+ephemeral:bug#36903" (nndoc "/tmp/gnus-temp-group-lGIifE" (nndoc-article-type mbox)) nil (#<buffer *"debbugs" Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-bug-group((36903) "https://debbugs.gnu.org/cgi/bugreport.cgi?bug=%s;m..." (#<buffer *"debbugs" Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-emacs-bug-group((36903) (#<buffer *"debbugs" Bugs*> . #<window-configuration>))
|   debbugs-gnu-read-emacs-bug-with-gnus(36903 ((cache_time . 1608439370.59222) (last_modified . 1573129444) (done . "Eric Abrahamsen <eric@ericabrahamsen.net>") (summary) (forwarded) (source . "unknown") (log_modified . 1573129444) (blockedby) (found_versions "27.0.50") (fixed_versions) (subject . "27.0.50; gnus registry vs. debbugs") (archived . t) (affects) (package "emacs") (location . "archive") (originator . "Michael Heerdegen <michael_heerdegen@web.de>") (date . 1564816382) (severity . "normal") (owner) (keywords) (fixed) (found (item (key . "27.0.50") (value))) (bug_num . 36903) (fixed_date) (id . 36903) (tags) (unarchived) (msgid . "<87pnlmen9q.fsf@web.de>") (pending . "done") (blocks) (found_date) (mergedwith)) nil)
|   debbugs-gnu-select-report()
|   funcall-interactively(debbugs-gnu-select-report)
|   call-interactively(debbugs-gnu-select-report nil nil)
|   command-execute(debbugs-gnu-select-report)

Annoying.  When I had started Gnus before, this doesn't happen.

TIA,

Michael.







^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2020-12-20  4:53 bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus Michael Heerdegen
@ 2020-12-21  4:56 ` Lars Ingebrigtsen
  2020-12-21  7:10   ` Michael Heerdegen
  0 siblings, 1 reply; 27+ messages in thread
From: Lars Ingebrigtsen @ 2020-12-21  4:56 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: Eric Abrahamsen, 45330

Michael Heerdegen <michael_heerdegen@web.de> writes:

> sorry if I had already reported this and a fix is on the way.  Or had it
> been fixed and has reappeared, or even my fault this time?
>
> I'm doing something like
>
>   (debbugs-gnu-search "debbugs" '((subject . "debbugs")) nil nil nil)
>
> and when I hit RET over a bug's line I get this error:
>
> | Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
> |   gnus-summary-goto-subject(0)
> |   gnus-summary-last-subject()
> |   gnus-summary-highlight-line()
> |   gnus-summary-insert-line([0 "" "" "05 Apr 2001 23:33:09 +0400" ""
> | "" 0 0 "" nil] 0 nil t 90 t nil "" nil 1)
> |   gnus-update-summary-mark-positions()

I think this should be fixed on the trunk now -- can you check?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2020-12-21  4:56 ` Lars Ingebrigtsen
@ 2020-12-21  7:10   ` Michael Heerdegen
  2020-12-21 16:12     ` Eric Abrahamsen
  0 siblings, 1 reply; 27+ messages in thread
From: Michael Heerdegen @ 2020-12-21  7:10 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Eric Abrahamsen, 45330

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I think this should be fixed on the trunk now -- can you check?

Ok, thanks.  Yes, good, though, now I get (deja vu again):

| Debugger entered--Lisp error: (cl-no-applicable-method registry-lookup nil ("<84k479sz16.fsf@aol.com>"))
|   signal(cl-no-applicable-method (registry-lookup nil ("<84k479sz16.fsf@aol.com>")))
|   cl-no-applicable-method(#s(cl--generic registry-lookup ((1 #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 "\n\n(fn NAME &rest _)"] #[385 "\300\207" [(t)] 3 "\n\n(fn TAG &rest _)"])) (0 #s(cl--generic-generalizer eieio--generic-generalizer 50 cl--generic-struct-tag #[385 "\1\301N\302\1!\10>\205\21\0\303\304\305\3!\"\207" [cl-struct-eieio--class-tags cl--class type-of mapcar eieio--class-name eieio--class-precedence-list] 7 "\n\n(fn TAG &rest _)"]) #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 "\n\n(fn NAME &rest _)"] #[385 "\300\207" [(t)] 3 "\n\n(fn TAG &rest _)"]))) (#s(cl--generic-method (registry-db t) nil nil #[(db keys) "\303\10\301\"\31\304\305\306\307\n\"\")\207" [db data keys eieio-oref delq nil mapcar #[(k) "\302\10\11\"\205\15\0\10\302\10\11\"D\207" [k data gethash] 4]] 5 "Search for KEYS in the registry-db DB.\nReturns an alist of the key followed by the entry in a list, not a cons cell."])) nil) nil ("<84k479sz16.fsf@aol.com>"))
|   apply(cl-no-applicable-method #s(cl--generic registry-lookup ((1 #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 "\n\n(fn NAME &rest _)"] #[385 "\300\207" [(t)] 3 "\n\n(fn TAG &rest _)"])) (0 #s(cl--generic-generalizer eieio--generic-generalizer 50 cl--generic-struct-tag #[385 "\1\301N\302\1!\10>\205\21\0\303\304\305\3!\"\207" [cl-struct-eieio--class-tags cl--class type-of mapcar eieio--class-name eieio--class-precedence-list] 7 "\n\n(fn TAG &rest _)"]) #s(cl--generic-generalizer cl--generic-t-generalizer 0 #[385 "\300\207" [nil] 3 "\n\n(fn NAME &rest _)"] #[385 "\300\207" [(t)] 3 "\n\n(fn TAG &rest _)"]))) (#s(cl--generic-method (registry-db t) nil nil #[(db keys) "\303\10\301\"\31\304\305\306\307\n\"\")\207" [db data keys eieio-oref delq nil mapcar #[(k) "\302\10\11\"\205\15\0\10\302\10\11\"D\207" [k data gethash] 4]] 5 "Search for KEYS in the registry-db DB.\nReturns an alist of the key followed by the entry in a list, not a cons cell."])) nil) (nil ("<84k479sz16.fsf@aol.com>")))
|   #f(compiled-function (&rest args) #<bytecode 0x306e3026b507eed>)(nil ("<84k479sz16.fsf@aol.com>"))
|   apply(#f(compiled-function (&rest args) #<bytecode 0x306e3026b507eed>) nil ("<84k479sz16.fsf@aol.com>"))
|   registry-lookup(nil ("<84k479sz16.fsf@aol.com>"))
|   gnus-registry-get-or-make-entry("<84k479sz16.fsf@aol.com>" nil)
|   gnus-registry-get-id-key("<84k479sz16.fsf@aol.com>" mark)
|   gnus-user-format-function-M([2 "bug#10000: 24.0.91; Gnus gnus-get-function error" "nyc4bos@aol.com" #("Tue, 08 Nov 2011 23:25:09 -0500" 0 1 (gnus-time (20154 165))) "<84k479sz16.fsf@aol.com>" nil -1 119 nil ((To . "10000@debbugs.gnu.org"))])
|   (format "%c%c%s%s%2s%c%9s %s" gnus-tmp-unread gnus-tmp-replied (gnus-user-format-function-S gnus-tmp-header) (gnus-user-format-function-g gnus-tmp-header) (gnus-user-format-function-M gnus-tmp-header) gnus-tmp-score-char (gnus-user-date (mail-header-date gnus-tmp-header)) gnus-tmp-indentation)
|   (insert (format "%c%c%s%s%2s%c%9s %s" gnus-tmp-unread gnus-tmp-replied (gnus-user-format-function-S gnus-tmp-header) (gnus-user-format-function-g gnus-tmp-header) (gnus-user-format-function-M gnus-tmp-header) gnus-tmp-score-char (gnus-user-date (mail-header-date gnus-tmp-header)) gnus-tmp-indentation))
|   (progn (insert (format "%c%c%s%s%2s%c%9s %s" gnus-tmp-unread gnus-tmp-replied (gnus-user-format-function-S gnus-tmp-header) (gnus-user-format-function-g gnus-tmp-header) (gnus-user-format-function-M gnus-tmp-header) gnus-tmp-score-char (gnus-user-date (mail-header-date gnus-tmp-header)) gnus-tmp-indentation)) (put-text-property (point) (progn (insert (format "%-23s" (let* ((val ...) (need ...)) (if (> need 0) (concat nil val ...) val)))) (point)) 'mouse-face gnus-mouse-face) (insert "   ") (add-text-properties (point) (progn (insert gnus-tmp-subject-or-nil) (point)) (cons 'face (cons (list 'font-lock-variable-name-face 'default) '(gnus-face t)))) (insert "\n"))
|   eval((progn (insert (format "%c%c%s%s%2s%c%9s %s" gnus-tmp-unread gnus-tmp-replied (gnus-user-format-function-S gnus-tmp-header) (gnus-user-format-function-g gnus-tmp-header) (gnus-user-format-function-M gnus-tmp-header) gnus-tmp-score-char (gnus-user-date (mail-header-date gnus-tmp-header)) gnus-tmp-indentation)) (put-text-property (point) (progn (insert (format "%-23s" (let* (... ...) (if ... ... val)))) (point)) 'mouse-face gnus-mouse-face) (insert "   ") (add-text-properties (point) (progn (insert gnus-tmp-subject-or-nil) (point)) (cons 'face (cons (list 'font-lock-variable-name-face 'default) '(gnus-face t)))) (insert "\n")))
|   gnus-summary-prepare-threads((([2 "bug#10000: 24.0.91; Gnus gnus-get-function error" "nyc4bos@aol.com" #("Tue, 08 Nov 2011 23:25:09 -0500" 0 1 (gnus-time (20154 165))) "<84k479sz16.fsf@aol.com>" nil -1 119 nil ((To . "10000@debbugs.gnu.org"))] ([3 "bug#10000: 24.0.91; Gnus gnus-get-function error" "Lars Magne Ingebrigtsen <larsi@gnus.org>" "Sat, 07 Jan 2012 00:34:39 +0100" "<m3boqg5rsg.fsf@stories.gnus.org>" "<84k479sz16.fsf@aol.com>" -1 21 nil ((Cc . "10000@debbugs.gnu.org") (To . "nyc4bos@aol.com"))])) ([4 "control message for bug #10000" "Lars Magne Ingebrigtsen <larsi@gnus.org>" #("Sat, 07 Jan 2012 00:34:43 +0100" 0 1 (gnus-time (20231 34067))) "<m3aa605rsc.fsf@stories.gnus.org>" nil -1 6 nil ((To . "control@debbugs.gnu.org, 10000@debbugs.gnu.org"))]) ([1 "Status: 24.0.91; Gnus gnus-get-function error" "bug#10000 <10000@debbugs.gnu.org>" #("Mon, 21 Dec 2020 07:03:37 +0000" 0 1 (gnus-time (24544 18633))) "fake+none+nndoc+ephemeral:bug#10000+1" nil -1 9 nil ((To . "bug#10000 <10000@debbugs.gnu.org>"))])))
|   gnus-summary-prepare()
|   gnus-summary-read-group-1("nndoc+ephemeral:bug#10000" t t nil nil nil)
|   gnus-summary-read-group("nndoc+ephemeral:bug#10000" t t nil nil nil nil)
|   gnus-group-read-group(t t "nndoc+ephemeral:bug#10000" nil)
|   gnus-group-read-ephemeral-group("nndoc+ephemeral:bug#10000" (nndoc "/tmp/gnus-temp-group-hZ7CcZ" (nndoc-article-type mbox)) nil (#<buffer *Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-bug-group((10000) "https://debbugs.gnu.org/cgi/bugreport.cgi?bug=%s;m..." (#<buffer *Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-emacs-bug-group((10000) (#<buffer *Bugs*> . #<window-configuration>))
|   debbugs-gnu-read-emacs-bug-with-gnus(10000 ((cache_time . 1608534206.8331993) (msgid . "<84k479sz16.fsf@aol.com>") (package "emacs" "gnus") (forwarded) (owner) (tags "notabug") (found_versions "24.0.91") (fixed_date) (fixed_versions) (mergedwith) (last_modified . 1328358242) (done . "Lars Magne Ingebrigtsen <larsi@gnus.org>") (found_date) (affects) (location . "archive") (originator . "nyc4bos@aol.com") (found (item (key . "24.0.91") (value))) (source . "unknown") (keywords "notabug") (subject . "24.0.91; Gnus gnus-get-function error") (bug_num . 10000) (pending . "done") (id . 10000) (blocks) (summary) (log_modified . 1328358242) (fixed) (severity . "minor") (unarchived) (date . 1320812762) (archived . t) (blockedby)) nil)
|   debbugs-gnu-select-report()

I have

#+begin_src emacs-lisp
(defalias 'gnus-user-format-function-M
  'gnus-registry-article-marks-to-chars)
#+end_src

and am using it in `gnus-summary-line-format'.  Can you reproduce that
problem?


Thanks,

Michael.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2020-12-21  7:10   ` Michael Heerdegen
@ 2020-12-21 16:12     ` Eric Abrahamsen
  2020-12-22 16:43       ` Eric Abrahamsen
  0 siblings, 1 reply; 27+ messages in thread
From: Eric Abrahamsen @ 2020-12-21 16:12 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: Lars Ingebrigtsen, 45330

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> I think this should be fixed on the trunk now -- can you check?
>
> Ok, thanks.  Yes, good, though, now I get (deja vu again):
>
> | Debugger entered--Lisp error: (cl-no-applicable-method
> | registry-lookup nil ("<84k479sz16.fsf@aol.com>"))

Yes, we've been here before, in bug 36903, and commit a81223aeaa...





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2020-12-21 16:12     ` Eric Abrahamsen
@ 2020-12-22 16:43       ` Eric Abrahamsen
  2020-12-23  5:23         ` Michael Heerdegen
  0 siblings, 1 reply; 27+ messages in thread
From: Eric Abrahamsen @ 2020-12-22 16:43 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: Lars Ingebrigtsen, 45330


On 12/21/20 08:12 AM, Eric Abrahamsen wrote:
> Michael Heerdegen <michael_heerdegen@web.de> writes:
>
>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>>
>>> I think this should be fixed on the trunk now -- can you check?
>>
>> Ok, thanks.  Yes, good, though, now I get (deja vu again):
>>
>> | Debugger entered--Lisp error: (cl-no-applicable-method
>> | registry-lookup nil ("<84k479sz16.fsf@aol.com>"))
>
> Yes, we've been here before, in bug 36903, and commit a81223aeaa...

Oh hang on, it looks like that took me several tries to get right,
in a81223aeaa, 87b7c06958, a34216351f, and then finally ae76ce57cf, in
which it looks like I was confident that checking
`gnus-registry-enabled' was sufficient to ensure that the registry was
actually an object. Give me a second to figure out why that's not true.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2020-12-22 16:43       ` Eric Abrahamsen
@ 2020-12-23  5:23         ` Michael Heerdegen
  2020-12-23 18:08           ` Eric Abrahamsen
  0 siblings, 1 reply; 27+ messages in thread
From: Michael Heerdegen @ 2020-12-23  5:23 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: Lars Ingebrigtsen, 45330

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Oh hang on, it looks like that took me several tries to get right,
> in a81223aeaa, 87b7c06958, a34216351f, and then finally ae76ce57cf,

Wow...

> in which it looks like I was confident that checking
> `gnus-registry-enabled' was sufficient to ensure that the registry was
> actually an object. Give me a second to figure out why that's not
> true.

Ok, please keep me informed :-)


TIA,

Michael.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2020-12-23  5:23         ` Michael Heerdegen
@ 2020-12-23 18:08           ` Eric Abrahamsen
  2021-12-04 23:18             ` Lars Ingebrigtsen
  0 siblings, 1 reply; 27+ messages in thread
From: Eric Abrahamsen @ 2020-12-23 18:08 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: Lars Ingebrigtsen, 45330


On 12/23/20 06:23 AM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> Oh hang on, it looks like that took me several tries to get right,
>> in a81223aeaa, 87b7c06958, a34216351f, and then finally ae76ce57cf,
>
> Wow...

It was embarrassing.

>> in which it looks like I was confident that checking
>> `gnus-registry-enabled' was sufficient to ensure that the registry was
>> actually an object. Give me a second to figure out why that's not
>> true.
>
> Ok, please keep me informed :-)

So it's pretty clear: `gnus-registry-initialize' in effect looks like
this:

(defun gnus-registry-initialize ()
  (gnus-registry-install-hooks) -> (setq gnus-registry-enabled t)
  (if (gnus-alive-p)
      (gnus-registry-load)
    (add-hook 'gnus-read-newsrc-el-hook #'gnus-registry-load)))

So in your case `gnus-registry-enabled' is set to t, but then
`gnus-registry-load' is never called (because Gnus is neither alive, nor
loaded later).

I suppose it's still reasonable to set `gnus-registry-enabled' in this
way -- the registry is, in fact, "enabled", it simply hasn't gotten
loaded (the naming problem again!). Perhaps the formatting functions
should go back to the earlier, more explicit check of `eieio-object-p'.

Bleagh.

Eric





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2020-12-23 18:08           ` Eric Abrahamsen
@ 2021-12-04 23:18             ` Lars Ingebrigtsen
  2021-12-05  0:23               ` Michael Heerdegen
  0 siblings, 1 reply; 27+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-04 23:18 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: Michael Heerdegen, 45330

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> I suppose it's still reasonable to set `gnus-registry-enabled' in this
> way -- the registry is, in fact, "enabled", it simply hasn't gotten
> loaded (the naming problem again!). Perhaps the formatting functions
> should go back to the earlier, more explicit check of `eieio-object-p'.

This was almost a year ago -- is this still failing?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-04 23:18             ` Lars Ingebrigtsen
@ 2021-12-05  0:23               ` Michael Heerdegen
  2021-12-05 19:48                 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 27+ messages in thread
From: Michael Heerdegen @ 2021-12-05  0:23 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Eric Abrahamsen, 45330

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
> > I suppose it's still reasonable to set `gnus-registry-enabled' in this
> > way -- the registry is, in fact, "enabled", it simply hasn't gotten
> > loaded (the naming problem again!). Perhaps the formatting functions
> > should go back to the earlier, more explicit check of `eieio-object-p'.
>
> This was almost a year ago -- is this still failing?

Yes, it still bugs me all the time.

Michael.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-05  0:23               ` Michael Heerdegen
@ 2021-12-05 19:48                 ` Lars Ingebrigtsen
  2021-12-05 22:18                   ` Eric Abrahamsen
  0 siblings, 1 reply; 27+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-05 19:48 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: Eric Abrahamsen, 45330

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Yes, it still bugs me all the time.

Right.  Eric, could you have a look at this again?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-05 19:48                 ` Lars Ingebrigtsen
@ 2021-12-05 22:18                   ` Eric Abrahamsen
  2021-12-06  1:14                     ` Michael Heerdegen
                                       ` (2 more replies)
  0 siblings, 3 replies; 27+ messages in thread
From: Eric Abrahamsen @ 2021-12-05 22:18 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Michael Heerdegen, 45330


On 12/05/21 20:48 PM, Lars Ingebrigtsen wrote:
> Michael Heerdegen <michael_heerdegen@web.de> writes:
>
>> Yes, it still bugs me all the time.
>
> Right.  Eric, could you have a look at this again?

I can switch the test to be something more explicit, but how about --
bear with me here -- making `gnus-summary-line-format' a group
parameter? It's something I've been thinking about for a while. It would
be really nice to be able to give different groups different summary
appearances. And it would allow Michael and everyone else to use a
separate format string for groups like debbugs or whatnot, that are
often opened without Gnus actually being running.

WDYT?





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-05 22:18                   ` Eric Abrahamsen
@ 2021-12-06  1:14                     ` Michael Heerdegen
  2021-12-06  1:29                       ` Eric Abrahamsen
  2021-12-06  5:46                     ` Lars Ingebrigtsen
  2021-12-12  2:46                     ` Michael Heerdegen
  2 siblings, 1 reply; 27+ messages in thread
From: Michael Heerdegen @ 2021-12-06  1:14 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: Lars Ingebrigtsen, 45330

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> I can switch the test to be something more explicit, but how about --
> bear with me here -- making `gnus-summary-line-format' a group
> parameter? It's something I've been thinking about for a while. It would
> be really nice to be able to give different groups different summary
> appearances. And it would allow Michael and everyone else to use a
> separate format string for groups like debbugs or whatnot, that are
> often opened without Gnus actually being running.
>
> WDYT?

I have no strong opinion, but - why not, could be useful.  I don't think
this will spare a fix for this issue though.  Because, AFAIR this
registry -> nil thing has several reincarnations in debbugs.

Michael.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-06  1:14                     ` Michael Heerdegen
@ 2021-12-06  1:29                       ` Eric Abrahamsen
  0 siblings, 0 replies; 27+ messages in thread
From: Eric Abrahamsen @ 2021-12-06  1:29 UTC (permalink / raw)
  To: 45330

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> I can switch the test to be something more explicit, but how about --
>> bear with me here -- making `gnus-summary-line-format' a group
>> parameter? It's something I've been thinking about for a while. It would
>> be really nice to be able to give different groups different summary
>> appearances. And it would allow Michael and everyone else to use a
>> separate format string for groups like debbugs or whatnot, that are
>> often opened without Gnus actually being running.
>>
>> WDYT?
>
> I have no strong opinion, but - why not, could be useful.  I don't think
> this will spare a fix for this issue though.  Because, AFAIR this
> registry -> nil thing has several reincarnations in debbugs.

But we could probably provide a default option value for debbugs groups,
so that most users wouldn't even realize that they had a different
format value for those groups.






^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-05 22:18                   ` Eric Abrahamsen
  2021-12-06  1:14                     ` Michael Heerdegen
@ 2021-12-06  5:46                     ` Lars Ingebrigtsen
  2021-12-06 18:06                       ` Eric Abrahamsen
  2021-12-12  2:46                     ` Michael Heerdegen
  2 siblings, 1 reply; 27+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-06  5:46 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: Michael Heerdegen, 45330

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> I can switch the test to be something more explicit, but how about --
> bear with me here -- making `gnus-summary-line-format' a group
> parameter? It's something I've been thinking about for a while. It would
> be really nice to be able to give different groups different summary
> appearances. And it would allow Michael and everyone else to use a
> separate format string for groups like debbugs or whatnot, that are
> often opened without Gnus actually being running.
>
> WDYT?

Uhm...  I think it sounds like a surprising feature.  People set that
variable from hooks, I think, and I think that's fine without getting
group parameters involved.

And I'm rather doubtful that this will fix the problems Michael are
experiencing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-06  5:46                     ` Lars Ingebrigtsen
@ 2021-12-06 18:06                       ` Eric Abrahamsen
  2021-12-06 21:29                         ` Michael Heerdegen
  0 siblings, 1 reply; 27+ messages in thread
From: Eric Abrahamsen @ 2021-12-06 18:06 UTC (permalink / raw)
  To: 45330

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> I can switch the test to be something more explicit, but how about --
>> bear with me here -- making `gnus-summary-line-format' a group
>> parameter? It's something I've been thinking about for a while. It would
>> be really nice to be able to give different groups different summary
>> appearances. And it would allow Michael and everyone else to use a
>> separate format string for groups like debbugs or whatnot, that are
>> often opened without Gnus actually being running.
>>
>> WDYT?
>
> Uhm...  I think it sounds like a surprising feature.  People set that
> variable from hooks, I think, and I think that's fine without getting
> group parameters involved.

Huh, that's odd, and something I hadn't considered. I wonder if the
hooks would end up running after the group parameter setting. If so, I
don't see why current configurations wouldn't simply continue to work as
they have.

> And I'm rather doubtful that this will fix the problems Michael are
> experiencing.

In debbugs groups or what have you, he would use a summary line format
that didn't include registry-specific functions, only data that was
available by default in the summary buffer.






^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-06 18:06                       ` Eric Abrahamsen
@ 2021-12-06 21:29                         ` Michael Heerdegen
  2021-12-06 21:45                           ` Eric Abrahamsen
  0 siblings, 1 reply; 27+ messages in thread
From: Michael Heerdegen @ 2021-12-06 21:29 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: 45330

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> > And I'm rather doubtful that this will fix the problems Michael are
> > experiencing.
>
> In debbugs groups or what have you, he would use a summary line format
> that didn't include registry-specific functions, only data that was
> available by default in the summary buffer.

This happens to me with the default summary line setting:

| Debugger entered--Lisp error: (cl-no-applicable-method registry-lookup nil ("fake+none+nndoc+ephemeral:bug#10000+1"))
|   signal(cl-no-applicable-method (registry-lookup nil ("fake+none+nndoc+ephemeral:bug#10000+1")))
|   cl-no-applicable-method(#s(cl--generic :name registry-lookup :dispatches ((1 #s(cl--generic-generalizer :name cl--generic-t-generalizer :priority 0 :tagcode-function #f(compiled-function (name &rest _) #<bytecode -0x1cba9713a96764e4>) :specializers-function #f(compiled-function (tag &rest _) #<bytecode -0x2b7bed08469105e>))) (0 #s(cl--generic-generalizer :name eieio--generic-generalizer :priority 50 :tagcode-function cl--generic-struct-tag :specializers-function #f(compiled-function (tag &rest _) #<bytecode 0x1cd368c028c72f80>)) #s(cl--generic-generalizer :name cl--generic-t-generalizer :priority 0 :tagcode-function #f(compiled-function (name &rest _) #<bytecode -0x1cba9713a96764e4>) :specializers-function #f(compiled-function (tag &rest _) #<bytecode -0x2b7bed08469105e>)))) :method-table (#s(cl--generic-method :specializers (registry-db t) :qualifiers nil :uses-cnm nil :function #f(compiled-function (db keys) "Search for KEYS in the registry-db DB.\nReturns an alist of the key followed by the entry in a list, not a cons cell." #<bytecode 0x182de2023f4e54c4>))) :options nil) nil ("fake+none+nndoc+ephemeral:bug#10000+1"))
|   apply(cl-no-applicable-method #s(cl--generic :name registry-lookup :dispatches ((1 #s(cl--generic-generalizer :name cl--generic-t-generalizer :priority 0 :tagcode-function #f(compiled-function (name &rest _) #<bytecode -0x1cba9713a96764e4>) :specializers-function #f(compiled-function (tag &rest _) #<bytecode -0x2b7bed08469105e>))) (0 #s(cl--generic-generalizer :name eieio--generic-generalizer :priority 50 :tagcode-function cl--generic-struct-tag :specializers-function #f(compiled-function (tag &rest _) #<bytecode 0x1cd368c028c72f80>)) #s(cl--generic-generalizer :name cl--generic-t-generalizer :priority 0 :tagcode-function #f(compiled-function (name &rest _) #<bytecode -0x1cba9713a96764e4>) :specializers-function #f(compiled-function (tag &rest _) #<bytecode -0x2b7bed08469105e>)))) :method-table (#s(cl--generic-method :specializers (registry-db t) :qualifiers nil :uses-cnm nil :function #f(compiled-function (db keys) "Search for KEYS in the registry-db DB.\nReturns an alist of the key followed by the entry in a list, not a cons cell." #<bytecode 0x182de2023f4e54c4>))) :options nil) (nil ("fake+none+nndoc+ephemeral:bug#10000+1")))
|   #f(compiled-function (&rest args) #<bytecode -0x1412675842721fe9>)(nil ("fake+none+nndoc+ephemeral:bug#10000+1"))
|   apply(#f(compiled-function (&rest args) #<bytecode -0x1412675842721fe9>) nil ("fake+none+nndoc+ephemeral:bug#10000+1"))
|   registry-lookup(nil ("fake+none+nndoc+ephemeral:bug#10000+1"))
|   gnus-registry-get-or-make-entry("fake+none+nndoc+ephemeral:bug#10000+1" nil)
|   gnus-registry-get-id-key("fake+none+nndoc+ephemeral:bug#10000+1" group)
|   gnus-registry-register-message-ids()
|   run-hooks(gnus-summary-prepare-hook)
|   gnus-run-hooks(gnus-summary-prepare-hook)
|   gnus-summary-prepare()
|   gnus-summary-read-group-1("nndoc+ephemeral:bug#10000" t t nil nil nil)
|   gnus-summary-read-group("nndoc+ephemeral:bug#10000" t t nil nil nil nil)
|   gnus-group-read-group(t t "nndoc+ephemeral:bug#10000" nil)
|   gnus-group-read-ephemeral-group("nndoc+ephemeral:bug#10000" (nndoc "/tmp/gnus-temp-group-QMKNt6" (nndoc-article-type mbox)) nil (#<buffer *Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-bug-group((10000) "https://debbugs.gnu.org/cgi/bugreport.cgi?bug=%s;m..." (#<buffer *Bugs*> . #<window-configuration>))
|   gnus-read-ephemeral-emacs-bug-group((10000) (#<buffer *Bugs*> . #<window-configuration>))
|   debbugs-gnu-read-emacs-bug-with-gnus(10000 ((cache_time . 1638825937.3608027) (severity . "minor") (tags "notabug") (found_versions "24.0.91") (found_date) (forwarded) (blocks) (affects) (pending . "done") (found (item (key . "24.0.91") (value))) (fixed) (originator . "nyc4bos@aol.com") (date . 1320812762) (archived . t) (id . 10000) (source . "unknown") (bug_num . 10000) (fixed_date) (location . "archive") (owner) (keywords "notabug") (done . "Lars Magne Ingebrigtsen <larsi@gnus.org>") (summary) (subject . "24.0.91; Gnus gnus-get-function error") (log_modified . 1328358242) (fixed_versions) (unarchived) (package "emacs" "gnus") (mergedwith) (msgid . "<84k479sz16.fsf@aol.com>") (blockedby) (last_modified . 1328358242)) nil)
|   debbugs-gnu-select-report()
|   funcall-interactively(debbugs-gnu-select-report)
|   command-execute(debbugs-gnu-select-report)

Ok, still with the rest of my config.  But it seems, unfortunately, that
it's not that trivial.

Michael.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-06 21:29                         ` Michael Heerdegen
@ 2021-12-06 21:45                           ` Eric Abrahamsen
  2021-12-06 23:01                             ` Michael Heerdegen
  0 siblings, 1 reply; 27+ messages in thread
From: Eric Abrahamsen @ 2021-12-06 21:45 UTC (permalink / raw)
  To: 45330

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> > And I'm rather doubtful that this will fix the problems Michael are
>> > experiencing.
>>
>> In debbugs groups or what have you, he would use a summary line format
>> that didn't include registry-specific functions, only data that was
>> available by default in the summary buffer.
>
> This happens to me with the default summary line setting:

Guess I didn't refresh my memory as fully as I thought! I was still
remembering this as a summary-line-format issue. I've pushed an
additional guard onto `gnus-registry-register-message-ids', I expect
this will fix it.






^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-06 21:45                           ` Eric Abrahamsen
@ 2021-12-06 23:01                             ` Michael Heerdegen
  0 siblings, 0 replies; 27+ messages in thread
From: Michael Heerdegen @ 2021-12-06 23:01 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: 45330

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Guess I didn't refresh my memory as fully as I thought! I was still
> remembering this as a summary-line-format issue. I've pushed an
> additional guard onto `gnus-registry-register-message-ids', I expect
> this will fix it.

Works for me, thanks!

Of course the `gnus-registry-article-marks-to-chars' (and the such)
problem remains.

Wouldn't it make sense to replace the `gnus-registry-enabled' checks
with a function call (gnus-registry-enabled-p) that would not only check
the variable but also the existence of the database, just like in your
installed patch?

TIA,

Michael.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-05 22:18                   ` Eric Abrahamsen
  2021-12-06  1:14                     ` Michael Heerdegen
  2021-12-06  5:46                     ` Lars Ingebrigtsen
@ 2021-12-12  2:46                     ` Michael Heerdegen
  2021-12-23 22:42                       ` Eric Abrahamsen
  2 siblings, 1 reply; 27+ messages in thread
From: Michael Heerdegen @ 2021-12-12  2:46 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: Lars Ingebrigtsen, 45330

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> I can switch the test to be something more explicit, but how about --

Please let's not forget about this again.

What has yet to be done to fix this issue?


Regards,

Michael.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-12  2:46                     ` Michael Heerdegen
@ 2021-12-23 22:42                       ` Eric Abrahamsen
  2021-12-31 18:55                         ` Michael Heerdegen
  0 siblings, 1 reply; 27+ messages in thread
From: Eric Abrahamsen @ 2021-12-23 22:42 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: Lars Ingebrigtsen, 45330

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]


On 12/12/21 03:46 AM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> I can switch the test to be something more explicit, but how about --
>
> Please let's not forget about this again.
>
> What has yet to be done to fix this issue?

Okay, dang it, here we go. Having thought about it, it seems like the
solutions might be simpler than I thought. `gnus-registry-initialize'
looks like this:

(defun gnus-registry-initialize ()
  "Initialize the Gnus registry."
  (interactive)
  (gnus-message 5 "Initializing the registry")
  (gnus-registry-install-hooks) => sets gnus-registry-enabled = t
  (gnus-registry-install-shortcuts)
  (if (gnus-alive-p)
      (gnus-registry-load)
    (add-hook 'gnus-read-newsrc-el-hook #'gnus-registry-load)))

It makes no sense to set `gnus-registry-enabled' to t when we haven't
fully loaded the registry. How about we move
`gnus-registry-install-hooks' and `gnus-registry-install-shortcuts' into
`gnus-registry-load', after the actual loading, a la the attached patch?
Does this solve the problems you're seeing?

Eric


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnusregistryguard.diff --]
[-- Type: text/x-patch, Size: 907 bytes --]

diff --git a/lisp/gnus/gnus-registry.el b/lisp/gnus/gnus-registry.el
index 163d543afd..feb39df925 100644
--- a/lisp/gnus/gnus-registry.el
+++ b/lisp/gnus/gnus-registry.el
@@ -356,7 +356,10 @@ gnus-registry-load
   (interactive)
   (let ((file gnus-registry-cache-file))
     (condition-case nil
-        (gnus-registry-read file)
+        (progn
+          (gnus-registry-read file)
+          (gnus-registry-install-hooks)
+          (gnus-registry-install-shortcuts))
       (file-error
        ;; Fix previous mis-naming of the registry file.
        (let ((old-file-name
@@ -1184,8 +1187,6 @@ gnus-registry-initialize
   "Initialize the Gnus registry."
   (interactive)
   (gnus-message 5 "Initializing the registry")
-  (gnus-registry-install-hooks)
-  (gnus-registry-install-shortcuts)
   (if (gnus-alive-p)
       (gnus-registry-load)
     (add-hook 'gnus-read-newsrc-el-hook #'gnus-registry-load)))

^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-23 22:42                       ` Eric Abrahamsen
@ 2021-12-31 18:55                         ` Michael Heerdegen
  2021-12-31 20:43                           ` Eric Abrahamsen
                                             ` (2 more replies)
  0 siblings, 3 replies; 27+ messages in thread
From: Michael Heerdegen @ 2021-12-31 18:55 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: Lars Ingebrigtsen, 45330

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

>  How about we move `gnus-registry-install-hooks' and
> `gnus-registry-install-shortcuts' into `gnus-registry-load', after the
> actual loading, a la the attached patch?  Does this solve the problems
> you're seeing?

I can't tell whether your solution is appropriate but it indeed seems to
fix my problem!  I'll leave your patch installed and report back should
I see any downside.

Thanks,

Michael.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-31 18:55                         ` Michael Heerdegen
@ 2021-12-31 20:43                           ` Eric Abrahamsen
  2022-01-12 23:06                           ` Eric Abrahamsen
  2022-01-12 23:07                           ` Eric Abrahamsen
  2 siblings, 0 replies; 27+ messages in thread
From: Eric Abrahamsen @ 2021-12-31 20:43 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: Lars Ingebrigtsen, 45330


On 12/31/21 19:55 PM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>>  How about we move `gnus-registry-install-hooks' and
>> `gnus-registry-install-shortcuts' into `gnus-registry-load', after the
>> actual loading, a la the attached patch?  Does this solve the problems
>> you're seeing?
>
> I can't tell whether your solution is appropriate but it indeed seems to
> fix my problem!  I'll leave your patch installed and report back should
> I see any downside.

Great, thanks. I can't imagine any downside, since the code is still
guaranteed to run, and the flag is set only if the initialization is
completed. Even if you weren't seeing erroneous behavior, I would still
think this was an appropriate refactor.

But yes, let's let it sit for a bit and see.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-31 18:55                         ` Michael Heerdegen
  2021-12-31 20:43                           ` Eric Abrahamsen
@ 2022-01-12 23:06                           ` Eric Abrahamsen
  2022-01-12 23:07                           ` Eric Abrahamsen
  2 siblings, 0 replies; 27+ messages in thread
From: Eric Abrahamsen @ 2022-01-12 23:06 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: Lars Ingebrigtsen, 45330-done


On 12/31/21 19:55 PM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>>  How about we move `gnus-registry-install-hooks' and
>> `gnus-registry-install-shortcuts' into `gnus-registry-load', after the
>> actual loading, a la the attached patch?  Does this solve the problems
>> you're seeing?
>
> I can't tell whether your solution is appropriate but it indeed seems to
> fix my problem!  I'll leave your patch installed and report back should
> I see any downside.

I looked back over the code and made some more rearrangements, I hope
really protecting various state variables behind the successful loading
of the registry. Please re-open if I've gotten anything wrong.

Thanks,
Eric





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2021-12-31 18:55                         ` Michael Heerdegen
  2021-12-31 20:43                           ` Eric Abrahamsen
  2022-01-12 23:06                           ` Eric Abrahamsen
@ 2022-01-12 23:07                           ` Eric Abrahamsen
  2022-01-13 12:43                             ` Michael Heerdegen
  2 siblings, 1 reply; 27+ messages in thread
From: Eric Abrahamsen @ 2022-01-12 23:07 UTC (permalink / raw)
  To: Michael Heerdegen; +Cc: Lars Ingebrigtsen, 45330


On 12/31/21 19:55 PM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>>  How about we move `gnus-registry-install-hooks' and
>> `gnus-registry-install-shortcuts' into `gnus-registry-load', after the
>> actual loading, a la the attached patch?  Does this solve the problems
>> you're seeing?
>
> I can't tell whether your solution is appropriate but it indeed seems to
> fix my problem!  I'll leave your patch installed and report back should
> I see any downside.

In hindsight, there didn't need to be a `gnus-registry-enabled' boolean,
we should have just been checking the existence of `gnus-registry-db',
but I think it's too late to remove that boolean now.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2022-01-12 23:07                           ` Eric Abrahamsen
@ 2022-01-13 12:43                             ` Michael Heerdegen
  2022-01-13 19:42                               ` Eric Abrahamsen
  0 siblings, 1 reply; 27+ messages in thread
From: Michael Heerdegen @ 2022-01-13 12:43 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: Lars Ingebrigtsen, 45330

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> In hindsight, there didn't need to be a `gnus-registry-enabled' boolean,
> we should have just been checking the existence of `gnus-registry-db',
> but I think it's too late to remove that boolean now.

It's not used so often.  And it makes things unnecessarily mixed-up.  My
gut feeling says you should give it a try.

Anyway, thanks for fixing this bug.

Michael.





^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2022-01-13 12:43                             ` Michael Heerdegen
@ 2022-01-13 19:42                               ` Eric Abrahamsen
  2022-01-13 21:54                                 ` Michael Heerdegen
  0 siblings, 1 reply; 27+ messages in thread
From: Eric Abrahamsen @ 2022-01-13 19:42 UTC (permalink / raw)
  To: 45330

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> In hindsight, there didn't need to be a `gnus-registry-enabled' boolean,
>> we should have just been checking the existence of `gnus-registry-db',
>> but I think it's too late to remove that boolean now.
>
> It's not used so often.  And it makes things unnecessarily mixed-up.  My
> gut feeling says you should give it a try.

Hmm, I suppose an obsolete variable alias wouldn't hurt, I doubt
anyone's trying to do anything with `gnus-registry-enabled' besides
checking it for truthiness.






^ permalink raw reply	[flat|nested] 27+ messages in thread

* bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus
  2022-01-13 19:42                               ` Eric Abrahamsen
@ 2022-01-13 21:54                                 ` Michael Heerdegen
  0 siblings, 0 replies; 27+ messages in thread
From: Michael Heerdegen @ 2022-01-13 21:54 UTC (permalink / raw)
  To: Eric Abrahamsen; +Cc: 45330

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Hmm, I suppose an obsolete variable alias wouldn't hurt, I doubt
> anyone's trying to do anything with `gnus-registry-enabled' besides
> checking it for truthiness.

Yes - preferably with a mention of what to use instead (which will
anyway be more likely what the user really wants, I guess).

Regards,

Michael.





^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2022-01-13 21:54 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-20  4:53 bug#45330: 28.0.50; debbugs-gnu: Can't select reports before having started Gnus Michael Heerdegen
2020-12-21  4:56 ` Lars Ingebrigtsen
2020-12-21  7:10   ` Michael Heerdegen
2020-12-21 16:12     ` Eric Abrahamsen
2020-12-22 16:43       ` Eric Abrahamsen
2020-12-23  5:23         ` Michael Heerdegen
2020-12-23 18:08           ` Eric Abrahamsen
2021-12-04 23:18             ` Lars Ingebrigtsen
2021-12-05  0:23               ` Michael Heerdegen
2021-12-05 19:48                 ` Lars Ingebrigtsen
2021-12-05 22:18                   ` Eric Abrahamsen
2021-12-06  1:14                     ` Michael Heerdegen
2021-12-06  1:29                       ` Eric Abrahamsen
2021-12-06  5:46                     ` Lars Ingebrigtsen
2021-12-06 18:06                       ` Eric Abrahamsen
2021-12-06 21:29                         ` Michael Heerdegen
2021-12-06 21:45                           ` Eric Abrahamsen
2021-12-06 23:01                             ` Michael Heerdegen
2021-12-12  2:46                     ` Michael Heerdegen
2021-12-23 22:42                       ` Eric Abrahamsen
2021-12-31 18:55                         ` Michael Heerdegen
2021-12-31 20:43                           ` Eric Abrahamsen
2022-01-12 23:06                           ` Eric Abrahamsen
2022-01-12 23:07                           ` Eric Abrahamsen
2022-01-13 12:43                             ` Michael Heerdegen
2022-01-13 19:42                               ` Eric Abrahamsen
2022-01-13 21:54                                 ` Michael Heerdegen

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).