From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#53636: 29.0.50; face-remapping broken on master Date: Tue, 01 Feb 2022 20:38:53 +0100 Message-ID: <87fsp2v0ky.fsf@gnus.org> References: <87o83tib13.fsf@gnu.org> <871r0p9l4f.fsf@gnus.org> <83ee4p9izg.fsf@gnu.org> <87mtjd8485.fsf@gnus.org> <83a6fd9glm.fsf@gnu.org> <835yq19dk1.fsf@gnu.org> <87czk97yt6.fsf@gnus.org> <8335l49jwu.fsf@gnu.org> <835ypz8zbm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38481"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 53636@debbugs.gnu.org, tsdh@gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 02 02:32:59 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nF4W3-0009qq-R4 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 02 Feb 2022 02:32:59 +0100 Original-Received: from localhost ([::1]:43908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nF4W2-00028V-IL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Feb 2022 20:32:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEz0V-0007W0-27 for bug-gnu-emacs@gnu.org; Tue, 01 Feb 2022 14:40:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51275) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEz0U-0003UH-Lm for bug-gnu-emacs@gnu.org; Tue, 01 Feb 2022 14:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEz0U-0000lF-JR for bug-gnu-emacs@gnu.org; Tue, 01 Feb 2022 14:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Feb 2022 19:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53636 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 53636-submit@debbugs.gnu.org id=B53636.16437443512827 (code B ref 53636); Tue, 01 Feb 2022 19:40:02 +0000 Original-Received: (at 53636) by debbugs.gnu.org; 1 Feb 2022 19:39:11 +0000 Original-Received: from localhost ([127.0.0.1]:44173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEyze-0000jW-VY for submit@debbugs.gnu.org; Tue, 01 Feb 2022 14:39:11 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:60580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEyzc-0000jH-Jr for 53636@debbugs.gnu.org; Tue, 01 Feb 2022 14:39:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VrTe0T4AqnFvGedvD6ZZ0NU+SizflzbncZB1WTYC0nE=; b=R5PRXLwJilX+Ur6Z1zIR27XMb5 TZv1gLEsvhwWjtG4HAzHSY7cRVj65sa8hBNQFFL04/c0DaNYJjwPUs3AqhkOVE1rSVaAfCdbvu/cE h3+7shJ2+mrfvg48a3+7r0SxevHsbiSQi1YdEeK00Js7xOFCGxRCE2sr1PbCzXgs7ZI4=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEyzT-0002xA-05; Tue, 01 Feb 2022 20:39:01 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEVbXWaKeHWllp3J srCmjHmEe4y4sctpaYrKusrYzdv///+k58upAAAAAWJLR0QKaND0VgAAAAd0SU1FB+YCARMgHSZX M2gAAAF6SURBVDjLlZLPasMwDMaVwch1CX2AxknWew2lu60jL9BA2b2DLMe2UHzfIDjXDob9tpPs JHXzZ2Mfton1k/Q5IPAYYzEnJbPMfiyTbBOC18aRMBPGzGwDcM/wGq/eOGfLNs4SC1zFhhDwnKA5 iYxUEMGN4I6NCYH/K1iwEy4TCnHPog6cxJyd5gtk3jwMgyhAkP7LI5oCzwTS3OmW2JNAutuJvFeQ REcAAiJ1UZYl64oq8qHHUwXqsegkrWpZ6Qq01pWsdV8foKUu2ltVFGVV1BYoxoqylF0q9dKKKsaF gGOGVn2XC+iY00NuokrWF1B8JQdE1miOU2Veb1LJXNGNXoXDtJatFC1tQGx73TSTcg/fOC9F2aW3 2mOr1sTR57rx6CO+SuGrHXa3gC8BAeND/QHYJIhHwcsE2PvC6ixed1Z5EDwALFrQ6bwNAhzq9x44 CHE0AMRA2ymws8BvOhwck+gKhPD9KzAVhwaB6IFrjWsyDo4NGLyM/vwHukllMgpRZT0AAAAldEVY dGRhdGU6Y3JlYXRlADIwMjItMDItMDFUMTk6MzI6MjkrMDA6MDCoICceAAAAJXRFWHRkYXRlOm1v ZGlmeQAyMDIyLTAyLTAxVDE5OjMyOjI5KzAwOjAw2X2fogAAAABJRU5ErkJggg== X-Now-Playing: Nosdam's _Rayon_: "From Nowhere To North" In-Reply-To: <835ypz8zbm.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 31 Jan 2022 21:44:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225767 Archived-At: Eli Zaretskii writes: > So when we effectively renamed mode-line to mode-line-active, we broke > compatibility, since in some situations, such as the one described > here, what was previously done with the mode-line face must now be > done with mode-line-active face. But this is a bug, I think? You can see the same effect in Emacs 28 if you do: (face-remap-add-relative 'mode-line 'link-visited) This won't have the expected effect on faces that inherit from mode-line (line mode-line-inactive/header-line) in the current frame, but if you open a new frame, it'll have an effect there. > Is that analysis correct, or am I missing something? > > If so, my suggestion is: > > . rename mode-line-active back to mode-line > . introduce a new face, mode-line-base, say, from which mode-line > will inherit, like mode-line-active now inherits from mode-line The new mode-line-active face was supposed to fix the decoupling of mode-line and header-line. In Emacs 28, there's no way to change the look of the (active) mode line without also changing the header-line face. Introducing a new face that mode-line inherits from doesn't solve this issue. > Would that be an acceptable solution? (I considered alternatives, but > they are all uglier. Basically, the "basic faces" aren't supposed to > inherit from other faces, for face remapping to work as expected.) Making face remapping work reliably for these faces would be better, but I haven't looked at the code. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no