unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: vmalloc@gmail.com, Glenn Morris <rgm@gnu.org>, 16577@debbugs.gnu.org
Subject: bug#16577: Add regexp-based version of completion-ignored-extensions
Date: Mon, 21 Feb 2022 15:00:50 +0100	[thread overview]
Message-ID: <87fsocl3ot.fsf@gnus.org> (raw)
In-Reply-To: <jwvley5shsv.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 20 Feb 2022 10:06:58 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> BTW, maybe we can merge the two propositions:
> Allow the use in `completion-ignored-files` of entries of the form
> "/<RE>" where <RE> will be matched against the nondirectory part of the
> file name.

I haven't looked at the various code snippets that use the resulting
regexps, but I imagine that some are matching on the full file name and
some aren't?

But do you mean that completion-ignored-files should be on the form
(... "/CV[A-S]/" ...)?

> We'd probably want to make this match anchored, since that's
> what the "/" suggests.  It means that instead of "/.git/" we'd add
> "/\\.git/" or "/\\.git/?\\'".

If we want this to work against both full file names and nondirectory
parts, it'd be...  er...

"\\(?:\\`\\|/\\)\\.git/?\\'"

I guess. 

Which nobody is going to get right, so I wonder whether it should just
be a list of strings instead of a list of regexps.

> This should make the change much less invasive, with most existing uses
> of `completion-ignored-files` unaffected.

I guess I should start poking at this and see how it works out in
practice.  Skimming the places where it's used, I think it's about a
dozen locations that needs adjusting.  But I may be overestimating.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  parent reply	other threads:[~2022-02-21 14:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-28 11:15 bug#16577: 24.3; Ido omitting directories with similar names to other directories Rotem Yaari
2014-01-28 16:00 ` Eli Zaretskii
2014-01-28 17:18   ` Glenn Morris
2014-01-28 17:24     ` Eli Zaretskii
2014-01-28 17:35       ` Rotem Yaari
2014-01-28 17:39         ` Eli Zaretskii
2014-01-28 18:59       ` Glenn Morris
2014-01-28 19:17         ` Eli Zaretskii
2014-01-28 20:15           ` Glenn Morris
2014-01-28 21:39             ` Stefan Monnier
2014-01-29  2:43             ` Glenn Morris
2022-02-20 13:26               ` bug#16577: Add regexp-based version of completion-ignored-extensions Lars Ingebrigtsen
2022-02-20 15:06                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-20 22:05                   ` bug#16577: [External] : " Drew Adams
2022-02-21 14:00                   ` Lars Ingebrigtsen [this message]
2022-02-21 16:06                     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-21 16:20                       ` Lars Ingebrigtsen
2022-02-21 16:23                         ` Lars Ingebrigtsen
2022-02-21 16:57                           ` Eli Zaretskii
2022-02-21 17:01                             ` Lars Ingebrigtsen
2022-02-21 17:13                               ` Eli Zaretskii
2022-02-21 17:36                                 ` Lars Ingebrigtsen
2022-02-21 17:01                         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-21 17:33                           ` bug#16577: [External] : " Drew Adams
2022-02-22 13:17                           ` Lars Ingebrigtsen
2022-02-22 13:56                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-23 12:05                               ` Lars Ingebrigtsen
2022-02-20 21:48                 ` bug#16577: [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsocl3ot.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=16577@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=rgm@gnu.org \
    --cc=vmalloc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).