From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pierre =?UTF-8?Q?T=C3=A9choueyres?= Newsgroups: gmane.emacs.bugs Subject: bug#54598: 27.2; Bad interraction between modus-theme and hs-minor-mode Date: Thu, 31 Mar 2022 21:24:16 +0200 Message-ID: <87fsmxc3tv.fsf@killashandra.ballybran.fr> References: <87sfr3cp35.fsf@killashandra.ballybran.fr> <87r16kaowt.fsf@gnus.org> <87o81ocv2t.fsf@killashandra.ballybran.fr> <87ee2i735s.fsf@gnus.org> <87ee2iw9p3.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2630"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.12; emacs 27.2.50 Cc: 54598@debbugs.gnu.org, Lars Ingebrigtsen To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 31 21:37:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1na0ba-0000Om-GE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Mar 2022 21:37:14 +0200 Original-Received: from localhost ([::1]:52842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1na0bZ-0006jp-0x for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Mar 2022 15:37:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34286) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1na0bO-0006jL-Qc for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 15:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1na0bO-0001bK-6x for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 15:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1na0bN-0007f1-PI for bug-gnu-emacs@gnu.org; Thu, 31 Mar 2022 15:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Pierre =?UTF-8?Q?T=C3=A9choueyres?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Mar 2022 19:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54598 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 54598-submit@debbugs.gnu.org id=B54598.164875536329357 (code B ref 54598); Thu, 31 Mar 2022 19:37:01 +0000 Original-Received: (at 54598) by debbugs.gnu.org; 31 Mar 2022 19:36:03 +0000 Original-Received: from localhost ([127.0.0.1]:39846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1na0aQ-0007dR-Lz for submit@debbugs.gnu.org; Thu, 31 Mar 2022 15:36:02 -0400 Original-Received: from smtp6-g21.free.fr ([212.27.42.6]:61572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1na0aP-0007d1-3g for 54598@debbugs.gnu.org; Thu, 31 Mar 2022 15:36:02 -0400 Original-Received: from killashandra.ballybran.fr.free.fr (unknown [IPv6:2a01:e0a:1e2:f8b0:6e3d:5f8:9612:9a5e]) by smtp6-g21.free.fr (Postfix) with ESMTPS id 5D5177802C5; Thu, 31 Mar 2022 21:35:57 +0200 (CEST) In-reply-to: <87ee2iw9p3.fsf@protesilaos.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229177 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hello Protesilaos, Le jeudi 31 mars 2022 =C3=A0 16:08, Protesilaos Stavrou=20 a =C3=A9crit : > ... > Pierre, your suggestion to filter the custom-enabled-themes is=20 > better > than what we have. Do you want to send it to me as a patch? What dou you think of the attached one ? > > All the best, Same here :-) > Prot Apart from that, do you know why the vertical line doesn't look=20 the same on Windows ? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Filter-modus-themes-on-modus-themes-current-theme.patch Content-Description: Filter modus themes on modus-themes--current-theme >From 2e9802aceb9e2e77dd91f54a7727177038a35aec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20T=C3=A9choueyres?= Date: Thu, 31 Mar 2022 21:16:42 +0200 Subject: [PATCH] Filter modus themes on modus-themes--current-theme When custom-enabled-themes contains many themes, we're only interrested by the first modus-* one. This avoid a crash when modus-themes--palette is called which complains that the first theme returned by modus-themes--current-theme isn't either modus-operandi or modus-vivendi (pcase use). --- modus-themes.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/modus-themes.el b/modus-themes.el index 3f0e098..3a9a26e 100644 --- a/modus-themes.el +++ b/modus-themes.el @@ -3191,8 +3191,9 @@ Those are stored in `modus-themes-faces' and (custom-theme-set-variables ',name ,@modus-themes-custom-variables)))) (defun modus-themes--current-theme () - "Return current theme." - (car custom-enabled-themes)) + "Return current modus theme." + (car (seq-filter (lambda (arg) (string-match-p "^modus" (symbol-name arg))) + custom-enabled-themes))) ;; Helper functions that are meant to ease the implementation of the ;; above customization variables. -- 2.35.1 --=-=-=--