From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#55149: 29.0.50; Commit f30625943e broke magit/with-editor Date: Thu, 28 Apr 2022 09:31:22 +0200 Message-ID: <87fslxhdea.fsf@fastmail.fm> References: <87wnfa3cop.fsf@fastmail.fm> <87czh2qpkc.fsf@gmail.com> <86bkwly9qy.fsf@mail.linkov.net> <87k0b9he68.fsf@fastmail.fm> <86pml1wu33.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31562"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.7.13; emacs 29.0.50 Cc: 55149@debbugs.gnu.org, monnier@iro.umontreal.ca, iarchivedmywholelife@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 09:47:06 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njyrg-0007vR-9D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 09:47:06 +0200 Original-Received: from localhost ([::1]:40074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njyrf-0002sf-4D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 03:47:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njye6-0003vq-Uj for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51276) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njye6-0002Pt-Ko for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njye6-0007G0-He for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 03:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 07:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55149 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors" , No Wayman , 55149@debbugs.gnu.org, Stefan Monnier Original-Received: via spool by 55149-submit@debbugs.gnu.org id=B55149.165113112927823 (code B ref 55149); Thu, 28 Apr 2022 07:33:02 +0000 Original-Received: (at 55149) by debbugs.gnu.org; 28 Apr 2022 07:32:09 +0000 Original-Received: from localhost ([127.0.0.1]:45170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njydE-0007Ee-IS for submit@debbugs.gnu.org; Thu, 28 Apr 2022 03:32:08 -0400 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:48255) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njydC-0007E3-NZ for 55149@debbugs.gnu.org; Thu, 28 Apr 2022 03:32:07 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 3FA86320077A; Thu, 28 Apr 2022 03:32:00 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 28 Apr 2022 03:32:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1651131119; x=1651217519; bh=ifO1pMC/W9 6+9zZ9IoR94AFgS/a1NtJMwMj7FZjgvMM=; b=oq35jVkSv9RJjWA7Gjp9DsXuld DAyYmI1cVgX/R3KUo6HfTNUMw3/CeojuE5TJ/U+LeVW+ktB5tsPY7fdgUVIfPYa3 KP/IPSX45ZhLhWegMMX2Zsu9RtjnHJgs9Y+nSSHP6Uj4qZx+g4AX/qTqO4TA2N0R sHH058YJgUA3nBDJUA2G6sabzCHSuF28gTJ5jYiJGIVxDIhFwFtVZq88NlDHlzh2 6Qd1+YF5A6pFR61kxmjSW+jymNdRwVMdy0DXp8YWICsiT/b2jlhtC9xKRLK7fMYC XLpTLl/+TVpUBiGPVi2EJRP5otxxGXgh8JoC2BOrPDjuvAhnUWaFUCwJJj5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1651131119; x= 1651217519; bh=ifO1pMC/W96+9zZ9IoR94AFgS/a1NtJMwMj7FZjgvMM=; b=G IQHkdaohZeBc612Ouqt/NyzQ5c6/3vxOQKL1WiZ6kocl/BYHZaXFD8U2J6b9xVAb WM1cIJrzaOo5FdcFEBTkqWIMoN1FPiCQCqIXznGc1bgJuQ+XxWItpdJG45CKlPJW 2xaw09mKTVMnfCgxWlPXyl+HHkznjlS3bGMl87iaLM1NiK3LijFv57iRCGx0c0zJ +sRAG1BWEEIUa6xUPttjuXBxiQ1ulk74Tj2nM9MdZl+tBijNwhgml5QJPP+HCRuX 4xEDw8kxlf7NonK5x2rN72J94Ez5BlLSGZQGNTkJthP7+ramq21HYTSfw2WPZClw 7dXU5nl9nwFuvb05RdudA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeigdduvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhhohhrnhesfhgrshhtmhgrihhlrdhfmheqnecuggftrfgrth htvghrnhepgeffiefhjeekueeiueehteetgfehtefgffegfeduheejiefhgfehteektefh vdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepth hhohhrnhesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 28 Apr 2022 03:31:58 -0400 (EDT) In-reply-to: <86pml1wu33.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230843 Archived-At: Juri Linkov writes: >>> The regression is that the return value of :after now overrides >>> the return value of the original function. >> >> Oh, indeed. But isn't that exactly as documented for add-function? >> >> :after (lambda (&rest r) (apply OLDFUN r) (apply FUNCTION r)) > > Indeed, it seems documentation differed from the actual implementation. > >> Of course, we'd rather want >> >> :after (lambda (&rest r) (prog1 (apply OLDFUN r) (apply FUNCTION r))) > > Yep, this looks like what it's natural to expect from such advice type. > Or maybe a new type could be added to modify the return value? There is :filter-return to do exactly that. Bye, Tassilo