From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45764: icomplete in buffer completion does not work for completion-at-point Date: Wed, 08 Jun 2022 13:50:38 +0200 Message-ID: <87fskfbchd.fsf@gnus.org> References: <140804236.117906.1610282126510@office.mailbox.org> <87y1y8hagm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29936"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: simon254@mailbox.org, 45764@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 08 13:58:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyuKK-0007Wn-4w for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jun 2022 13:58:20 +0200 Original-Received: from localhost ([::1]:53662 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyuKI-0003tq-TS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jun 2022 07:58:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyuDK-0006gQ-1O for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2022 07:51:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48743) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyuDG-0006Yx-Am for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2022 07:51:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nyuDG-0003BF-9v for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2022 07:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jun 2022 11:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45764-submit@debbugs.gnu.org id=B45764.165468905012199 (code B ref 45764); Wed, 08 Jun 2022 11:51:02 +0000 Original-Received: (at 45764) by debbugs.gnu.org; 8 Jun 2022 11:50:50 +0000 Original-Received: from localhost ([127.0.0.1]:42639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyuD4-0003Ah-4b for submit@debbugs.gnu.org; Wed, 08 Jun 2022 07:50:50 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyuD3-0003AW-2M for 45764@debbugs.gnu.org; Wed, 08 Jun 2022 07:50:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5CWbTaWvyYvEakMRmo/akjpDsqNFBEzGQ1SzpOc6w8w=; b=BJHOMx5llR7C23QZ+qTMtgvSda dCIdCthT1DiNepv8yoDOVG4NEAQEATep57MaMo1GobTLEIPF6dVYNS/wPPzA5psvZn1kczat1c9tw re8iPQOZBh5PWoEGJrUhMeJo2zGESsyMy9Gm7WM2JZYLhVL65NjvAZCBHoo8I5UGb70Y=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyuCt-0005tc-FE; Wed, 08 Jun 2022 13:50:42 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 07 Jun 2022 10:43:08 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233964 Archived-At: Stefan Monnier writes: >> `C-j' is bound to `icomplete-force-complete-and-exit', and it calls >> `minibuffer-force-complete-and-exit' unconditionally, which deletes the >> buffer contents. > > There are 2 problems, both of which stem from the fact that the code has > not been adjusted to the case where it's working in a normal buffer > rather than in the minibuffer: > - it calls `minibuffer-exit` which is wrong for in-buffer completion > (it should probably exit `completion-in-region-mode` instead). > - it assumes the area of completion is the whole buffer (it should > probably use `icomplete--field-end/beg`). Poking at this a bit more, the test case also bugs out in (icomplete--field-string), because there are no fields in the buffer. (I think. I'm apparently getting different results when edebugging and not...) >> I can't get icomplete-in-buffer to work in either *shell* or in other >> modes -- has this feature gotten much testing/use? > > `icomplete-in-buffer` needs more love, indeed. > [ BTW, I see its docstring says that it doesn't affect > `dabbrev-completion` but that's not true any more. ] Ah; I've now adjusted the doc string. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no