From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Kevin Brubeck Unhammer Newsgroups: gmane.emacs.bugs Subject: bug#56113: [PATCH] * lisp/mail/mail-extr.el: only set fundamental-mode if unset Date: Mon, 20 Jun 2022 22:04:24 +0200 Message-ID: <87fsjzdruf.fsf@fastmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40385"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) To: 56113@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 20 22:10:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o3Nja-000AJw-Jh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jun 2022 22:10:55 +0200 Original-Received: from localhost ([::1]:50026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o3NjZ-0004fo-3Z for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jun 2022 16:10:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3Ndu-0000eX-NM for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 16:05:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36374) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o3Ndu-0005Ep-Ei for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 16:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o3Ndu-0005En-7O for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 16:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kevin Brubeck Unhammer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jun 2022 20:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56113 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.165575548120098 (code B ref -1); Mon, 20 Jun 2022 20:05:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Jun 2022 20:04:41 +0000 Original-Received: from localhost ([127.0.0.1]:58504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3NdZ-0005E6-3h for submit@debbugs.gnu.org; Mon, 20 Jun 2022 16:04:41 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3NdU-0005Dw-KA for submit@debbugs.gnu.org; Mon, 20 Jun 2022 16:04:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3NdS-0000Oh-BV for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 16:04:36 -0400 Original-Received: from forward2-smtp.messagingengine.com ([66.111.4.226]:60787) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o3NdQ-0005B7-DF for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2022 16:04:34 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailforward.nyi.internal (Postfix) with ESMTP id EC1DD19412B5; Mon, 20 Jun 2022 16:04:28 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 20 Jun 2022 16:04:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1655755468; x= 1655841868; bh=VoGTmGQgWUSSKo+xVzbrSjolNzDzV0HOmlmJeIcbhZ8=; b=S 1l0v59+AXg8J2ZCCKjFjkVzXOZj5sFShTg1ttNlCz9sKDl76S9YuOuaR1xFthnvf T6D5TN06PFp53Y/p2a+YWiUJ0DSlMyAEjQHKiY6aMv3fRJRHFcYmfdbnus8MU6mF rwQr4pJl/SAPVx4tM9LJu440aGwNbEufimawxpJCfC4DsrOr676EoOe/Eop6oIR4 Rde9OwUy7ytemMNnY/YvbGHj9URX5pMX3UtRuGngc9CUrcN9y9/wX6lWphwSYqy5 UURahQgTSp/kCZ8zlYCSRMXpGQj4RVxsJ2ab+P1CF+O4Zweo4So1yisq4SqXEbeP y21oV1Km9ceeKqc6mo+5w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudefuddgudeghecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgfgggtsehgtderre dtreejnecuhfhrohhmpefmvghvihhnuceurhhusggvtghkucgfnhhhrghmmhgvrhcuoehu nhhhrghmmhgvrhesfhhsfhgvrdhorhhgqeenucggtffrrghtthgvrhhnpeeghfekgeekfe etieeileekheffheevgeetudeuueelheefhfffgffhlefhuefgteenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehunhhhrghmmhgvrhesfhhsfh gvrdhorhhg X-ME-Proxy: Feedback-ID: i26a44175:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 20 Jun 2022 16:04:27 -0400 (EDT) Received-SPF: softfail client-ip=66.111.4.226; envelope-from=unhammer@fsfe.org; helo=forward2-smtp.messagingengine.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234917 Archived-At: --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, I noticed that opening groups with lots of unread messages in Gnus was quite slow; profile shows that because I (bbdb-insinuate-gnus), it runs mail-extract-address-components on them all and that function does (with-current-buffer (get-buffer-create =E2=80=A6) (fundamental-mode) =E2=80=A6) for every mail. Apparently (fundamental-mode) is slow since I use evil-mode =E2=80=93 so evil-mode could be faster, but also it seems unneces= sary to call fundamental-mode on fresh buffers? In any case, the attached patch makes opening summaries 10x faster for people like me on gnus+bbdb+evil. best regards, Kevin Brubeck Unhammer (I have signed the copyright papers, still in the same job.) --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-mail-mail-extr.el-only-set-fundamental-mode-if-.patch Content-Transfer-Encoding: quoted-printable From=2021186344e31e469c9e64b1b89977a20ed9605914 Mon Sep 17 00:00:00 2001 From: Kevin Brubeck Unhammer Date: Mon, 20 Jun 2022 21:48:21 +0200 Subject: [PATCH] * lisp/mail/mail-extr.el: only set fundamental-mode if uns= et (mail-extract-address-components): Avoid unnecessarily running mode hooks meant for interactive use =2D-- lisp/mail/mail-extr.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/mail/mail-extr.el b/lisp/mail/mail-extr.el index 50ba04ccc1..8713075db0 100644 =2D-- a/lisp/mail/mail-extr.el +++ b/lisp/mail/mail-extr.el @@ -716,7 +716,8 @@ mail-extract-address-components value-list) =20 (with-current-buffer (get-buffer-create extraction-buffer) =2D (fundamental-mode) + (unless (eq major-mode 'fundamental-mode) + (fundamental-mode)) (buffer-disable-undo extraction-buffer) (set-syntax-table mail-extr-address-syntax-table) (widen) @@ -738,7 +739,7 @@ mail-extract-address-components (set-text-properties (point-min) (point-max) nil) =20 (with-current-buffer (get-buffer-create canonicalization-buffer) =2D (fundamental-mode) + (unless (eq major-mode 'fundamental-mode) (fundamental-mode)) (buffer-disable-undo canonicalization-buffer) (setq case-fold-search nil)) =20 =2D-=20 2.25.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEq9A0PxCu5rIo7lbX/DwefQCTFmcFAmKw0sgACgkQ/DwefQCT FmcW0RAApGCUr51sZdTUrazEV4yRAWJFNlwGXjLLIyR2I+ln1zfvyASokG5fX5Zu OdI+yrYFlypr5MnnSS54cIqL5wBoRdEG5t+UDsGSptYFGRKADETDEaPg8eFpGTeo /p6+x/jAVYgeF4w8ccjuoJZvqWyXd68AlQV00+yWkQ6z76fXuWmg5w2d6W99NH50 6W4Ry3Gic+lUgGeKdnMHxXoa/i/YqrIMDp4P2BDV203nQXtpM7Rs0QawNwu7C/Zw zax1G0axqmh0ga4gl0BPikD8s4LUEnsma3FQHtOKtzqhHlN3Q86jxuj6Zy/BaqSY zoaeBkIK1AltbMt1wOaqC2Gti7UUjXQGdkeVzQwZ17ehBRW9y3cgC9J8pLIHPmIM SxG8meHK/SQ4Zpray3IDH1Bd59ykx3nnxhFUTG1k97LeIAvfp7jycpzf2md9rh+f aJME8HpZjGPjM2/Y2CFa17oV88MpZFxQnCJMUqLlx/2qKKbyf+hzfcPboRTWqi4q Fz7NBSUBmnEe3mvrkZq231un9V+0HIsI/RLaUgdTtiUCuUeydRcQEU1UEYw8SJJ5 EnRLwVgB4NDExuDRqybNiYo6u3tLBAEu6rxgGbprwyHzVT5EdHftgH6wKWbLyjK8 hTPLvGX3Wo7nqt6uVC8rs13uz1aml/hFNbURwm67/ispcaDHB1g= =jXTb -----END PGP SIGNATURE----- --==-=-=--