From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#41423: bug#47389: 27.1.91; completion issue on eshell Date: Mon, 27 Jun 2022 10:29:34 +0200 Message-ID: <87fsjq7bm9.fsf_-_@gnus.org> References: <86k116inmr.fsf@sacsa.i-did-not-set--mail-host-address--so-tickle-me> <86tv0aecgn.fsf@gmail.com> <87r1v4z3f1.fsf_-_@gmx.de> <83bld37sly.fsf@gnu.org> <86czxjg4xs.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35484"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , =?UTF-8?Q?andr=C3=A9s_?= =?UTF-8?Q?ram=C3=ADrez?= , 47389@debbugs.gnu.org, 41423@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 27 10:30:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5k8p-00096H-Vd for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Jun 2022 10:30:43 +0200 Original-Received: from localhost ([::1]:36604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o5k8o-0004TL-EV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Jun 2022 04:30:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43012) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o5k8J-0004Rw-Ub for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 04:30:14 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55892) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o5k8A-0000mc-QN for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 04:30:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o5k8A-0001xC-MA for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2022 04:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Jun 2022 08:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41423 X-GNU-PR-Package: emacs Original-Received: via spool by 41423-submit@debbugs.gnu.org id=B41423.16563185897455 (code B ref 41423); Mon, 27 Jun 2022 08:30:02 +0000 Original-Received: (at 41423) by debbugs.gnu.org; 27 Jun 2022 08:29:49 +0000 Original-Received: from localhost ([127.0.0.1]:49784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5k7x-0001w5-4x for submit@debbugs.gnu.org; Mon, 27 Jun 2022 04:29:49 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o5k7v-0001vk-2l; Mon, 27 Jun 2022 04:29:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9LnkZVdQjpmA1KaGcvwkXQW1RTI6wa6E7/MVp3JG0UM=; b=kZZcMD2pKxHb6wcFif3gor8cDk tYHEsONMEIzc3nWKH3oo2sKSeADuyXSv2FQ8lQFNha182EQXXqndKmrXj93LWONQMbNX/RvAqjNCP k5E8IG8OVC9FjLut11ytWA6/BX3sR+5ieql6VDg9/1ZCli80StUAof0XSevBfa8TDIH4=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o5k7k-0003bE-UU; Mon, 27 Jun 2022 10:29:39 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 01 Feb 2021 11:13:14 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235422 Archived-At: Stefan Monnier writes: >> If You code the 'minimalist version of the patch'. I could try it on this >> version. > > See patch below. You don't need to rebuild Emacs either: just recompile > that one file and you're done. [...] > diff --git a/lisp/eshell/em-cmpl.el b/lisp/eshell/em-cmpl.el > index faf749d836..744be525ec 100644 > --- a/lisp/eshell/em-cmpl.el > +++ b/lisp/eshell/em-cmpl.el > @@ -399,16 +399,21 @@ > > (defun eshell-complete-commands-list () > "Generate list of applicable, visible commands." > - (let ((filename (pcomplete-arg)) glob-name) > + ;; Building the commands list can take quite a while, especially over = Tramp > + ;; (bug#41423), so do it lazily. Re-skimming this bug report quickly, it seems like this patch was applied at the time, but Andr=C3=A9s had some additional issues, and a proposed addition patch? Andr=C3=A9s, did this patch fix the issue, and if not, do you have an additional patch here? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no