unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 48334@debbugs.gnu.org, m.a.nikulin@gmail.com
Subject: bug#48334: No <title> elements in HTML manual pages
Date: Sun, 03 Jul 2022 14:16:27 +0200	[thread overview]
Message-ID: <87fsjibdd0.fsf@gnus.org> (raw)
In-Reply-To: <83ilofbg7x.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Jul 2022 20:02:26 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> > Emacs manual is generated by texi2html, texinfo and e.g. Org mode by
>> >     makeinfo --html ...
>> > In the latter case pages have <title> element, in the former they do
>> > not (at least without some tuning).

[...]

> We are.  See the instructions in admin/make-tarball.txt and the
> scripts admin/make-manuals and admin/upload-manuals.
>
> I don't remember if texi2any produces <title>, but the above scripts
> modify the HTML produced by texi2any, so what we eventually have is
> the result of those scripts.

Hm...  it looks like the manuals are produced with "makeinfo --html",
though -- I can't see any usage of texi2html or texi2any there, but I
may be missing something.

> We could decide dropping admin/make-manuals, or at least the parts
> that modify the produced HTML, but presumably those parts were written
> for a reason.  Unfortunately, I see no detailed documentation of the
> reasons for those changes, so it's hard to decide whether any of them
> are still valid, what with Texinfo's progress since the time those
> changes were coded.

Ah, it's this code:

(defun manual-html-fix-headers ()
  "Fix up HTML headers for the Emacs manual in the current buffer."
  (let ((texi5 (search-forward "<!DOCTYPE" nil t))
	opoint)

[...]

    (search-forward "<meta")
    (setq opoint (match-beginning 0))
    (unless texi5
      (search-forward "<!--")
      (goto-char (match-beginning 0))
      (delete-region opoint (point))
      (search-forward "<meta http-equiv=\"Content-Style")
      (setq opoint (match-beginning 0)))
    (search-forward "</title>\n")
    (delete-region opoint (point))

So we delete the <title> that makeinfo --html has created.  Perhaps
that's just a bug?  I see that you adjusted this code in May...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-07-03 12:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10 14:48 bug#48334: No <title> elements in HTML manual pages Maxim Nikulin
2021-10-05 14:14 ` Maxim Nikulin
2022-07-02 16:19   ` Lars Ingebrigtsen
2022-07-02 17:02     ` Eli Zaretskii
2022-07-03 12:16       ` Lars Ingebrigtsen [this message]
2022-07-03 13:13         ` Eli Zaretskii
2022-07-03 14:48           ` Max Nikulin
2022-07-04 10:42           ` Lars Ingebrigtsen
2022-07-04 11:36             ` Eli Zaretskii
2022-07-05 11:09               ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsjibdd0.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=48334@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=m.a.nikulin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).