bug#56698: 28.1; wdired-change-to-wdired-mode fails unless all inserted subdirs are unhidden

bug#56698: 28.1; wdired-change-to-wdired-mode fails unless all inserted subdirs are unhidden

[Peter Mao]

[-- Attachment #1.1: Type: text/plain, Size: 3364 bytes --]

If any of the subdirs (or even the top dir) is hidden in a dired buffer,
`wdired-change-to-wdired-mode' fails.  I believe this is happening at
`dired--unhide' called from `dired-remember-marks'.

Running 'C-x C-q' , with a hidden subdir results in a "Buffer is read-only"
message.  'C-x C-q' works properly after manually unhiding the subdirs.

Recipe is attached, since my mail client seems to strip out control
characters.

----

In GNU Emacs 28.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
cairo version 1.16.0)
 of 2022-04-07 built on chupa
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Ubuntu 20.04.4 LTS

Configured using:
 'configure --with-native-compilation'

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LCMS2
LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG
SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3
ZLIB

Important settings:
  value of $LC_COLLATE: C
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util rmail
rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cache json map text-property-search time-date
subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs
cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo move-toolbar gtk x-toolkit x multi-tty make-network-process
native-compile emacs)

Memory information:
((conses 16 67170 7974)
 (symbols 48 6619 0)
 (strings 32 19557 1244)
 (string-bytes 1 667156)
 (vectors 16 14049)
 (vector-slots 8 296562 13398)
 (floats 8 22 31)
 (intervals 56 195 0)
 (buffers 992 10))

[-- Attachment #1.2: Type: text/html, Size: 3789 bytes --]

[-- Attachment #2: wdired-bug --]
[-- Type: application/octet-stream, Size: 70 bytes --]

bug#56698: 28.1; wdired-change-to-wdired-mode fails unless all inserted subdirs are unhidden

[Lars Ingebrigtsen]

Peter Mao <peter.mao@gmail.com> writes:

> If any of the subdirs (or even the top dir) is hidden in a dired buffer,
> `wdired-change-to-wdired-mode' fails.  I believe this is happening at `dired--unhide'
> called from `dired-remember-marks'.
>
> Running 'C-x C-q' , with a hidden subdir results in a "Buffer is read-only" message. 
> 'C-x C-q' works properly after manually unhiding the subdirs.
>
> Recipe is attached, since my mail client seems to strip out control characters.

I'm not sure what the attachment is supposed to describe, but do you
have a complete, step-by-step recipe to reproduce the problem, starting
from "emacs -Q"?

bug#56698: 28.1; wdired-change-to-wdired-mode fails unless all inserted subdirs are unhidden

[Peter Mao]

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]

Hi Lars,

Sorry, the attachment is the "dribble-file" from an "emacs -Q" session.
Since it's mentioned in the Emacs manual (section 52.4), I thought it would
be useful!  Here's the same recipe in straight text:
1. emacs -Q
2. "C-x d ~/"  open home directory
3. navigate to any subdirectory (eg, ".emacs.d")
4. "i" insert the subdirectory at point
5. "$" hide the subdir
6. "C-x C-q" attempt to put dired buffer into writable mode.  This will
fail with message "Buffer is read-only"
7. "$" unhide the subdir
8. "C-x C-q" new attempt to put dired buffer into writable mode.  This
works as expected
9. "C-c C-k" exit writable dired mode.

Peter


On Fri, Jul 22, 2022 at 10:56 PM Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Peter Mao <peter.mao@gmail.com> writes:
>
> > If any of the subdirs (or even the top dir) is hidden in a dired buffer,
> > `wdired-change-to-wdired-mode' fails.  I believe this is happening at
> `dired--unhide'
> > called from `dired-remember-marks'.
> >
> > Running 'C-x C-q' , with a hidden subdir results in a "Buffer is
> read-only" message.
> > 'C-x C-q' works properly after manually unhiding the subdirs.
> >
> > Recipe is attached, since my mail client seems to strip out control
> characters.
>
> I'm not sure what the attachment is supposed to describe, but do you
> have a complete, step-by-step recipe to reproduce the problem, starting
> from "emacs -Q"?
>
>
>

[-- Attachment #2: Type: text/html, Size: 2146 bytes --]

bug#56698: 28.1; wdired-change-to-wdired-mode fails unless all inserted subdirs are unhidden

[Lars Ingebrigtsen]

Peter Mao <peter.mao@gmail.com> writes:

> Sorry, the attachment is the "dribble-file" from an "emacs -Q" session.  Since it's
> mentioned in the Emacs manual (section 52.4), I thought it would be
> useful!

Oh, right.  I've never used that stuff myself.  😀

> Here's
> the same recipe in straight text:
> 1. emacs -Q
> 2. "C-x d ~/"  open home directory
> 3. navigate to any subdirectory (eg, ".emacs.d")
> 4. "i" insert the subdirectory at point
> 5. "$" hide the subdir
> 6. "C-x C-q" attempt to put dired buffer into writable mode.  This will fail with
> message "Buffer is read-only"

Thanks!  With that I was able to reproduce the problem, and I've now
fixed it in Emacs 29.