unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Oleksandr Gavenko <gavenkoa@gmail.com>
Cc: 28434@debbugs.gnu.org
Subject: bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling.
Date: Tue, 23 Aug 2022 11:36:15 +0200	[thread overview]
Message-ID: <87fshnuws0.fsf@gnus.org> (raw)
In-Reply-To: <86lglj6bkl.fsf@gavenkoa.example.com> (Oleksandr Gavenko's message of "Tue, 12 Sep 2017 21:01:14 +0300")

Oleksandr Gavenko <gavenkoa@gmail.com> writes:

> It happens with a lot of tools (diff/hg/git). If file doesn't end on new line
> diff file has:
>
>   \ No newline at end of file
>
> C-c C-c (diff-goto-source) on that hunk says:
>
>   Hunk text not found
>
> C-c C-a (diff-apply-hunk) says:
>
>   diff-apply-hunk: Can’t find the text to patch

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

This has been fixed in Emacs 28.1, as far as I can tell.





      parent reply	other threads:[~2022-08-23  9:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-12 18:01 bug#28434: 25.2; Final "\ No newline at end of file" breaks Emacs patch handling Oleksandr Gavenko
2019-06-24 16:13 ` Lars Ingebrigtsen
2019-06-24 22:50   ` Noam Postavsky
2019-06-24 23:09     ` Lars Ingebrigtsen
2019-06-24 23:58       ` Noam Postavsky
2019-06-25 11:16         ` Lars Ingebrigtsen
2019-06-25  2:41       ` Eli Zaretskii
2022-08-23  9:36 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fshnuws0.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=28434@debbugs.gnu.org \
    --cc=gavenkoa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).