From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Thu, 08 Sep 2022 13:46:15 +0200 Message-ID: <87fsh25bso.fsf@gnus.org> References: <875yhzmz25.fsf@posteo.net> <875yhzmj50.fsf@gnus.org> <875yhzl3a1.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17172"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57639@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 08 13:53:03 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWG5f-0004FH-8D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 13:53:03 +0200 Original-Received: from localhost ([::1]:44560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWG5c-0005rb-B2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 07:53:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWFzr-00007k-Lj for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 07:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWFzq-00088J-6L for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 07:47:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWFzq-0005NZ-0h for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 07:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Sep 2022 11:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166263758720632 (code B ref 57639); Thu, 08 Sep 2022 11:47:01 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 8 Sep 2022 11:46:27 +0000 Original-Received: from localhost ([127.0.0.1]:57393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWFzH-0005Mi-84 for submit@debbugs.gnu.org; Thu, 08 Sep 2022 07:46:27 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:53380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWFzE-0005MR-TK for 57639@debbugs.gnu.org; Thu, 08 Sep 2022 07:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4iRkLWcUfaYv+cuQ4Nq+LDShkUuU8figk7ySd3Tb1So=; b=SZWz5rCOoOJYvDG2Fco4Qgq8dO +MqAZB7oCgbJCdrN8FHf5x7je5IUQZCoB+/1SCJaHpvc/e/60K19MnfRafI3KsOq7zyQ2Cm6g4y02 bz3fArusDIkyw291BTPllnPe58O9a4y04zttpIMUSo7Y17wUTUB3vNpgInG9Qt3uXN8k=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWFz6-0001lv-3t; Thu, 08 Sep 2022 13:46:18 +0200 In-Reply-To: <875yhzl3a1.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 07 Sep 2022 13:31:18 +0000") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAALVBMVEUuIwtVOyFpZlQG BgJIMgZWTRBnVx1xbyt5gzmJczGFek2fklG6spOsl0T///9GbpeoAAAAAWJLR0QOb70wTwAAAAd0 SU1FB+YJCAsjLERJ7MIAAAGVSURBVDjL1dO9TsMwEAdwoxbmFgl2eAKkvgBIyQMg1V4QA0POCkwM sRv1AcLHxEDLqXSBibIhgWhNJD7WsCKhknfBLthJQWxd+E/R/XJ2Yp0JIXN1m0X3VK+Rxh+ZGazN BshPWCOEVD2dEpia5+KAkKl6AVU6yW+YBwAuwaT5A6RN4GuoWFgA4YB6vl8CLpMviOhUB5etgwNT x4hSv1mxvznPpUxaiGg6KLu+WF0pNhcyNiAgoO3R4MbtcSyT3qFS6kjdertTkNwfDTQM1ZDuZdmz Bb1vS/Y0XCkVlAFAQ4zHajhOo60HB0xQJvlZt6dG6vXO36nXvr+KyUA3hdDWi6VvbJ/UGhYmJ8i4 HEh83x4/PDmgTNdhWba7aX6eZQU0eRQusRBjzPOPAmjkC9E/3Qyxg6mRRwsB7Uo8qQNy1C1jC1V9 QF3ADoQI8TRQ1jEAKOK0DPqsk7j/DhCLEPt5L3v5Hrt14gd6nU4oIBz289yCGSyPVr9mZ2MZ+PWl A10lRYr7YQZR6/qkXGmUwb058zv47+ATvbpQrpuNH0IAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjIt MDktMDhUMTE6MzU6NDQrMDA6MDDAyxK/AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA5LTA4VDEx OjM1OjQ0KzAwOjAwsZaqAwAAAABJRU5ErkJggg== X-Now-Playing: David Grubbs & Nikus Veliotis's _The Harmless Dust_: "The Harmless Dust, Pt. Two" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241855 Archived-At: Philip Kaludercic writes: > Do you think it would be better to less general, and instead of talking > about "dual" themes always assume we want to toggle between a light and > a dark variant? If not, this sounds like a separate feature (say that > could be handled by a different property `theme-variant'). Well, if we had marking for "theme with variant", then we'd know which themes are "the same", but with a variant. So your command could instead be `theme-choose-variant', but since there's only two variants here, it'd toggle. If there were more, the user would be prompted for which variant to use, which would cover gruvbox, which Stefan mentioned. And in addition, this tagging could be used for automatic dark/light OS changes, so it's at least three birds with one stone.