unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jose A Ortega Ruiz <jao@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 58103@debbugs.gnu.org
Subject: bug#58103: [PATCH] docview: imenu access to table of contents
Date: Tue, 27 Sep 2022 17:18:41 +0100	[thread overview]
Message-ID: <87fsgczt7i.fsf@mail.jao.io> (raw)
In-Reply-To: <87k05p3uf9.fsf@gnus.org>

On Tue, Sep 27 2022, Lars Ingebrigtsen wrote:

> Jose A Ortega Ruiz <jao@gnu.org> writes:
>
>> The patch below provides a quite simple implemetation of an imenu for
>> doc-view, using mutool.  That means of course that is limited to systems
>> where it's installed, and doesn't try to be too smart, but it's been
>> working quite well for me. 
>
> Looks good to me; pushed to Emacs 29.

excellent, thanks a lot!

> (Using `let-alist' is pretty unusual, but I guess it's nice that
> somebody does -- there only seems to be two other usages in-tree in
> Emacs since this was added in 2014.  🙃)

i find it handy when the let body is small, otherwise it can make things
harder to read.  but i'm not specially attached to it if we prefer more
idiomatic ways.

cheers,
jao





  reply	other threads:[~2022-09-27 16:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27  5:41 bug#58103: [PATCH] docview: imenu access to table of contents Jose A Ortega Ruiz
2022-09-27 11:53 ` Lars Ingebrigtsen
2022-09-27 16:18   ` Jose A Ortega Ruiz [this message]
2022-09-28 22:00 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-28 22:53   ` Jose A Ortega Ruiz
2022-09-29 12:48     ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsgczt7i.fsf@mail.jao.io \
    --to=jao@gnu.org \
    --cc=58103@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).