From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Sun, 09 Oct 2022 21:02:59 +0000 Message-ID: <87fsfw1zi4.fsf@posteo.net> References: <875yhzmz25.fsf@posteo.net> <87h715dnut.fsf@posteo.net> <87edw955ls.fsf@gnus.org> <8735coewsk.fsf@posteo.net> <871qs7ztgq.fsf@gnus.org> <87o7vbg56k.fsf@posteo.net> <874jx3ye41.fsf@gnus.org> <87bkrbfz8l.fsf@posteo.net> <871qs5lpo2.fsf@posteo.net> <87mtatagzv.fsf@gnus.org> <87edw5n2zm.fsf@posteo.net> <87o7v97zy2.fsf@gnus.org> <87bkr9newj.fsf@posteo.net> <871qs57yai.fsf@gnus.org> <87y1udlzlt.fsf@posteo.net> <87o7v953uf.fsf@gnus.org> <87tu50nca7.fsf@posteo.net> <87a6652lyb.fsf@posteo.net> <875ygtqdho.fsf@gnus.org> <87wn99114w.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29293"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Fabrice Niessen , Lars Ingebrigtsen , Eli Zaretskii , Protesilaos Stavrou , 57639@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 09 23:04:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ohdT1-0007KU-HX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Oct 2022 23:04:11 +0200 Original-Received: from localhost ([::1]:39722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohdT0-00018L-C8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Oct 2022 17:04:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohdSs-00017x-HW for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 17:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohdSs-0006lI-9k for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 17:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohdSr-0006Iw-RE for bug-gnu-emacs@gnu.org; Sun, 09 Oct 2022 17:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Oct 2022 21:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166534939824185 (code B ref 57639); Sun, 09 Oct 2022 21:04:01 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 9 Oct 2022 21:03:18 +0000 Original-Received: from localhost ([127.0.0.1]:45024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohdS7-0006Hy-F3 for submit@debbugs.gnu.org; Sun, 09 Oct 2022 17:03:18 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:39257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohdS2-0006Hh-8H for 57639@debbugs.gnu.org; Sun, 09 Oct 2022 17:03:14 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 71E47240026 for <57639@debbugs.gnu.org>; Sun, 9 Oct 2022 23:03:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665349384; bh=pgmFiGa5cevQUhnEe14y9QWaTx4PvbKuzuG77iy2tJg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=of13Qdfp1M+dtXT5CxEi7jLCyP0aNiKhO0tyuFjSQImHx6CpwzZ3JIuj1RvzIpJAk 8i1FitfxcUatQusMd0JEoo79c6epEDcbH7FLtkuUBdQEoyjr5ucaFkD/ELGoTEAqj6 sSXGOdJsvPKguWyNBFzlMgrSi3k4yT+Sf+Lmr1PCWA4E1kqPkJIRbYXsBjr9q2CPpV WOQkcR+J34OzeTcj0nTkCNOJnAOT+MpFTVLQfNem1BsYLBCdcrTkdmfE/ITGk+oYAJ 4s34Fx5O8MWC1n6HINVUBMzjRAn9gUN/8hzses4ULmG5i3h8vnSiJJkSY7DGdDt/nr meehctiO6BTYQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Mlvdc300Kz6tmF; Sun, 9 Oct 2022 23:03:00 +0200 (CEST) In-Reply-To: (Stefan Kangas's message of "Sun, 9 Oct 2022 22:32:49 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244975 Archived-At: Stefan Kangas writes: > Philip Kaludercic writes: > >> --8<---------------cut here---------------start------------->8--- >> ;;;###autoload >> (when (and (boundp 'custom-theme-load-path) >> load-file-name) >> ;; Add theme folder to `custom-theme-load-path' when installing over MELPA. >> (add-to-list 'custom-theme-load-path >> (file-name-as-directory (file-name-directory load-file-name)))) >> --8<---------------cut here---------------end--------------->8--- >> >> from leuven-theme.el to be removed. > > Why would the above be necessary for leuven-theme.el in particular? > > I've never had a problem loading themes installed from MELPA, so I don't > understand why it should need any special treatment. It probably isn't necessary at all and it could be removed. My guess is that it used to be necessary for [some reason] but [something] changed at [some point], but the snippet was kept anyway. I have CC'ed the maintainer Fabrice to find out if my guess is accurate.