From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, 58518@debbugs.gnu.org, miha@kamnitnik.top
Subject: bug#58518: 29.0.50; [PATCH] Turning off compilation-minor-mode removes fontification of other modes
Date: Sun, 16 Oct 2022 10:24:51 +0200 [thread overview]
Message-ID: <87fsfo2n1o.fsf@gnus.org> (raw)
In-Reply-To: <jwvh705kvyt.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 15 Oct 2022 10:45:28 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I can't remember anyone measuring the performance impact, but it does
> come at a cost since every time we call `lookup_char_property` it takes
> significantly more work.
>
> This is called at every text-property (or overlay) boundary in things
> like `next-single-property-change` and similar operations used by the
> redisplay.
>
> The "more work" is the `assq` itself whose time is proportional to the
> length of this alist, plus a `plist-get` per alias listed, whenever
> the `assq` finds a match (i.e. whenever we're looking for a property
> which has aliases).
But this would be for the *compilation* buffer only, so perhaps that's
fine...
> FWIW, in the past I suggested maybe we should introduce a notion of
> "property planes". So `compilation` could use one property plane,
> `font-lock` could use another and they could just blindly remove all the
> properties in their plane without affecting others.
Yes, it's implementing planes, only manually. Having real planes would
be great.
> BTW, another option is to use overlays rather than
> text-properties :-)
I'd rather not -- things are confusing enough in this area already.
prev parent reply other threads:[~2022-10-16 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 15:15 bug#58518: 29.0.50; [PATCH] Turning off compilation-minor-mode removes fontification of other modes miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-15 10:25 ` Lars Ingebrigtsen
2022-10-15 14:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-16 8:24 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsfo2n1o.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=58518@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=miha@kamnitnik.top \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).