From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Feng Shu Newsgroups: gmane.emacs.bugs Subject: bug#59404: 29.0.50; Init-debug error when package-vc-install package and run older emacs Date: Wed, 23 Nov 2022 20:25:11 +0800 Message-ID: <87fse926zc.fsf@163.com> References: <877czqtaki.fsf@163.com> <871qpxn11d.fsf@posteo.net> <875yf7rg34.fsf@163.com> <87o7sy4qth.fsf@posteo.net> <87tu2qtsae.fsf@163.com> <87h6yq3ygb.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32107"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59404@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 13:26:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxopW-00083i-KJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 13:26:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxopK-00087W-5P; Wed, 23 Nov 2022 07:26:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxopG-000875-Ml for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:26:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxopG-0001y5-E4 for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxopG-0001Vp-AQ for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 07:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Feng Shu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59404 X-GNU-PR-Package: emacs Original-Received: via spool by 59404-submit@debbugs.gnu.org id=B59404.16692063235759 (code B ref 59404); Wed, 23 Nov 2022 12:26:02 +0000 Original-Received: (at 59404) by debbugs.gnu.org; 23 Nov 2022 12:25:23 +0000 Original-Received: from localhost ([127.0.0.1]:54052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxooc-0001Up-OM for submit@debbugs.gnu.org; Wed, 23 Nov 2022 07:25:23 -0500 Original-Received: from m12.mail.163.com ([123.126.96.234]:52644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxooZ-0001UZ-1Z for 59404@debbugs.gnu.org; Wed, 23 Nov 2022 07:25:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=iTlLQ /+JsNnjpOD+3/6QoI1RfhzKNE8WcX6i786MEco=; b=Vh3D5scYUOH3k+bT6BbgP 9cP8CkWg+QkSt6VlSJdPuCYpAFHVJDJN2s7Hhp3FNOdIBx+cTzcdTQugSXGuz9// SPW3RR+aG0BKobSC1uxCOSgYQ6qPbYeizbhhwKLtiJ0EJCB0um8SiwYCUW0XkfFg Lq3/hPzs7yO3HnXcZCUm/s= Original-Received: from Guix (unknown [49.88.144.183]) by smtp18 (Coremail) with SMTP id JNxpCgCX80AnEX5jIKk+AQ--.1314S2; Wed, 23 Nov 2022 20:25:11 +0800 (CST) In-Reply-To: <87h6yq3ygb.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 23 Nov 2022 07:46:28 +0000") X-CM-TRANSID: JNxpCgCX80AnEX5jIKk+AQ--.1314S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxAw47KF4UurW7Kw4DCr4UJwb_yoW5Cw4Upr yfZa4kGa1F9348Jr92gr40kryFgF48JryUZrnrJ3yay3Wqgr1jgryxZF4akF47Jr17Jw45 u3Wv93y3W3yFkaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zR5kuxUUUUU= X-Originating-IP: [49.88.144.183] X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/xtbB3wHC1GBHM5tY2gAAsF X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248731 Archived-At: Philip Kaludercic writes: > Feng Shu writes: > >> Philip Kaludercic writes: >> >>> Feng Shu writes: >>> >>>> Philip Kaludercic writes: >>>> >>>>> Feng Shu writes: >>>>> >>>>>> When I package-vc-install corfu-terminal and run an older version >>>>>> emacs >>>>> >>>>> Does the following fix the issue for you: >>>> >>>> I have tested and find that when I install this patch and reinstall >>>> popon and corfu-terminal, >>>> >>>> 1. *Packages* buffer do not show packages installed by >>>> package-vc-install >>>> 2. package-update, package-delete do not show packages installed by >>>> package-vc-install. >>>> 3. restart emacs has not effect. >>> >>> Did you re-install the packages? >> >> Yes, when I apply this patch, packages before installed are dispear, so >> I install them with package-vc-install, after install, packages do not >> show like above. > > Sorry about that, I misread your message. There was a minor typo/thinko > in the last patch: I have testd, it work and older emacs do not show error. > > From 46d2f3542100efd2019f5f4703e21f5d45baed71 Mon Sep 17 00:00:00 2001 > From: Philip Kaludercic > Date: Sun, 20 Nov 2022 15:36:24 +0100 > Subject: [PATCH 1/2] Don't break when loading VC packages on older Emacs > versions > > * lisp/emacs-lisp/package-vc.el > (package-vc--generate-description-file): Append a :kind property > instead of modifying the version number. > * lisp/emacs-lisp/package.el (package-desc): Remove special handling > for "vc annotated" versions. (bug#59404) > --- > lisp/emacs-lisp/package-vc.el | 3 ++- > lisp/emacs-lisp/package.el | 4 +--- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index a999596785..bf1ea2bdf4 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -334,7 +334,7 @@ package-vc--generate-description-file > (nconc > (list 'define-package > (symbol-name name) > - (cons 'vc (package-vc--version pkg-desc)) > + (package-vc--version pkg-desc) > (package-desc-summary pkg-desc) > (let ((requires (package-desc-reqs pkg-desc))) > (list 'quote > @@ -344,6 +344,7 @@ package-vc--generate-description-file > (list (car elt) > (package-version-join (cadr elt)))) > requires)))) > + (list :kind 'vc) > (package--alist-to-plist-args > (package-desc-extras pkg-desc)))) > "\n") > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index c1545a2870..e11c5d693e 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -483,9 +483,7 @@ package-vc-p > (if (eq 'quote (car requirements)) > (nth 1 requirements) > requirements))) > - (kind (if (eq (car-safe version-string) 'vc) > - 'vc > - (plist-get rest-plist :kind))) > + (kind (plist-get rest-plist :kind)) > (archive (plist-get rest-plist :archive)) > (extras (let (alist) > (while rest-plist --