From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Antero Mejr via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62426: [PATCH] eshell: Add 'rgrep' builtin. Date: Tue, 11 Apr 2023 02:12:52 +0000 Message-ID: <87fs97np3v.fsf@mailbox.org> References: <87jzz5eucl.fsf@mailbox.org> <87355syce8.fsf@athena.silentflame.com> Reply-To: Antero Mejr Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34861"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62426@debbugs.gnu.org, Sean Whitton To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 11 04:14:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pm3Wc-0008uS-KO for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Apr 2023 04:14:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pm3WF-0007j6-QS; Mon, 10 Apr 2023 22:14:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pm3WE-0007io-88 for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 22:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pm3WD-0000dA-W3 for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 22:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pm3WD-0005qf-R1 for bug-gnu-emacs@gnu.org; Mon, 10 Apr 2023 22:14:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Antero Mejr Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Apr 2023 02:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62426-submit@debbugs.gnu.org id=B62426.168117918722392 (code B ref 62426); Tue, 11 Apr 2023 02:14:01 +0000 Original-Received: (at 62426) by debbugs.gnu.org; 11 Apr 2023 02:13:07 +0000 Original-Received: from localhost ([127.0.0.1]:36217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm3VL-0005p6-3Y for submit@debbugs.gnu.org; Mon, 10 Apr 2023 22:13:07 -0400 Original-Received: from mout-p-103.mailbox.org ([80.241.56.161]:55474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pm3VH-0005oZ-DP for 62426@debbugs.gnu.org; Mon, 10 Apr 2023 22:13:05 -0400 Original-Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4PwTrl2cdSz9sky; Tue, 11 Apr 2023 04:12:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1681179175; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V4nNInJNXcw6q4jV44I9QZpVk7OBclBGCngUdwWHiKc=; b=piFTtxR6mbv3w1unBAve7YVlUfv/iTuB75bGd9OouXJ5PxXB5gCRcGkQexsQ8OEDI6u+O+ wt/zKIPGtrhlD+H+XbpzLW89+SiDT/0ClJOk/eDR3VDFKsQK42fTJqNaAatb62ZubixSnc WRU39NXUKLlkDTChn7ytCOh1qSAZsvhlY5GZGcnMtAUvPfCRnEl8Ymb8HD51boPufXBHR6 6+vY+9hLCbiuvdq1P73cLdee70oRqIXFGa/NgVJFfEm4YWtGR7P69CBda5ZdsWxbez9zh0 Khl2l3yOc2MzO6DLToHEv4K9RvNj9smxZGFJfqe247B9jTTNi+RgiYApCXM3sA== In-Reply-To: (Jim Porter's message of "Sat, 8 Apr 2023 18:55:06 -0700") X-MBO-RS-META: c3nqr6iogd4ged5ign9zutwa89p4cm51 X-MBO-RS-ID: 36ea6620d49605fd300 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259616 Archived-At: Jim Porter writes: > I just see one issue with the patch: the NEWS entry and docstring are a bit > misleading. I know these are just copying from the existing Eshell functions, > but this isn't really accurate: "Use Emacs grep facility instead of calling > external rgrep." It *always* calls the external rgrep; it's just that sometimes > the output goes into a compilation buffer. I don't think that's always the case. In the "eshell-grep" function it checks if external grep is available, and if not then it uses a slow elisp-only implementation. Then it checks to see if the output is being redirected, and so on. IMO that entire process constitutes the "emacs grep facility" as described in the docstring. > Instead, how about something like this? "Call the external rgrep program, > opening its output in a compilation buffer when possible." (Plus similar changes > to the other existing functions.) I think that makes it clearer what's actually > happening. I think the "Emacs grep facility" description is technically accurate and concise enough for the eshell/*grep stub functions. > Anyway, sorry for the back and forth on this. This is a part of Eshell that I > haven't looked at in much detail before, and I wanted to get a better sense of > what our options were here. Thanks for the review and discussion.