From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#65030: 30.0.50; Check keyword args of make-process Date: Tue, 08 Aug 2023 19:07:32 +0530 Message-ID: <87fs4t64f7.fsf@gmail.com> References: <83a5v5u9nf.fsf@gnu.org> <83o7jkrcme.fsf@gnu.org> <87sf8tapbf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27635"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , Eli Zaretskii , 65030@debbugs.gnu.org, eller.helmut@gmail.com, Stefan Monnier To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 08 15:38:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qTMum-0006uW-8P for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Aug 2023 15:38:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTMub-00078A-QY; Tue, 08 Aug 2023 09:38:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTMuV-00077e-Vv for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 09:38:08 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTMuQ-0004Kx-Lj for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 09:38:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qTMuQ-000378-AS for bug-gnu-emacs@gnu.org; Tue, 08 Aug 2023 09:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Aug 2023 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65030 X-GNU-PR-Package: emacs Original-Received: via spool by 65030-submit@debbugs.gnu.org id=B65030.169150186411943 (code B ref 65030); Tue, 08 Aug 2023 13:38:02 +0000 Original-Received: (at 65030) by debbugs.gnu.org; 8 Aug 2023 13:37:44 +0000 Original-Received: from localhost ([127.0.0.1]:35679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTMu7-00036Z-S3 for submit@debbugs.gnu.org; Tue, 08 Aug 2023 09:37:44 -0400 Original-Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:50465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTMu5-00036M-O8 for 65030@debbugs.gnu.org; Tue, 08 Aug 2023 09:37:42 -0400 Original-Received: by mail-pf1-x444.google.com with SMTP id d2e1a72fcca58-686b9920362so3801595b3a.1 for <65030@debbugs.gnu.org>; Tue, 08 Aug 2023 06:37:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691501856; x=1692106656; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=x6Bn//2LWVazPuCYukSHvj8q48rSJK22FenLymSpDtc=; b=nkBxRNjUXcWjB+LF2poJ/XL9eWHdCJDDCAud0LtsyijFcbwXzfW7wistK/hn9pc3P7 ZCt/okH/i/FLxLX0GF6SaqWIaJW4PWUXMnE6WhCmNc1YtgndqQqFoqYWJO1Fe3KVmX1o VyMT+rUHg+Pi1W3BFg03Hw1m2uk3GwLSOiPhdaSR+T2BtaNDK5+3ZTXr+4x2T85Jo+ct FoCaM1fcron1E9SeSKi3fY//Wdnk/x1w5WruYkjEyXp8GnUpNN9cBp8O+cK9zfJr1rku Q0bBprDc3VSygopzacF3Asc31eCgxyXBknrki+I4N5TzNZAVxlqwZwliOQECDKPmd3Gw OmTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691501856; x=1692106656; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=x6Bn//2LWVazPuCYukSHvj8q48rSJK22FenLymSpDtc=; b=JzcU40hboJ2xnTh6MoRjzg2bIOEx9TVsepJxZHBJfUKySOf1T+WGR9lp682/jR2DQk AVPnxNVQPoSXxzjLTSPiWNaToYUORtc9BF1wDtAX21xBQLBeMN53UULUVcGxo0wr/twv XW71IjZ8V4m4DgX2njyG4SktwpKib+8DarcHkAvj8WTxfsgPp+KP4xw4MvbE8MsyxKob ThiFtaa/ZYf1QVtzEq/zGi+LMbs0WDd930YQdFZ0nB9eh99VEgKYzTYg/G6orIhJ9Q1e 7z9VyDgZRttMQoqZpMjYIZ+zLF+XvkB01s4WN5fZaIlk4wrQOUNkPHAvwxtVMkSOvVnv zjwg== X-Gm-Message-State: AOJu0YxGTrCIJiyFuZB3s4WQI11mI9g2t4qSpk4Vi5NBNcewYuu6W/W4 1V9BdURBaV/XqaHQjZlNvJo= X-Google-Smtp-Source: AGHT+IGiaK4CI9pYl2yuQSzAZS8yvac9uRhSVUkZv95nNnHVrYva6FsF3gxB5fx96rLGVgxj9dQ8tw== X-Received: by 2002:a05:6a00:1798:b0:666:b254:1c9c with SMTP id s24-20020a056a00179800b00666b2541c9cmr12053055pfg.27.1691501855890; Tue, 08 Aug 2023 06:37:35 -0700 (PDT) Original-Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id p25-20020a62ab19000000b006878cc942f1sm8083663pff.54.2023.08.08.06.37.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 06:37:35 -0700 (PDT) In-Reply-To: <87sf8tapbf.fsf@gmail.com> (Robert Pluim's message of "Tue, 08 Aug 2023 10:52:36 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266959 Archived-At: [Tuesday August 08, 2023] Robert Pluim wrote: >>>>>> On Sun, 6 Aug 2023 10:49:59 +0200, Mattias Engdeg=C3=A5rd said: > > Mattias> 6 aug. 2023 kl. 06.58 skrev Eli Zaretskii : > >> Any specific comments to the proposed patch? Or do you think it is > >> good to go? > > Mattias> Good to go as far as I'm concerned. It will be genuinely use= ful, and I > Mattias> see no serious problems with the implementation. > > Mattias> It can be extended but that would not prevent it from being = committed > Mattias> as-is. For example, something that detects omitted values in= the > Mattias> middle, not just the end, of the argument list. (The feasibi= lity of > Mattias> this depends on the likelihood of argument values being keyw= ords > Mattias> themselves.) > > I don=CA=BCt think any of the `make-process' keywords accept keywords as > values, but missing values tends to cause catastrophic failure, so I > don=CA=BCt think it=CA=BCs that common a mistake. Can you not pass keywords as non-nil values to :query and :stop? Something like, (make-process :name NAME :command COMMAND :query :yes)