From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65380: [PATCH] Add command to copy contents in a diff-mode buffer Date: Tue, 22 Aug 2023 11:06:28 +0000 Message-ID: <87fs4bgwuj.fsf@posteo.net> References: <87wmxrwe6h.fsf@posteo.net> <83o7j3z4wm.fsf@gnu.org> <87pm3jwboc.fsf@posteo.net> <83lee7z3xs.fsf@gnu.org> <87jztrvxx2.fsf@posteo.net> <83r0nyyhlz.fsf@gnu.org> <86o7j2qgmc.fsf@mail.linkov.net> <83cyzhwpcj.fsf@gnu.org> <87a5ultvuy.fsf@posteo.net> <83a5ulwos6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25733"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65380@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 22 13:07:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qYPEA-0006Wv-EN for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Aug 2023 13:07:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qYPDx-000368-QF; Tue, 22 Aug 2023 07:07:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qYPDv-00035m-LN for bug-gnu-emacs@gnu.org; Tue, 22 Aug 2023 07:06:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qYPDv-0004uY-D3 for bug-gnu-emacs@gnu.org; Tue, 22 Aug 2023 07:06:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qYPDy-0000rE-3s for bug-gnu-emacs@gnu.org; Tue, 22 Aug 2023 07:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Aug 2023 11:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65380 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65380-submit@debbugs.gnu.org id=B65380.16927024023264 (code B ref 65380); Tue, 22 Aug 2023 11:07:02 +0000 Original-Received: (at 65380) by debbugs.gnu.org; 22 Aug 2023 11:06:42 +0000 Original-Received: from localhost ([127.0.0.1]:58633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYPDe-0000qa-4Y for submit@debbugs.gnu.org; Tue, 22 Aug 2023 07:06:42 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:48529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qYPDc-0000qM-4Z for 65380@debbugs.gnu.org; Tue, 22 Aug 2023 07:06:40 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id F3403240104 for <65380@debbugs.gnu.org>; Tue, 22 Aug 2023 13:06:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692702391; bh=MeEnFLTfqSoCW0DEheD1iylT/8+W0VtIxsiKTA6OSNw=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=BhjDr/itImgnwv9BHPV2WxchEsep8oh1/bLTeHQHNZCMGCzDlWIJV0HtPw1VEZ/So e1VNzDFHzPnyKwGgY8pZbQ1AUhARtWb7jiJ79EKOoSyUpzQd8jkkNDCzKcA2BCfxLi xkoXN/lNDgPHzTz50jCwW5fP4I7e92/+bpxQQ8mfq9KmdFJXw493idLj7ehONNeE0e 9kYLwPhbEvoPrkluU4HzxWfT2cLQBdXO2U+lw+1Eo28sKiDSVDPy6eoecG95/JW88B DLZfCbeeKp3CNdCZpuaj5Bi2ocgSetgoY5l6n0nnvKRCeSZBOCqO3hIN+Ma53AMh1z 8tC8dbAM/skgw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RVRP21p7bz9rxN; Tue, 22 Aug 2023 13:06:30 +0200 (CEST) In-Reply-To: <83a5ulwos6.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Aug 2023 21:29:29 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268160 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Juri Linkov , 65380@debbugs.gnu.org >> Date: Sun, 20 Aug 2023 18:24:53 +0000 >> >> Eli Zaretskii writes: >> >> >> From: Juri Linkov >> >> Cc: Philip Kaludercic , 65380@debbugs.gnu.org >> >> Date: Sun, 20 Aug 2023 19:30:03 +0300 >> >> >> >> Regarding the implementation, there is the function >> >> 'diff-hunk-text', but it's limited to one hunk only. >> > >> > So is the proposed new function, isn't it? >> >> No, the current proposal doesn't have any special handling for text >> between hunks. > > AFAIU, the function you proposed removes the first character from each > line in the region, so how will it handle multiple hunks? > > Or maybe I misunderstood what you meant by "No"? The command does not error when the region selects more than just a sub-region of a hunk, but it doesn't do anything useful either.