From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65475: 29.1; package-selected-packages variable is not updated when the last package is deleted Date: Sat, 26 Aug 2023 12:02:08 +0000 Message-ID: <87fs46ovun.fsf@posteo.net> References: <61352d45-21a6-466b-be7b-7755a6260356@gmail.com> <83a5uemfxy.fsf@gnu.org> <87o7iutg4i.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36976"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrey Samsonov , Eli Zaretskii , Stefan Monnier , 65475@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 26 14:03:37 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZs0v-0009Rf-4g for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Aug 2023 14:03:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZs0I-00020J-J3; Sat, 26 Aug 2023 08:02:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZs0H-0001uU-C9 for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 08:02:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZs0H-0004f4-3i for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 08:02:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZs0M-0004zE-7O for bug-gnu-emacs@gnu.org; Sat, 26 Aug 2023 08:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Aug 2023 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65475 X-GNU-PR-Package: emacs Original-Received: via spool by 65475-submit@debbugs.gnu.org id=B65475.169305134419093 (code B ref 65475); Sat, 26 Aug 2023 12:03:02 +0000 Original-Received: (at 65475) by debbugs.gnu.org; 26 Aug 2023 12:02:24 +0000 Original-Received: from localhost ([127.0.0.1]:41826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZrzk-0004xs-5o for submit@debbugs.gnu.org; Sat, 26 Aug 2023 08:02:24 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:60847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZrzh-0004xV-6x for 65475@debbugs.gnu.org; Sat, 26 Aug 2023 08:02:23 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 06862240028 for <65475@debbugs.gnu.org>; Sat, 26 Aug 2023 14:02:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693051330; bh=S/BFBXLuA2vwXnhfogVqXvUWV/UurArShxE38wM71w8=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=LXZjw7+JCg078HfC4U5g3vbRA/MDMaUIumIGli3QNAkNqL1DyxDRVp54zjDqzctfZ CnMmKHrKBgw4ek1NNZAE/x/oTimEnvkJIKnUzVKFTfUk1YXCkg5NdVYWs1i5V6XXBc lCMaThh3KX8mq6yBnUoB2mLx9pzBplfQ26XPXZWv/Ue2TUx1GXPQLJwUPEfLt53Obc xXgvrl8HsM2Cd39VLB6TYACQp9fbL9EYD/WOL+2FnlwyoyS4s4ynMK9Iv+iKTPw1nb 8xufqDo85NxSL4lVMGIAGol1UGYlnadRhrdCGyC6cV6sQkclgXoCyKgtQtAY9YJv/0 alpPcHwcGBWzQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RXwRP23m5z6twx; Sat, 26 Aug 2023 14:02:08 +0200 (CEST) In-Reply-To: (Stefan Kangas's message of "Sat, 26 Aug 2023 13:57:22 +0200") X-Hashcash: 1:20:230826:eliz@gnu.org::5iNrXBX7HQu6flkj:/J/ X-Hashcash: 1:20:230826:monnier@iro.umontreal.ca::7FNDV2RbPrn6g6ZP:Tjk X-Hashcash: 1:20:230826:stefankangas@gmail.com::HOUUMysRXyfHZo/C:14Cj X-Hashcash: 1:20:230826:65475@debbugs.gnu.org::Y7CYQO9BZUAbyAuD:3mjG X-Hashcash: 1:20:230826:samsonov.box@gmail.com::ZEj3SypEzCfn/KT1:6yFQ Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268501 Archived-At: Stefan Kangas writes: >> The issue here is that `package--save-selected-packages' only updates >> the value of `package-selected-packages', if the new value is non-nil, >> presumably because the VALUE argument is optional, > > This was added in d0a5162fd825, fixing Bug#20855. Personally, I'm not > a huge fan of that fix, as nil is clearly a valid (if infrequent) > value here. > > Could something like this work? > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index e1172d69bf0..9f97f950e64 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -1982,7 +1982,7 @@ package--find-non-dependencies > > (defun package--save-selected-packages (&optional value) > "Set and save `package-selected-packages' to VALUE." > - (when value > + (when (or value after-init-time) > (setq package-selected-packages value)) > (if after-init-time > (customize-save-variable 'package-selected-packages > package-selected-packages) It seems to be that this should also work, given that `package--save-selected-packages' is a package.el internal function, and there are no assurances that the current behaviour is to be expected in this edge-case. -- Philip Kaludercic