From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Date: Fri, 01 Sep 2023 13:14:45 +0000 Message-ID: <87fs3yvxve.fsf@posteo.net> References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> <87pm33r87q.fsf@posteo.net> <87sf7yoq9p.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32458"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65649@debbugs.gnu.org To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 01 15:16:06 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qc40M-0008Dv-F6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Sep 2023 15:16:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qc40B-0002zU-Rb; Fri, 01 Sep 2023 09:15:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qc409-0002z7-Ug for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 09:15:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qc409-0003pU-M2 for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 09:15:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qc40I-0005K6-BB for bug-gnu-emacs@gnu.org; Fri, 01 Sep 2023 09:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Sep 2023 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65649-submit@debbugs.gnu.org id=B65649.169357410420391 (code B ref 65649); Fri, 01 Sep 2023 13:16:02 +0000 Original-Received: (at 65649) by debbugs.gnu.org; 1 Sep 2023 13:15:04 +0000 Original-Received: from localhost ([127.0.0.1]:60068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc3zL-0005Ip-Ro for submit@debbugs.gnu.org; Fri, 01 Sep 2023 09:15:04 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:39013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc3zJ-0005I2-Ox for 65649@debbugs.gnu.org; Fri, 01 Sep 2023 09:15:03 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 79CBE240027 for <65649@debbugs.gnu.org>; Fri, 1 Sep 2023 15:14:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693574086; bh=dzOWAlhLhWNJ7AuF0FaXqjJiNOwC5Omop/bl+NAfF3c=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=l+e0nVnzMpmrKAXj/3IwimneBB3DDAdWNb4O8UM5WRuLpyCHciRcKcXQUHUIXDwkb tFv7wqhzJzlzJilVeDJLnaW71srwSTfbMDoc0kowHvu2TWaz/34GKblQVSmhEXFIdk Hi8fYWlsA4DqP1ZGpC1Dc8U53QLQqkjiRhF7bZKeMogtOhNSK5CJgN/zpOGQ2Clk9T nPYm2TO7Z+fibXOpwzFGyyV1a/Y0CYj6EWRKNqYDPSiTm50LVNA0moZtJG4Y0E4FlF UoTUwIRfEELSmlB3JxnJSMOfQNq+JI58xQR+JXE5dC/jn1GzzimBN9s3fcfXXlHWRw 8BD0AVLh8PH1A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RcdmQ0phJz9rxK; Fri, 1 Sep 2023 15:14:46 +0200 (CEST) In-Reply-To: <87sf7yoq9p.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Thu, 31 Aug 2023 14:19:11 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268880 Archived-At: Joseph Turner writes: > Philip Kaludercic writes: > >> Btw, watch out when reporting a bug, you shouldn't CC people directly, >> but add a X-Debbugs-CC header >> (https://debbugs.gnu.org/Reporting.html#xcc), as otherwise I'd be >> creating a new bug report when responding to your message. > > Good to know! Thank you! Is it okay to CC people when responding to a > bug report email (e.g. if I CC'd Eli in this email)? Yes, as soon as one is sending a message to [bugnumber]@debbugs.gnu.org, everything is fine. The issue if you Cc me directly, is that if I don't watch out, I'll send my response to bug-gnu-emacs@gnu.org, and thus create a new bug. >> Joseph Turner writes: >> >>> It would be nice to report more information about the package with failed >>> documentation, but AFAICT with-demoted-errors does not allow its FORMAT >>> string to be a symbol whose value is a string. >> >> What are the main errors we are concerned with? I am a bit concerned >> that `with-demoted-errors' is a too coarse approach and might be applied >> to widely in your current patch. It might be better to use a classical >> condition-case and handle the right errors in the right place, or if >> practicable try to detect if an error would occur before doing anything. > > I don't know what kinds of errors to expect, which is why I went with > the coarse approach. Under what circumstances would we want to stop > package installation entirely when documentation can't be built? I am not sure we want that behaviour at all actually. Just because there is a typo in the documentation, doesn't mean the package is unusable. The user should be able to install the package, be notified about the error -- if the have the time, they can fix it and send the maintainer a patch resolving the issue for everyone. Likewise, if the user updates a package, it wouldn't make sense to ignore everything or worse still revert the update due to a small mistake in the documentation file. >> Also, the buffer *package-vc doc* should stay persistent and would >> include error messages, that could also be used here. > > Like this? > > (with-demoted-errors "package-vc: Could not build documentation. See *package-vc doc* for details" ... ) Yes, that is what I had in mind. Joseph Turner writes: > Joseph Turner writes: > >> Philip Kaludercic writes: >> >>> Also, the buffer *package-vc doc* should stay persistent and would >>> include error messages, that could also be used here. >> >> Like this? >> >> (with-demoted-errors "package-vc: Could not build documentation. See *package-vc doc* for details" ... ) > > Actually, that would not have handled the error related to relative org > #+include statements, since that error happened above this line: > > (with-current-buffer (get-buffer-create " *package-vc doc*") There is no reason why we cannot already create and use the buffer earlier, to log org-related bugs. One has to be careful when emptying the buffer, but it might make sense to have a separate buffer for each package, especially when updating multiple packages at once...