From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#63513: [PATCH] Make persist-defvar work with records and hash tables Date: Fri, 08 Sep 2023 17:06:10 +0000 Message-ID: <87fs3o8uil.fsf@localhost> References: <87wn1axgh6.fsf@breatheoutbreathe.in> <83jzx925lv.fsf@gnu.org> <87a5xubwoo.fsf@breatheoutbreathe.in> <87v8csku60.fsf@breatheoutbreathe.in> <83cyyz94c6.fsf@gnu.org> <87a5u2ydzg.fsf@breatheoutbreathe.in> <83msy25g0s.fsf@gnu.org> <624CBB7F-1442-400D-8D4D-1B26EBE9DACB@breatheoutbreathe.in> <877cp5bmig.fsf@breatheoutbreathe.in> <871qvz4kdw.fsf@localhost> <8734zoaolv.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4385"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Adam Porter , Eli Zaretskii , phillip.lord@russet.org.uk, 63513-done@debbugs.gnu.org, Joseph Turner To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 08 19:07:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeewh-0000oz-BC for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Sep 2023 19:07:03 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeevr-0004xf-2n; Fri, 08 Sep 2023 13:06:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeevn-0004v0-Vx for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 13:06:08 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeevf-000165-P5 for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 13:06:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeevi-0005B8-3D for bug-gnu-emacs@gnu.org; Fri, 08 Sep 2023 13:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Sep 2023 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63513 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63513-done@debbugs.gnu.org id=D63513.169419272819829 (code D ref 63513); Fri, 08 Sep 2023 17:06:02 +0000 Original-Received: (at 63513-done) by debbugs.gnu.org; 8 Sep 2023 17:05:28 +0000 Original-Received: from localhost ([127.0.0.1]:45443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeevA-00059k-3C for submit@debbugs.gnu.org; Fri, 08 Sep 2023 13:05:28 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:55243) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeev6-00059G-FD for 63513-done@debbugs.gnu.org; Fri, 08 Sep 2023 13:05:26 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 05069240101 for <63513-done@debbugs.gnu.org>; Fri, 8 Sep 2023 19:05:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1694192716; bh=EytoX/f6Dt6gDSYr+WqS4lG8meXTKPZ8sSn6ytTrJMg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=ZLCAu+a0vcaPAisp0qVcLHAqLq0kPxf723JeEC/Q/ePhNW+jgcr6grp/XrDZgji0B F/D7Xh4d+BVthyCUJGyAMmLT4DNUk6ieCXLt+7vRMjTygHTrwSXR0B4EMfcr3PxCGR 4JWZOYLb4q7g1lQRhP+J3RdAujafyTcIqByILUeu3dZxcGMV/aJGLxeWPeAHYRm+J4 aqdXriqaEJ4fCkH4VlKxzolRdNCiau5aOoAUYy6wHrXRGHphgUDPUXmdbHq5O2T809 JOkQ6Tslrw3KY5dxclN6jVTuVbK0xMSoSP+d0nTY2oG0m13ykUiYRSY/gpog9dOFd9 7coL5E2o1Hfww== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Rj2Y64t0Tz6twC; Fri, 8 Sep 2023 19:05:14 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269800 Archived-At: Stefan Monnier writes: >>>> Here you go! >>> Thanks, pushed! >> May it be possible to promote `persist-hash-equal' and >> `persist-copy-tree' to common subr.el functions? >> The topic of comparing hash tables has been previously discussed in >> https://yhetil.org/emacs-devel/871qvz4kdw.fsf@localhost/ > > Hmm... AFAICT `persist-copy-tree` is a copy of our current `copy-tree`, > so there's nothing to do there :-) Err... Then, wouldn't it be better to contribute this function to compat.el and use it from there? > As for `persist-hash-equal` (which is actually called `persist-equal`, > AFAICT), I think if we want to move it out of `persist.el` we need to > improve it so it also looks inside hash-tables that occur within > vectors, conses, etc... > > Maybe, like Sam Steingold suggested, we should simply consider the > current treatment of `equal` on hash-tables to be a bug. That thread had no progress for quite a while. I thought that having `hash-equal' function could at least be an improvement (clearly, it is being used =F0=9F=99=82). But if you have an idea how to move the original discussion forward, please share it. AFAIU, no actionable conclusion have been reached in the linked thread. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at