unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Augusto Stoffel <arstoffel@gmail.com>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 66241@debbugs.gnu.org
Subject: bug#66241: 30.0.50; [PATCH] Use auth-info-mode for non-hidden authinfo and netrc files
Date: Mon, 02 Oct 2023 09:59:57 +0200	[thread overview]
Message-ID: <87fs2tsbcy.fsf@gmail.com> (raw)
In-Reply-To: <CADwFkmmbqbEkO2UDE1WOOM5R6aE6TVS3Ht7jwoQ-q9pwE4H64Q@mail.gmail.com> (Stefan Kangas's message of "Sat, 30 Sep 2023 19:34:31 -0700")

On Sat, 30 Sep 2023 at 19:34, Stefan Kangas wrote:

> Augusto Stoffel <arstoffel@gmail.com> writes:
>
>> See patch for the rationale.
>
> Thanks.  Could you explain why you think that this should this be the
> default value, instead of merely a user customization?

The user customization is indeed rather easy: one can add a "-*- mode:"
comment at the top of the file.  The main issue with that is that the
user needs to be aware of the existence of the mode.  I wasn't, until
recently.

The second point is, I see no potential for false-positives, i.e., who
would have a file name "authinfo" or "netrc" that is not a credentials
file?  (Of course this is just a theory which can be disputed.)

>>>From dc0abaff3dcaf9c7f48a8cd18dd045ae4323a030 Mon Sep 17 00:00:00 2001
>> From: Augusto Stoffel <arstoffel@gmail.com>
>> Date: Wed, 27 Sep 2023 18:35:32 +0200
>> Subject: [PATCH] Use auth-info-mode for non-hidden authinfo and netrc files
>>
>> * files.el (auto-mode-alist): Match non-hidden authinfo and netrc
>> files, since it is reasonable to store passwords in
>> ~/.emacs.d/authinfo.gpg or a similarly named file.
>> ---
>>  lisp/files.el | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lisp/files.el b/lisp/files.el
>> index b67482a2f74..f2980de4810 100644
>> --- a/lisp/files.el
>> +++ b/lisp/files.el
>> @@ -3038,7 +3038,7 @@ auto-mode-alist
>>       ("\\.docbook\\'" . sgml-mode)
>>       ("\\.com\\'" . dcl-mode)
>>       ("/config\\.\\(?:bat\\|log\\)\\'" . fundamental-mode)
>> -     ("/\\.\\(authinfo\\|netrc\\)\\'" . authinfo-mode)
>> +     ("/\\.?\\(authinfo\\|netrc\\)\\'" . authinfo-mode)
>>       ;; Windows candidates may be opened case sensitively on Unix
>>       ("\\.\\(?:[iI][nN][iI]\\|[lL][sS][tT]\\|[rR][eE][gG]\\|[sS][yY][sS]\\)\\'" . conf-mode)
>>       ("\\.la\\'" . conf-unix-mode)





  reply	other threads:[~2023-10-02  7:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-27 16:44 bug#66241: 30.0.50; [PATCH] Use auth-info-mode for non-hidden authinfo and netrc files Augusto Stoffel
2023-10-01  2:34 ` Stefan Kangas
2023-10-02  7:59   ` Augusto Stoffel [this message]
2024-01-10 22:08     ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs2tsbcy.fsf@gmail.com \
    --to=arstoffel@gmail.com \
    --cc=66241@debbugs.gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).