From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function Date: Mon, 11 Dec 2023 16:12:18 +0100 Message-ID: <87fs08zsbx.fsf@betli.tmit.bme.hu> References: <87h6vo1ph6.fsf@thornhill.no> <87pmacjl4l.fsf@betli.tmit.bme.hu> <74E0BF9F-42AF-4578-9681-D0FB936081AE@thornhill.no> <87pmabi1tw.fsf@betli.tmit.bme.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11118"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: 61506@debbugs.gnu.org, joaotavora@gmail.com To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 11 16:12:59 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rChxr-0002iZ-71 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Dec 2023 16:12:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rChxg-000604-PL; Mon, 11 Dec 2023 10:12:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rChxf-0005z6-N0 for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 10:12:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rChxf-000211-E5 for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 10:12:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rChxt-0005pI-UP for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 10:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61506 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61506-submit@debbugs.gnu.org id=B61506.170230756322370 (code B ref 61506); Mon, 11 Dec 2023 15:13:01 +0000 Original-Received: (at 61506) by debbugs.gnu.org; 11 Dec 2023 15:12:43 +0000 Original-Received: from localhost ([127.0.0.1]:54333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rChxb-0005oj-JK for submit@debbugs.gnu.org; Mon, 11 Dec 2023 10:12:43 -0500 Original-Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:56473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rChxZ-0005oV-Hr for 61506@debbugs.gnu.org; Mon, 11 Dec 2023 10:12:42 -0500 Original-Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50be3611794so5347154e87.0 for <61506@debbugs.gnu.org>; Mon, 11 Dec 2023 07:12:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702307540; x=1702912340; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=aS0JQqdAuT5r0mS9ydtSMRS0BNIsFWwv9aSfRrj8+mU=; b=SamMUaZssg2vLUSXibKNDpNS1keeoT2vf/WRDrfHoqN62E2MtZqRizDuOv7K9v6pp9 9/a155aTiffULL3y+fg7hVBv/13vNKi8tPm42yEOJoF52Zlkfc41jxQ1xJ2HJulU1RuV kYMIdu8YKKF3Pd+jgCO/l78Tx9zhYtjSNpgSSV/LY3eeZUbdgMC+PC4oeOaD62IK71gu oPCBXsEJwvDr6dIdYJ+bw++wPoThHOedSVqgoWzTe9grd4zOgWzHcQWPMS5eAo4lF7Tl aFz7eZiIYC5gNCIPiBbXo6Bb1wOIDZYTm8yAv5ZAVjTkf0qMU9NOJfZeM8QR06Xkhjwz OW0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702307540; x=1702912340; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=aS0JQqdAuT5r0mS9ydtSMRS0BNIsFWwv9aSfRrj8+mU=; b=QLyZn91Ga5VJIKy8snNgSm9AumA/0UD5+bLzXQz4WM9wzqSKf0yBe+z2jRDrgkc4CT Kj+eTqNtKLK+UO5JB0fy6boO7fTiSV6LdT+gjaekFsbiesFq4rMMXxn1TpBILrikEMXZ UxhU3zZky46fCH1vQ90P+FLmksKavJ1OvcnwFmeNejnMZB4bLlQOgef2twZikvCRmffx E1ngKkLZkxASxZPB9qJummlXdobiqCefhB6KLpsfgho+2DPFP/5wbAgCq9qqcSLlTBbJ PdUOaqoIV7/qlE/edz6ZAt23dP9mMhPHIGJPqzS4iLuIzxZsryXXrfw7H8PGW4homkbh ip7w== X-Gm-Message-State: AOJu0YzGV2X1w/A7OyHld9S8Zt/nGDDdbWoQYaAIYH/rnqJF833StQOk fBz7x1+xL/06cvQxarKERFg= X-Google-Smtp-Source: AGHT+IFvOxzNfM5LTKRJH4m2oanrRLS3opVzuWb0KTSA8lnPe49qWS5USORSX1ysBWV30Izq1Z4U8Q== X-Received: by 2002:a05:6512:3d91:b0:50b:f0c6:46e6 with SMTP id k17-20020a0565123d9100b0050bf0c646e6mr2807936lfv.91.1702307540030; Mon, 11 Dec 2023 07:12:20 -0800 (PST) Original-Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id ps3-20020a170906bf4300b00a1dd8945d31sm4937561ejb.34.2023.12.11.07.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 07:12:19 -0800 (PST) In-Reply-To: <87pmabi1tw.fsf@betli.tmit.bme.hu> (Felician Nemeth's message of "Wed, 15 Feb 2023 12:51:23 +0100") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX5+fmhoaEwMDD/ ///TMNVWAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAAPEgAADxIBIZvyMwAAAAd0SU1FB+AICBUfHgLs gGoAAAGXSURBVCjPRdK/b5tAFAfw753gBEwM2ApMbuVIqf+Ko0qiyhOu4sj2xJBYMn/FUdX7UUUZ OjHgyvf+yj6IcW6Bjx53934ADEvs8bmEr8UVoTYTOyJO9KoYsVofN8kILdbeJ8Li6YpZWop4xOK0 VdfIoXmkHn5/5D7/Ts/8THacSqnkKTcMTxgUkVzFnEIRTKwwYYSCvzfg16f0i8YApW/XG/Pm8R49 dXjxKmRnxv3OwooQWcv4RUYem1fsNe/WU63uk7AmYxk78y32/ee2tZB4fO+WcZ7lnIGEolXW1EGw LfkSuQ0XTgRefgNlfNwRNV6QhBxJ8JNxTMUPyBqTd0bjaAP5G7NJRU39z80hLOZTjqB7K3tEEFSj aEsuQew6qBxxyhHjVUR7H7NpC9iHJZGLMCEuweqAqE1BHbfK2oRIz9EHYA/+wiFWru9smeVfuWNZ 2+NFtX80UA1TvJNdytM4DwO4kY7bJz8Qcd0G0ceslZGkkeoBsjUHwF1+jjM3XHaXEZ7mGLfwPFO+ RV9QLY2iEdmDo78D/gNPaXVYqd+pyQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxNi0wOC0wOFQyMzoz MDoyOCswMjowMGy/yHYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTYtMDgtMDhUMjM6MzA6MjgrMDI6 MDAd4nDKAAAAAElFTkSuQmCC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275986 Archived-At: >>>> I have no strong opinions on _where_ exactly the command should be sen= t, >>>> as in before or after the didchange notification. > > I've created an issue about it here: > https://github.com/microsoft/language-server-protocol/issues/1672 We've got a reply. Dirk B=E4umer writes: > Actually the command has to be dispatch on the client side since. IF > the client then forwards it to the server that is fine. From a timing > perspective it should arrive at the server (if at all) after > textDocument/didChange. I hope this is useful. Unfortunately, I don't really remember why I was involved in this thread.