unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#68450: 30.0.50; Eldoc fails to display argument tooltip for arguments inside (...) in `define-advice'
@ 2024-01-14 14:28 Ihor Radchenko
  2024-01-14 16:01 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2024-01-20  9:37 ` Eli Zaretskii
  0 siblings, 2 replies; 6+ messages in thread
From: Ihor Radchenko @ 2024-01-14 14:28 UTC (permalink / raw)
  To: 68450

Hello,

Consider the following recipe:

1. emacs -Q
2. type (define-advice org-capture
3. Observe "define-advice: (SYMBOL (*HOW* LAMBDA-LIST &optional NAME DEPTH) &rest BODY)
   in the echo area
4. type (
5. Nothing appears in the echo area

Expected:
"define-advice: (SYMBOL (*HOW* LAMBDA-LIST &optional NAME DEPTH) &rest BODY)
still appears in the echo area.

In GNU Emacs 30.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version
 3.24.39, cairo version 1.18.0) of 2024-01-13 built on localhost
Repository revision: 479a81611ed4c676f5f370d97caf43867b04ed17
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101009
System Description: Gentoo Linux


-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#68450: 30.0.50; Eldoc fails to display argument tooltip for arguments inside (...) in `define-advice'
  2024-01-14 14:28 bug#68450: 30.0.50; Eldoc fails to display argument tooltip for arguments inside (...) in `define-advice' Ihor Radchenko
@ 2024-01-14 16:01 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2024-01-20  9:37 ` Eli Zaretskii
  1 sibling, 0 replies; 6+ messages in thread
From: Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-01-14 16:01 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: 68450

On Sun, 14 Jan 2024 14:28:27 +0000 Ihor Radchenko <yantar92@posteo.net> wrote:

> Hello,
>
> Consider the following recipe:
>
> 1. emacs -Q
> 2. type (define-advice org-capture
> 3. Observe "define-advice: (SYMBOL (*HOW* LAMBDA-LIST &optional NAME DEPTH) &rest BODY)
>    in the echo area
> 4. type (
> 5. Nothing appears in the echo area
>
> Expected:
> "define-advice: (SYMBOL (*HOW* LAMBDA-LIST &optional NAME DEPTH) &rest BODY)
> still appears in the echo area.

May be the same problem as reported in the still unsolved bug#8432.

Steve Berman





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#68450: 30.0.50; Eldoc fails to display argument tooltip for arguments inside (...) in `define-advice'
  2024-01-14 14:28 bug#68450: 30.0.50; Eldoc fails to display argument tooltip for arguments inside (...) in `define-advice' Ihor Radchenko
  2024-01-14 16:01 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-01-20  9:37 ` Eli Zaretskii
  2024-01-20 10:27   ` João Távora
  1 sibling, 1 reply; 6+ messages in thread
From: Eli Zaretskii @ 2024-01-20  9:37 UTC (permalink / raw)
  To: Ihor Radchenko, Thierry Volpiatto, João Távora; +Cc: 68450

> From: Ihor Radchenko <yantar92@posteo.net>
> Date: Sun, 14 Jan 2024 14:28:27 +0000
> 
> 1. emacs -Q
> 2. type (define-advice org-capture
> 3. Observe "define-advice: (SYMBOL (*HOW* LAMBDA-LIST &optional NAME DEPTH) &rest BODY)
>    in the echo area
> 4. type (
> 5. Nothing appears in the echo area
> 
> Expected:
> "define-advice: (SYMBOL (*HOW* LAMBDA-LIST &optional NAME DEPTH) &rest BODY)
> still appears in the echo area.

Thierry and João, could you please look into this?





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#68450: 30.0.50; Eldoc fails to display argument tooltip for arguments inside (...) in `define-advice'
  2024-01-20  9:37 ` Eli Zaretskii
@ 2024-01-20 10:27   ` João Távora
  2024-01-20 17:45     ` Thierry Volpiatto
  0 siblings, 1 reply; 6+ messages in thread
From: João Távora @ 2024-01-20 10:27 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Thierry Volpiatto, Ihor Radchenko, 68450

On Sat, Jan 20, 2024 at 9:37 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > Expected:
> > "define-advice: (SYMBOL (*HOW* LAMBDA-LIST &optional NAME DEPTH) &rest BODY)
> > still appears in the echo area.
>
> Thierry and João, could you please look into this?

I'm reasonably sure the source of this bug isn't in ElDoc per se,
but in elisp-mode.el's use of eldoc.el facilities, which are sometimes
very verbose due to longstanding issues.  But I will have a look.
I'd also like elisp-mode to start highlighting nested macro arguments
and keyword arguments, for example.

João





^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#68450: 30.0.50; Eldoc fails to display argument tooltip for arguments inside (...) in `define-advice'
  2024-01-20 10:27   ` João Távora
@ 2024-01-20 17:45     ` Thierry Volpiatto
  2024-01-20 18:01       ` João Távora
  0 siblings, 1 reply; 6+ messages in thread
From: Thierry Volpiatto @ 2024-01-20 17:45 UTC (permalink / raw)
  To: João Távora; +Cc: Eli Zaretskii, Ihor Radchenko, 68450

[-- Attachment #1: Type: text/plain, Size: 637 bytes --]

João Távora <joaotavora@gmail.com> writes:

> On Sat, Jan 20, 2024 at 9:37 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
>> > Expected:
>> > "define-advice: (SYMBOL (*HOW* LAMBDA-LIST &optional NAME DEPTH) &rest BODY)
>> > still appears in the echo area.
>>
>> Thierry and João, could you please look into this?
>
> I'm reasonably sure the source of this bug isn't in ElDoc per se,
> but in elisp-mode.el's use of eldoc.el facilities,

Yes, probably, we have the same problem with (dolist (...
Slime handles this correctly IIRC, it has a nice library handling
signatures but I don't remember the details.

-- 
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 686 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#68450: 30.0.50; Eldoc fails to display argument tooltip for arguments inside (...) in `define-advice'
  2024-01-20 17:45     ` Thierry Volpiatto
@ 2024-01-20 18:01       ` João Távora
  0 siblings, 0 replies; 6+ messages in thread
From: João Távora @ 2024-01-20 18:01 UTC (permalink / raw)
  To: Thierry Volpiatto; +Cc: Eli Zaretskii, Ihor Radchenko, 68450

On Sat, Jan 20, 2024 at 5:45 PM Thierry Volpiatto <thievol@posteo.net> wrote:
>
> João Távora <joaotavora@gmail.com> writes:
>
> > On Sat, Jan 20, 2024 at 9:37 AM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> >> > Expected:
> >> > "define-advice: (SYMBOL (*HOW* LAMBDA-LIST &optional NAME DEPTH) &rest BODY)
> >> > still appears in the echo area.
> >>
> >> Thierry and João, could you please look into this?
> >
> > I'm reasonably sure the source of this bug isn't in ElDoc per se,
> > but in elisp-mode.el's use of eldoc.el facilities,
>
> Yes, probably, we have the same problem with (dolist (...
> Slime handles this correctly IIRC, it has a nice library handling
> signatures but I don't remember the details.

Yes, you recall correctly.  Like SLY, Slime's fork, it has some
minimal sexp parsing logic that it makes use of in slime-autodoc.el.
I'll see what I can do (if you don't beat me to it), but this is
probably a very old bug: I don't remember Elisp ever handling
this correctly.

João





^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-01-20 18:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-14 14:28 bug#68450: 30.0.50; Eldoc fails to display argument tooltip for arguments inside (...) in `define-advice' Ihor Radchenko
2024-01-14 16:01 ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-20  9:37 ` Eli Zaretskii
2024-01-20 10:27   ` João Távora
2024-01-20 17:45     ` Thierry Volpiatto
2024-01-20 18:01       ` João Távora

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).