From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Emanuel Berg Newsgroups: gmane.emacs.bugs,gmane.emacs.erc.general Subject: bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt Date: Wed, 24 Jan 2024 02:38:15 +0100 Message-ID: <87frynh5o8.fsf@dataswamp.org> References: <87v87yvnly.fsf@dataswamp.org> <834jfikb4d.fsf@gnu.org> <87mstavias.fsf@dataswamp.org> <87wmseoskl.fsf@dataswamp.org> <87plxyowpg.fsf__13716.8874776521$1705633220$gmane$org@neverwas.me> <87il3ki2tg.fsf@dataswamp.org> <87il3jh8mu.fsf__35629.5012797759$1706056526$gmane$org@neverwas.me> <87il3jh64c.fsf@dataswamp.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13914"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 68401@debbugs.gnu.org Cancel-Lock: sha1:Q0AujCFy4ZMgVZnbfOUszN8LwPE= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 24 02:39:29 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSSEj-0003PL-AM for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jan 2024 02:39:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSSEE-00014d-GH; Tue, 23 Jan 2024 20:38:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSSED-00014U-RF for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 20:38:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSSED-0005Lc-JB for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 20:38:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rSSEI-0001r8-8C for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 20:39:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87v87yvnly.fsf@dataswamp.org> Resent-From: Emanuel Berg Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2024 01:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68401 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17060603257112 (code B ref -1); Wed, 24 Jan 2024 01:39:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Jan 2024 01:38:45 +0000 Original-Received: from localhost ([127.0.0.1]:44230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSSE0-0001qc-V6 for submit@debbugs.gnu.org; Tue, 23 Jan 2024 20:38:45 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:53656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSSDz-0001qL-0X for submit@debbugs.gnu.org; Tue, 23 Jan 2024 20:38:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSSDn-0000u6-1R for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 20:38:31 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSSDl-0005Fj-4Y for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 20:38:30 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rSSDi-00020E-2j for bug-gnu-emacs@gnu.org; Wed, 24 Jan 2024 02:38:26 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org Original-Followup-To: gmane.emacs.bugs,gmane.emacs.erc.general Mail-Copies-To: never Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278758 gmane.emacs.erc.general:2407 Archived-At: --=-=-= Content-Type: text/plain tags: patch > But fine, no need to be frustrated about it, I got to > practice the git commands over and over. Now let's hope we > can make it happen this time around then. Done. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0003-Remove-the-logical-connectivity-test.patch >From 01ab5bd44db814e4520306b85a57ad0e01140674 Mon Sep 17 00:00:00 2001 From: Emanuel Berg Date: Wed, 24 Jan 2024 02:31:04 +0100 Subject: [PATCH 3/3] Remove the logical connectivity test Test already there in another form. * lisp/erc/erc.el (erc-cmd-AMSG, erc-cmd-GMSG, erc-cmd-AME, erc-cmd-GME): removed from these functions. (bug#68401) --- lisp/erc/erc.el | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index e89733e7871..e375145e825 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -4004,17 +4004,12 @@ erc--split-string-shell-cmd ;; Input commands handlers ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; -(defun erc--connected-and-joined-p () - (and (erc--current-buffer-joined-p) - erc-server-connected)) - (defun erc-cmd-GMSG (line) "Send LINE to all channels on all networks you are on." (setq line (string-remove-prefix " " line)) (erc-with-all-buffers-of-server nil (lambda () (erc-channel-p (erc-default-target))) - (when (erc--connected-and-joined-p) - (erc-send-message line)))) + (erc-send-message line))) (put 'erc-cmd-GMSG 'do-not-parse-args t) (defun erc-cmd-AMSG (line) @@ -4024,24 +4019,21 @@ erc-cmd-AMSG (setq line (string-remove-prefix " " line)) (erc-with-all-buffers-of-server erc-server-process (lambda () (erc-channel-p (erc-default-target))) - (when (erc--connected-and-joined-p) - (erc-send-message line)))) + (erc-send-message line))) (put 'erc-cmd-AMSG 'do-not-parse-args t) (defun erc-cmd-GME (line) "Send LINE as an action to all channels on all networks you are on." (erc-with-all-buffers-of-server nil (lambda () (erc-channel-p (erc-default-target))) - (when (erc--connected-and-joined-p) - (erc-cmd-ME line)))) + (erc-cmd-ME line))) (put 'erc-cmd-GME 'do-not-parse-args t) (defun erc-cmd-AME (line) "Send LINE as an action to all channels on the current network." (erc-with-all-buffers-of-server erc-server-process (lambda () (erc-channel-p (erc-default-target))) - (when (erc--connected-and-joined-p) - (erc-cmd-ME line)))) + (erc-cmd-ME line))) (put 'erc-cmd-AME 'do-not-parse-args t) (defun erc-cmd-SAY (line) -- 2.39.2 --=-=-= Content-Type: text/plain -- underground experts united https://dataswamp.org/~incal --=-=-=--