bug#68977: 30.0.50; Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame...>)

bug#68977: 30.0.50; Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame...>)

[Ihor Radchenko]

Hello,

I am getting the following error from time to time:

Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame *notmuch-saved-search-[ inbox ] and tag:todo* 0x7f344894dd80>)

Looks like something inside winner.el does not check for `frame-live-p'.

In GNU Emacs 30.0.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version
 3.24.41, cairo version 1.18.0) of 2024-02-04 built on localhost
Repository revision: ac3b44daf09cf723687664f21ff557d9d5ebc19b
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101011
System Description: Gentoo Linux


-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

bug#68977: 30.0.50; Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame...>)

[Eli Zaretskii]

> From: Ihor Radchenko <yantar92@posteo.net>
> Date: Wed, 07 Feb 2024 16:28:33 +0000
> 
> I am getting the following error from time to time:
> 
> Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame *notmuch-saved-search-[ inbox ] and tag:todo* 0x7f344894dd80>)
> 
> Looks like something inside winner.el does not check for `frame-live-p'.

Any hope of recipe to reproduce this?

bug#68977: 30.0.50; Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame...>)

[Ihor Radchenko]

Eli Zaretskii <eliz@gnu.org> writes:

>> Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame *notmuch-saved-search-[ inbox ] and tag:todo* 0x7f344894dd80>)
>> 
>> Looks like something inside winner.el does not check for `frame-live-p'.
>
> Any hope of recipe to reproduce this?

1. emacs -Q --eval "(server-start)" --eval "(winner-mode +1)"
2. emacsclient -c -n (may need to run it several times)
3. C-x C-c

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

bug#68977: 30.0.50; Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame...>)

[Eli Zaretskii]

> From: Ihor Radchenko <yantar92@posteo.net>
> Cc: 68977@debbugs.gnu.org
> Date: Thu, 08 Feb 2024 14:03:10 +0000
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> Error in post-command-hook (winner-save-old-configurations): (wrong-type-argument frame-live-p #<dead frame *notmuch-saved-search-[ inbox ] and tag:todo* 0x7f344894dd80>)
> >> 
> >> Looks like something inside winner.el does not check for `frame-live-p'.
> >
> > Any hope of recipe to reproduce this?
> 
> 1. emacs -Q --eval "(server-start)" --eval "(winner-mode +1)"
> 2. emacsclient -c -n (may need to run it several times)
> 3. C-x C-c

Thanks.  I've fixed the immediate cause of this, but maybe someone
should take a look at winner-change-fun, which is supposed to handle
frame deletion -- it sounds like the offending frame is not removed in
this case?

Closing.