From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70038: 29.3.50; Shift up/down in buffer with images on M-x other-window with some fonts Date: Sat, 06 Apr 2024 22:20:29 +0800 Message-ID: <87frvy609e.fsf@yahoo.com> References: <87ttkrl8w1.fsf@gmail.com> <86zfuihp7t.fsf@gnu.org> <87bk6yl4hu.fsf@gmail.com> <8734sal2bc.fsf@gmail.com> <87wmpm2rd7.fsf@zohomail.eu> <86bk6m3c20.fsf@gnu.org> <867cha37of.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23221"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: martin rudalics , r.diaz@uam.es, 70038@debbugs.gnu.org, rdiaz02@gmail.com, rahguzar@zohomail.eu To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 06 16:21:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rt6uz-0005mW-HV for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Apr 2024 16:21:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rt6uf-0004b5-3D; Sat, 06 Apr 2024 10:20:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rt6ue-0004ax-H1 for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 10:20:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rt6ue-0007a3-8P for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 10:20:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rt6uk-0003gz-Cm for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2024 10:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Apr 2024 14:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70038 X-GNU-PR-Package: emacs Original-Received: via spool by 70038-submit@debbugs.gnu.org id=B70038.171241325814176 (code B ref 70038); Sat, 06 Apr 2024 14:21:02 +0000 Original-Received: (at 70038) by debbugs.gnu.org; 6 Apr 2024 14:20:58 +0000 Original-Received: from localhost ([127.0.0.1]:40535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt6ug-0003ga-BG for submit@debbugs.gnu.org; Sat, 06 Apr 2024 10:20:58 -0400 Original-Received: from sonic306-21.consmr.mail.ne1.yahoo.com ([66.163.189.83]:41497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt6ue-0003fk-KT for 70038@debbugs.gnu.org; Sat, 06 Apr 2024 10:20:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1712413244; bh=JHRrCVxNK0ONVyyXTV2MBrSnFPtc5n3JuMOHGLV3Z+A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=OJPosjjP6lctK206mbvsnmnpm3TGB1JQqgceP3gucNMlXdu7Gf2QlsQU0+lfqcyRBZF2POkuHG0u2hGKiYUjocvq8TY3ACGLvLH/VrGq8t3ER1B2nYsi0pHaa73bCTsRFTTb+CGqoGU+Ra8bedrBoYPikgPSi/ShuNOJqUtXlevNmEyWCduPqQznpxcQfe6p8oJKTLhDSdw5si8bRNjUdVC0XQ8QPhYTFrSJ/fzVmZgnyUEVV4ZPAXMs9np/BGacTfZlROw5BwqEnj3ceYGohyzspKVVrJrDeEReIJiBWzu3ycC0w27d0PEdM2afFq+4G2Dz7Fu/vOW7hga4Z5z/Bw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1712413244; bh=IiirZ0bL9dvZcPSgj96yuXLp4yQ2wD+ZywvKj5dmSk+=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=RvsdGEuFEhIX+4qp7r2/W1FmftwHc6TwuFJHFe/g/6814UIcIIwD1j0iYz/I+7zjH7Ik0vDR3EHyEcj+ufn2om2YJasK2O+kPnczhkmsbCwOe9hUY7XjnrSsA49yMPXdQFCRevaoZ/n8IKujsHZkETDq4B7i888+ntGVwJVMNly7aJBxYhw3k6Cjex5FTr9/U3JLsL2j1XS+I+nOuEfeyr1lV/FbbrgWxAYzG3kE1rxPF3QtwaSr0QYRerekEB61ugOKV9C4JrjPM5taFAkyPv2P+o8o0pcMiqbbBTS9/OE3Sd8VABxMcirUfkptNbHe/ztL/aUSXOb9tucyutEt0w== X-YMail-OSG: aNQfZQ8VM1lkxSBDFGOQkacr0j7ASvvxSKFvnVSuz2uGO6imhgeIa7HqplEpcx7 M808Q.XeCWEEqlF6WLak9cZR.ni6yOfEsEiP.e1n8x7TYEk._WX4CtyeCRejzKtrJGIKE._Pka9k 9LPepXOaemYJer8Hbpd0gnWZ79rd7uzBIkz15xyaKhHCkCEztuL2EveoMzSRr3xcXTmc1hhGDSea boe68GDTEL3UmNg.RblzMxlC3sKE1eja1JFsxazVLP473PYMNIM.BXpaDIJxeVhgqqCWWxqa172j 3DJQMCE6OoMzgfyF_xvYdI9dqCpv6au8jrThYwiNGSTEwhEZYRbl_A07A7pXtjCktaTUoCVOxhWk gNISiT2XCKmFIu5SOp4UTR2MYKVIeBKuqTQKnpNdvqJSG5v3reIsVxA6OiGoHBT0fZVO.MnVrjBd Qe42dbNt3D5wKPLirlnORYAbEztuihbIT46iKy.3gYQi6n2s21zApjwKqkCb.3LLwVft0Az8niSd 5uffinyA_5Dp7d0p9vTvsLRrbVVGoLvkXmSwJxmDa47frlkSsh6Ni3D5tvvJTMVa.5f2HMGzaDO. yx2b9Qo1lz0n89Svyq3daPLjSUgLVQNq8R8hH_elrUd4Ej216b6M_tW6nvgqWda5Rm7KNacr_apg dSdiMP8LNs_8NpabTQpQ.G.DrHJ_x0MEbGqSXCH3sYHuQNRqhTntFeO7enVd3r9e1K8e5Ge9YoY6 4HiYxicXNiCdb7_Bz36qlpKdUVcQHCsstOc4PupKKn5cokA8p4iZpWGAXBbIr.mg9lYQJivn1lIR QxxJqj9E.XAySQlucE_D5IYoYcmyT0Ifc1fcd3DCke X-Sonic-MF: X-Sonic-ID: 31d0aba8-942d-4023-865d-a14be094d956 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Sat, 6 Apr 2024 14:20:44 +0000 Original-Received: by hermes--production-sg3-6dc75bc8fb-qvr7d (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 88c5014ceb8ae8a90ffb4a19c58598fb; Sat, 06 Apr 2024 14:20:36 +0000 (UTC) In-Reply-To: <867cha37of.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 Apr 2024 17:08:32 +0300") X-Mailer: WebService/1.1.22205 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282795 Archived-At: Eli Zaretskii writes: >> Po Lu, I'm looking at this part of redisplay_window: >> >> force_start: >> >> /* Handle case where place to start displaying has been specified, >> unless the specified location is outside the accessible range. */ >> if (w->force_start) >> { >> /* We set this later on if we have to adjust point. */ >> int new_vpos = -1; >> >> w->force_start = false; >> >> /* The vscroll should be preserved in this case, since >> `pixel-scroll-precision-mode' must continue working normally >> when a mini-window is resized. (bug#55312) */ >> if (!w->preserve_vscroll_p || !window_frozen_p (w)) <<<<<<<<<<<<<<< >> w->vscroll = 0; >> >> w->preserve_vscroll_p = false; >> w->window_end_valid = false; >> >> where you added the condition for resetting w->vscroll in commit >> fd8eaa72a61, and I'm thinking that perhaps the condition should be >> >> if (!w->preserve_vscroll_p && !window_frozen_p (w)) >> >> instead? If not, can you explain why we use OR and not AND there? I think you are correct.