From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70036: a fix that Date: Fri, 19 Apr 2024 13:47:23 +0200 Message-ID: <87frvhlgl0.fsf@thornhill.no> References: <4e670617-6483-4159-a5cf-27a921764c38@email.android.com> <864jbxden1.fsf@gnu.org> <86r0f1bopx.fsf@gnu.org> <87r0f1mvtx.fsf@thornhill.no> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39177"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 70036@debbugs.gnu.org, felician.nemeth@gmail.com To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 19 13:48:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxmj2-0009wk-By for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Apr 2024 13:48:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxmih-0006fM-J6; Fri, 19 Apr 2024 07:47:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxmia-0006er-GH for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 07:47:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxmia-00013I-63 for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 07:47:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxmin-0005cD-T2 for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 07:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Apr 2024 11:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70036 X-GNU-PR-Package: emacs Original-Received: via spool by 70036-submit@debbugs.gnu.org id=B70036.171352727021463 (code B ref 70036); Fri, 19 Apr 2024 11:48:01 +0000 Original-Received: (at 70036) by debbugs.gnu.org; 19 Apr 2024 11:47:50 +0000 Original-Received: from localhost ([127.0.0.1]:58137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxmib-0005a6-IK for submit@debbugs.gnu.org; Fri, 19 Apr 2024 07:47:49 -0400 Original-Received: from out-171.mta0.migadu.com ([91.218.175.171]:43954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxmiY-0005Ym-43 for 70036@debbugs.gnu.org; Fri, 19 Apr 2024 07:47:47 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1713527246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QobIiwFRT+cSpfYvE+Jp/DpOTA7dqdBkmgKTLe+Fbjs=; b=jNh2ybkCM8u4b3TGoFqS6/v4aXKAzz2gK6DlO7dJcOmIuDbb+AXQt8pkzYEbhOXNzyIXlm y/zgwxv50DIvrZZg5DKCc4u+iqxHVMqbwRrO4RCAlprjBl4tL5ETPUo+RgscB8XW1anpMz J52SqkLvFv0mLUjaDLPslbR7x1VBug+eLXWoVt3OCXaj1KZ7iAU7YmnR94SOIbmmXsnoXZ Re1F/9TbKtuyooiEeByyQY2qguqPb1TFjaFs2LLEVbGbrJSJJyj1/MuLNF7Or3S7Tyzm+o sPYDQUqjS+0IBDtVLyGg2z/BJl9vF8ZaL3Zzs1gwipX3XMAQIBCtXsn9FauoOA== In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283671 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > On Fri, Apr 19, 2024 at 12:32=E2=80=AFPM Theodor Thornhill wrote: > >> I wonder - why can't we use just buffer-file-truename? >> >> In the below function, wouldn't buffer-file-truename let us avoid the >> file-truename in eglot-path-to-uri? > > Never used, but try it out. It seems it's already a built-in cache > of whatever the buffer's truename is (and the docstring says > it does call the slow `file-truename`). But like in my patch, it's > a one-time thing. So yeah, if it's available in old Emacsen as well, > it could replace `eglot--cached-tdi`, but then the search in the > publishDiagnostics > handler would have to be adjusted accordingly to call uri-to-path again. What would you consider as a sufficiently old Emacs? > > Try it out, may be cleaner indeed. > > Beware though, Stefan has fixed the tests which is very good, but there > still isn't a test for the symlink scenario, so you'd have to test it > manually (or > even better, craft that test yourself, with clangd). > > Jo=C3=A3o Sure Theo