From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#70524: [PATCH] Fix `map-elt` with `setf` for subplaces Date: Thu, 25 Apr 2024 14:03:47 +0200 Message-ID: <87frv9odi4.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24905"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: michael_heerdegen@web.de, okamsn@protonmail.com, monnier@iro.umontreal.ca To: 70524@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 25 14:05:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzxqn-0006IA-NV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Apr 2024 14:05:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzxqU-0005wm-1n; Thu, 25 Apr 2024 08:04:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzxqS-0005wS-Ht for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2024 08:04:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzxqS-00015R-9N for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2024 08:04:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rzxqj-0000cd-AF for bug-gnu-emacs@gnu.org; Thu, 25 Apr 2024 08:05:13 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Apr 2024 12:05:12 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: Okamsn via "Bug reports for GNU Emacs, the Swiss army knife of text editors" X-Debbugs-Original-Cc: Michael Heerdegen , okamsn@protonmail.com, Stefan Monnier , 70524@debbugs.gnu.org Original-Received: via spool by 70524-submit@debbugs.gnu.org id=B70524.17140466681866 (code B ref 70524); Thu, 25 Apr 2024 12:05:12 +0000 Original-Received: (at 70524) by debbugs.gnu.org; 25 Apr 2024 12:04:28 +0000 Original-Received: from localhost ([127.0.0.1]:60637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzxps-0000T9-AA for submit@debbugs.gnu.org; Thu, 25 Apr 2024 08:04:25 -0400 Original-Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]:54544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzxpl-0000Qp-2a for 70524@debbugs.gnu.org; Thu, 25 Apr 2024 08:04:16 -0400 Original-Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-a56d7d457a1so108248466b.1 for <70524@debbugs.gnu.org>; Thu, 25 Apr 2024 05:03:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714046629; x=1714651429; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=s5lG/WpL0z+StFLSaPe2qYnYk6zZZ351ui9nsadtJds=; b=H5YI7d1hjgyQnKPESlBiHaTbiJvtMW9aX16YEArluLgJYJIwYQepU8jNGX6IfDZC/l Q8p71SZWADBZ6zPhjQ7Wii6qk8WA06skSemo5579WHFGyuM8mO9hLb0JQQIUGD6y1u4q TZgoGy50SFfXfppaLTnIPWdywuRpF7ofFRa9P5y1PRyanTtKf/j1Raq2/RrWJxAroHei cYhREMhgRSuyqL16NUoIrcnvNH7TXZuhNffL0IJRDtks0pZmVGYZpWU0FIMESahtWTzy OjlltMOf2AZWSRM/h4+A7Gf7jDXKGyIrOJkkm7YnVN377Osmd2b9tLPGtYkBkiWN9qNx /JfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714046629; x=1714651429; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=s5lG/WpL0z+StFLSaPe2qYnYk6zZZ351ui9nsadtJds=; b=kpiSTMb4rdoQ5CWDyTSlcII0tnctq4kLbJqHhenkeqXih5hjME8inc9TTJIE9YVg8/ Z3UupZDmxGORTKaAWHuiJE5ltGVRkxsYAOzeTpqZwk2BncXt3Ugs/RMqpTSQ5Fuq+wBK FRTo2DfmhQ7qbP3Rwh+yg7KLbfJcMVynS27IHyKLotMYuTsCN8IePUWtJUBFO4MhiEpV BWyfzchzv1F/jdccnGpj68zxek9nPl33WdkJ3BD3q5uNxmCdzwCCR/hFhSZtlBqPNz7K gdEz2e1UaJu+UYGhcwukfsrghKjCt+UBGMob88tBaiV/K7WP5T5j0MMeOA1shP76qJb8 /gTw== X-Forwarded-Encrypted: i=1; AJvYcCVfck6Nit1a+W/hIqKB9ua4GZi+64DQiT2OaGcGCACreWG/H7dG5uE/8mgDmujQO5Ocnpeo2KQbRXtLv5cVsJ+Q40E/zsU= X-Gm-Message-State: AOJu0YwBWlyDbnVIf/nvtzVvCteG3hp3td3XNilarqy8neYL2bkgRyb5 +l6leVtSY3GYWiiL7ua/Y2+fxl9k7xDcfVQ2dKVPB0ZoudS2VCvEXdcpz9oD X-Google-Smtp-Source: AGHT+IFpzE7fubzJ5SKp5BlphRT2MYUfpCt8tRp8d2u/bbbZ+wcEADxiJMSmlNzw372kALNKi//gNg== X-Received: by 2002:a17:907:97c7:b0:a55:3707:781d with SMTP id js7-20020a17090797c700b00a553707781dmr4691228ejc.73.1714046628566; Thu, 25 Apr 2024 05:03:48 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8a87:ff00::6223]) by smtp.gmail.com with ESMTPSA id 18-20020a170906309200b00a523b03a1edsm9390924ejv.20.2024.04.25.05.03.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 05:03:48 -0700 (PDT) In-Reply-To: (Okamsn via's message of "Tue, 23 Apr 2024 02:10:42 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283942 Archived-At: On Tue, 23 Apr 2024 at 02:10, Okamsn via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > Hello, > > Currently, the use > > (let ((arr (vector 0 1 2 3 4 5 6))) > (setf (map-elt (cl-subseq arr 3) 0) > 27) > arr) > > expands to > > (let ((arr (vector 0 1 2 3 4 5 6))) > (let* ((v arr)) > (condition-case nil > (with-no-warnings > (map-put! (cl-subseq v 3) 0 27 nil)) > (map-not-inplace > (let* ((new (map-insert (cl-subseq v 3) 0 27))) > (progn > (cl-replace v new :start1 3 :end1 nil) > new)) > 27))) > arr) Since map-put! may raise a not-in-place signal, and I doubt the macro expansion checks for whatever condition it is that leads to that, I would say this use-case is essentially broken.