* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
@ 2024-05-27 21:32 Stefan Kangas
2024-05-28 7:44 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 19+ messages in thread
From: Stefan Kangas @ 2024-05-27 21:32 UTC (permalink / raw)
To: 71235; +Cc: Michael Albinus
I see one tramp test fail on macOS 14.3.1. Details below:
Ran 98 tests, 82 results as expected, 1 unexpected, 15 skipped
(2024-05-27 23:27:48+0200, 89.934240 sec)
1 unexpected results:
FAILED tramp-test17-dired-with-wildcards
Test tramp-test17-dired-with-wildcards backtrace:
signal(user-error ("tramp-test*/*: No files matching wildcard"))
user-error("%s: No files matching wildcard" "tramp-test*/*")
dired-insert-directory(#("/mock:My-MacBook-Pro.local:/var/folders/28/y4qn6tl11_126568wmx_6kpr0000gn/T/tramp-test*/*"
6 31 (tramp-default t)) "-al" nil t t)
dired-readin-insert()
#f(compiled-function () #<bytecode 0x961a9cabc66572>)()
combine-change-calls-1(1 1 #f(compiled-function () #<bytecode
0x961a9cabc66572>))
dired-readin()
dired-internal-noselect(#("/mock:My-MacBook-Pro.local:~/tramp-test*/*"
6 31 (tramp-default t)) nil)
dired-noselect(#("/mock:My-MacBook-Pro.local:/var/folders/28/y4qn6tl11_126568wmx_6kpr0000gn/T/tramp-test*/*"
6 31 (tramp-default t)))
(setq buffer (dired-noselect (expand-file-name "tramp-test*/*"
ert-remote-temporary-file-directory)))
(set-buffer (setq buffer (dired-noselect (expand-file-name
"tramp-test*/*" ert-remote-temporary-file-directory))))
(save-current-buffer (set-buffer (setq buffer (dired-noselect
(expand-file-name "tramp-test*/*"
ert-remote-temporary-file-directory)))) (goto-char (point-min)) (let*
((fn-4565 #'search-forward-regexp) (args-4566 (condition-case err
(list (regexp-quote (file-relative-name tmp-name3
ert-remote-temporary-file-directory))) (error (progn (setq fn-4565
...) (list ... ...)))))) (let ((value-4567
'ert-form-evaluation-aborted-4568)) (let (form-description-4569) (if
(unwind-protect (setq value-4567 (apply fn-4565 args-4566)) (setq
form-description-4569 (nconc ... ... ... ...))
(ert--signal-should-execution form-description-4569)) nil (ert-fail
form-description-4569))) value-4567)) (goto-char (point-min)) (let*
((fn-4570 #'search-forward-regexp) (args-4571 (condition-case err
(list (regexp-quote (file-relative-name tmp-name4
ert-remote-temporary-file-directory))) (error (progn (setq fn-4570
...) (list ... ...)))))) (let ((value-4572
'ert-form-evaluation-aborted-4573)) (let (form-description-4574) (if
(unwind-protect (setq value-4572 (apply fn-4570 args-4571)) (setq
form-description-4574 (nconc ... ... ... ...))
(ert--signal-should-execution form-description-4574)) nil (ert-fail
form-description-4574))) value-4572)))
(progn (make-directory tmp-name1) (write-region "foo" nil tmp-name3)
(let* ((fn-4535 #'file-directory-p) (args-4536 (condition-case err
(list tmp-name1) (error (progn ... ...))))) (let ((value-4537
'ert-form-evaluation-aborted-4538)) (let (form-description-4539) (if
(unwind-protect (setq value-4537 ...) (setq form-description-4539 ...)
(ert--signal-should-execution form-description-4539)) nil (ert-fail
form-description-4539))) value-4537)) (let* ((fn-4540 #'file-exists-p)
(args-4541 (condition-case err (list tmp-name3) (error (progn ...
...))))) (let ((value-4542 'ert-form-evaluation-aborted-4543)) (let
(form-description-4544) (if (unwind-protect (setq value-4542 ...)
(setq form-description-4544 ...) (ert--signal-should-execution
form-description-4544)) nil (ert-fail form-description-4544)))
value-4542)) (make-directory tmp-name2) (write-region "foo" nil
tmp-name4) (let* ((fn-4545 #'file-directory-p) (args-4546
(condition-case err (list tmp-name2) (error (progn ... ...))))) (let
((value-4547 'ert-form-evaluation-aborted-4548)) (let
(form-description-4549) (if (unwind-protect (setq value-4547 ...)
(setq form-description-4549 ...) (ert--signal-should-execution
form-description-4549)) nil (ert-fail form-description-4549)))
value-4547)) (let* ((fn-4550 #'file-exists-p) (args-4551
(condition-case err (list tmp-name4) (error (progn ... ...))))) (let
((value-4552 'ert-form-evaluation-aborted-4553)) (let
(form-description-4554) (if (unwind-protect (setq value-4552 ...)
(setq form-description-4554 ...) (ert--signal-should-execution
form-description-4554)) nil (ert-fail form-description-4554)))
value-4552)) (save-current-buffer (set-buffer (setq buffer
(dired-noselect (expand-file-name "tramp-test*"
ert-remote-temporary-file-directory)))) (goto-char (point-min)) (let*
((fn-4555 #'search-forward-regexp) (args-4556 (condition-case err
(list ...) (error ...)))) (let ((value-4557
'ert-form-evaluation-aborted-4558)) (let (form-description-4559) (if
(unwind-protect ... ... ...) nil (ert-fail form-description-4559)))
value-4557)) (goto-char (point-min)) (let* ((fn-4560
#'search-forward-regexp) (args-4561 (condition-case err (list ...)
(error ...)))) (let ((value-4562 'ert-form-evaluation-aborted-4563))
(let (form-description-4564) (if (unwind-protect ... ... ...) nil
(ert-fail form-description-4564))) value-4562))) (kill-buffer buffer)
(save-current-buffer (set-buffer (setq buffer (dired-noselect
(expand-file-name "tramp-test*/*"
ert-remote-temporary-file-directory)))) (goto-char (point-min)) (let*
((fn-4565 #'search-forward-regexp) (args-4566 (condition-case err
(list ...) (error ...)))) (let ((value-4567
'ert-form-evaluation-aborted-4568)) (let (form-description-4569) (if
(unwind-protect ... ... ...) nil (ert-fail form-description-4569)))
value-4567)) (goto-char (point-min)) (let* ((fn-4570
#'search-forward-regexp) (args-4571 (condition-case err (list ...)
(error ...)))) (let ((value-4572 'ert-form-evaluation-aborted-4573))
(let (form-description-4574) (if (unwind-protect ... ... ...) nil
(ert-fail form-description-4574))) value-4572))) (kill-buffer buffer)
(setq tmp-name3 (expand-file-name "*?" tmp-name1)) (setq tmp-name4
(expand-file-name "[a-z0-9]" tmp-name2)) (write-region "foo" nil
tmp-name3) (let* ((fn-4575 #'file-exists-p) (args-4576 (condition-case
err (list tmp-name3) (error (progn ... ...))))) (let ((value-4577
'ert-form-evaluation-aborted-4578)) (let (form-description-4579) (if
(unwind-protect (setq value-4577 ...) (setq form-description-4579 ...)
(ert--signal-should-execution form-description-4579)) nil (ert-fail
form-description-4579))) value-4577)) (write-region "foo" nil
tmp-name4) (let* ((fn-4580 #'file-exists-p) (args-4581 (condition-case
err (list tmp-name4) (error (progn ... ...))))) (let ((value-4582
'ert-form-evaluation-aborted-4583)) (let (form-description-4584) (if
(unwind-protect (setq value-4582 ...) (setq form-description-4584 ...)
(ert--signal-should-execution form-description-4584)) nil (ert-fail
form-description-4584))) value-4582)) (save-current-buffer (set-buffer
(setq buffer (dired-noselect (expand-file-name "tramp-test*/*"
ert-remote-temporary-file-directory)))) (goto-char (point-min)) (let*
((fn-4585 #'search-forward-regexp) (args-4586 (condition-case err
(list ...) (error ...)))) (let ((value-4587
'ert-form-evaluation-aborted-4588)) (let (form-description-4589) (if
(unwind-protect ... ... ...) nil (ert-fail form-description-4589)))
value-4587)) (goto-char (point-min)) (let* ((fn-4590
#'search-forward-regexp) (args-4591 (condition-case err (list ...)
(error ...)))) (let ((value-4592 'ert-form-evaluation-aborted-4593))
(let (form-description-4594) (if (unwind-protect ... ... ...) nil
(ert-fail form-description-4594))) value-4592))) (kill-buffer buffer))
(unwind-protect (progn (make-directory tmp-name1) (write-region
"foo" nil tmp-name3) (let* ((fn-4535 #'file-directory-p) (args-4536
(condition-case err (list tmp-name1) (error ...)))) (let ((value-4537
'ert-form-evaluation-aborted-4538)) (let (form-description-4539) (if
(unwind-protect ... ... ...) nil (ert-fail form-description-4539)))
value-4537)) (let* ((fn-4540 #'file-exists-p) (args-4541
(condition-case err (list tmp-name3) (error ...)))) (let ((value-4542
'ert-form-evaluation-aborted-4543)) (let (form-description-4544) (if
(unwind-protect ... ... ...) nil (ert-fail form-description-4544)))
value-4542)) (make-directory tmp-name2) (write-region "foo" nil
tmp-name4) (let* ((fn-4545 #'file-directory-p) (args-4546
(condition-case err (list tmp-name2) (error ...)))) (let ((value-4547
'ert-form-evaluation-aborted-4548)) (let (form-description-4549) (if
(unwind-protect ... ... ...) nil (ert-fail form-description-4549)))
value-4547)) (let* ((fn-4550 #'file-exists-p) (args-4551
(condition-case err (list tmp-name4) (error ...)))) (let ((value-4552
'ert-form-evaluation-aborted-4553)) (let (form-description-4554) (if
(unwind-protect ... ... ...) nil (ert-fail form-description-4554)))
value-4552)) (save-current-buffer (set-buffer (setq buffer
(dired-noselect (expand-file-name "tramp-test*"
ert-remote-temporary-file-directory)))) (goto-char (point-min)) (let*
((fn-4555 #'search-forward-regexp) (args-4556 (condition-case err ...
...))) (let ((value-4557 ...)) (let (form-description-4559) (if ...
nil ...)) value-4557)) (goto-char (point-min)) (let* ((fn-4560
#'search-forward-regexp) (args-4561 (condition-case err ... ...)))
(let ((value-4562 ...)) (let (form-description-4564) (if ... nil ...))
value-4562))) (kill-buffer buffer) (save-current-buffer (set-buffer
(setq buffer (dired-noselect (expand-file-name "tramp-test*/*"
ert-remote-temporary-file-directory)))) (goto-char (point-min)) (let*
((fn-4565 #'search-forward-regexp) (args-4566 (condition-case err ...
...))) (let ((value-4567 ...)) (let (form-description-4569) (if ...
nil ...)) value-4567)) (goto-char (point-min)) (let* ((fn-4570
#'search-forward-regexp) (args-4571 (condition-case err ... ...)))
(let ((value-4572 ...)) (let (form-description-4574) (if ... nil ...))
value-4572))) (kill-buffer buffer) (setq tmp-name3 (expand-file-name
"*?" tmp-name1)) (setq tmp-name4 (expand-file-name "[a-z0-9]"
tmp-name2)) (write-region "foo" nil tmp-name3) (let* ((fn-4575
#'file-exists-p) (args-4576 (condition-case err (list tmp-name3)
(error ...)))) (let ((value-4577 'ert-form-evaluation-aborted-4578))
(let (form-description-4579) (if (unwind-protect ... ... ...) nil
(ert-fail form-description-4579))) value-4577)) (write-region "foo"
nil tmp-name4) (let* ((fn-4580 #'file-exists-p) (args-4581
(condition-case err (list tmp-name4) (error ...)))) (let ((value-4582
'ert-form-evaluation-aborted-4583)) (let (form-description-4584) (if
(unwind-protect ... ... ...) nil (ert-fail form-description-4584)))
value-4582)) (save-current-buffer (set-buffer (setq buffer
(dired-noselect (expand-file-name "tramp-test*/*"
ert-remote-temporary-file-directory)))) (goto-char (point-min)) (let*
((fn-4585 #'search-forward-regexp) (args-4586 (condition-case err ...
...))) (let ((value-4587 ...)) (let (form-description-4589) (if ...
nil ...)) value-4587)) (goto-char (point-min)) (let* ((fn-4590
#'search-forward-regexp) (args-4591 (condition-case err ... ...)))
(let ((value-4592 ...)) (let (form-description-4594) (if ... nil ...))
value-4592))) (kill-buffer buffer)) (condition-case nil (progn
(kill-buffer buffer)) (error nil)) (condition-case nil (progn
(delete-directory tmp-name1 'recursive)) (error nil)) (condition-case
nil (progn (delete-directory tmp-name2 'recursive)) (error nil)))
(let* ((tmp-name1 (expand-file-name (tramp--test-make-temp-name nil
quoted))) (tmp-name2 (expand-file-name (tramp--test-make-temp-name nil
quoted))) (tmp-name3 (expand-file-name "foo" tmp-name1)) (tmp-name4
(expand-file-name "bar" tmp-name2))
(ert-remote-temporary-file-directory (funcall (if quoted
#'file-name-quote #'identity) ert-remote-temporary-file-directory))
buffer) (unwind-protect (progn (make-directory tmp-name1)
(write-region "foo" nil tmp-name3) (let* ((fn-4535 #'file-directory-p)
(args-4536 (condition-case err (list tmp-name1) (error ...)))) (let
((value-4537 'ert-form-evaluation-aborted-4538)) (let
(form-description-4539) (if (unwind-protect ... ... ...) nil (ert-fail
form-description-4539))) value-4537)) (let* ((fn-4540 #'file-exists-p)
(args-4541 (condition-case err (list tmp-name3) (error ...)))) (let
((value-4542 'ert-form-evaluation-aborted-4543)) (let
(form-description-4544) (if (unwind-protect ... ... ...) nil (ert-fail
form-description-4544))) value-4542)) (make-directory tmp-name2)
(write-region "foo" nil tmp-name4) (let* ((fn-4545 #'file-directory-p)
(args-4546 (condition-case err (list tmp-name2) (error ...)))) (let
((value-4547 'ert-form-evaluation-aborted-4548)) (let
(form-description-4549) (if (unwind-protect ... ... ...) nil (ert-fail
form-description-4549))) value-4547)) (let* ((fn-4550 #'file-exists-p)
(args-4551 (condition-case err (list tmp-name4) (error ...)))) (let
((value-4552 'ert-form-evaluation-aborted-4553)) (let
(form-description-4554) (if (unwind-protect ... ... ...) nil (ert-fail
form-description-4554))) value-4552)) (save-current-buffer (set-buffer
(setq buffer (dired-noselect (expand-file-name "tramp-test*"
ert-remote-temporary-file-directory)))) (goto-char (point-min)) (let*
((fn-4555 #'search-forward-regexp) (args-4556 (condition-case err ...
...))) (let ((value-4557 ...)) (let (form-description-4559) (if ...
nil ...)) value-4557)) (goto-char (point-min)) (let* ((fn-4560
#'search-forward-regexp) (args-4561 (condition-case err ... ...)))
(let ((value-4562 ...)) (let (form-description-4564) (if ... nil ...))
value-4562))) (kill-buffer buffer) (save-current-buffer (set-buffer
(setq buffer (dired-noselect (expand-file-name "tramp-test*/*"
ert-remote-temporary-file-directory)))) (goto-char (point-min)) (let*
((fn-4565 #'search-forward-regexp) (args-4566 (condition-case err ...
...))) (let ((value-4567 ...)) (let (form-description-4569) (if ...
nil ...)) value-4567)) (goto-char (point-min)) (let* ((fn-4570
#'search-forward-regexp) (args-4571 (condition-case err ... ...)))
(let ((value-4572 ...)) (let (form-description-4574) (if ... nil ...))
value-4572))) (kill-buffer buffer) (setq tmp-name3 (expand-file-name
"*?" tmp-name1)) (setq tmp-name4 (expand-file-name "[a-z0-9]"
tmp-name2)) (write-region "foo" nil tmp-name3) (let* ((fn-4575
#'file-exists-p) (args-4576 (condition-case err (list tmp-name3)
(error ...)))) (let ((value-4577 'ert-form-evaluation-aborted-4578))
(let (form-description-4579) (if (unwind-protect ... ... ...) nil
(ert-fail form-description-4579))) value-4577)) (write-region "foo"
nil tmp-name4) (let* ((fn-4580 #'file-exists-p) (args-4581
(condition-case err (list tmp-name4) (error ...)))) (let ((value-4582
'ert-form-evaluation-aborted-4583)) (let (form-description-4584) (if
(unwind-protect ... ... ...) nil (ert-fail form-description-4584)))
value-4582)) (save-current-buffer (set-buffer (setq buffer
(dired-noselect (expand-file-name "tramp-test*/*"
ert-remote-temporary-file-directory)))) (goto-char (point-min)) (let*
((fn-4585 #'search-forward-regexp) (args-4586 (condition-case err ...
...))) (let ((value-4587 ...)) (let (form-description-4589) (if ...
nil ...)) value-4587)) (goto-char (point-min)) (let* ((fn-4590
#'search-forward-regexp) (args-4591 (condition-case err ... ...)))
(let ((value-4592 ...)) (let (form-description-4594) (if ... nil ...))
value-4592))) (kill-buffer buffer)) (condition-case nil (progn
(kill-buffer buffer)) (error nil)) (condition-case nil (progn
(delete-directory tmp-name1 'recursive)) (error nil)) (condition-case
nil (progn (delete-directory tmp-name2 'recursive)) (error nil))))
(let ((quoted (car tail))) (let* ((tmp-name1 (expand-file-name
(tramp--test-make-temp-name nil quoted))) (tmp-name2 (expand-file-name
(tramp--test-make-temp-name nil quoted))) (tmp-name3 (expand-file-name
"foo" tmp-name1)) (tmp-name4 (expand-file-name "bar" tmp-name2))
(ert-remote-temporary-file-directory (funcall (if quoted
#'file-name-quote #'identity) ert-remote-temporary-file-directory))
buffer) (unwind-protect (progn (make-directory tmp-name1)
(write-region "foo" nil tmp-name3) (let* ((fn-4535 #'file-directory-p)
(args-4536 (condition-case err ... ...))) (let ((value-4537 ...)) (let
(form-description-4539) (if ... nil ...)) value-4537)) (let* ((fn-4540
#'file-exists-p) (args-4541 (condition-case err ... ...))) (let
((value-4542 ...)) (let (form-description-4544) (if ... nil ...))
value-4542)) (make-directory tmp-name2) (write-region "foo" nil
tmp-name4) (let* ((fn-4545 #'file-directory-p) (args-4546
(condition-case err ... ...))) (let ((value-4547 ...)) (let
(form-description-4549) (if ... nil ...)) value-4547)) (let* ((fn-4550
#'file-exists-p) (args-4551 (condition-case err ... ...))) (let
((value-4552 ...)) (let (form-description-4554) (if ... nil ...))
value-4552)) (save-current-buffer (set-buffer (setq buffer
(dired-noselect ...))) (goto-char (point-min)) (let* ((fn-4555 ...)
(args-4556 ...)) (let (...) (let ... ...) value-4557)) (goto-char
(point-min)) (let* ((fn-4560 ...) (args-4561 ...)) (let (...) (let ...
...) value-4562))) (kill-buffer buffer) (save-current-buffer
(set-buffer (setq buffer (dired-noselect ...))) (goto-char
(point-min)) (let* ((fn-4565 ...) (args-4566 ...)) (let (...) (let ...
...) value-4567)) (goto-char (point-min)) (let* ((fn-4570 ...)
(args-4571 ...)) (let (...) (let ... ...) value-4572))) (kill-buffer
buffer) (setq tmp-name3 (expand-file-name "*?" tmp-name1)) (setq
tmp-name4 (expand-file-name "[a-z0-9]" tmp-name2)) (write-region "foo"
nil tmp-name3) (let* ((fn-4575 #'file-exists-p) (args-4576
(condition-case err ... ...))) (let ((value-4577 ...)) (let
(form-description-4579) (if ... nil ...)) value-4577)) (write-region
"foo" nil tmp-name4) (let* ((fn-4580 #'file-exists-p) (args-4581
(condition-case err ... ...))) (let ((value-4582 ...)) (let
(form-description-4584) (if ... nil ...)) value-4582))
(save-current-buffer (set-buffer (setq buffer (dired-noselect ...)))
(goto-char (point-min)) (let* ((fn-4585 ...) (args-4586 ...)) (let
(...) (let ... ...) value-4587)) (goto-char (point-min)) (let*
((fn-4590 ...) (args-4591 ...)) (let (...) (let ... ...) value-4592)))
(kill-buffer buffer)) (condition-case nil (progn (kill-buffer buffer))
(error nil)) (condition-case nil (progn (delete-directory tmp-name1
'recursive)) (error nil)) (condition-case nil (progn (delete-directory
tmp-name2 'recursive)) (error nil)))) (setq tail (cdr tail)))
(while tail (let ((quoted (car tail))) (let* ((tmp-name1
(expand-file-name (tramp--test-make-temp-name nil quoted))) (tmp-name2
(expand-file-name (tramp--test-make-temp-name nil quoted))) (tmp-name3
(expand-file-name "foo" tmp-name1)) (tmp-name4 (expand-file-name "bar"
tmp-name2)) (ert-remote-temporary-file-directory (funcall (if quoted
#'file-name-quote #'identity) ert-remote-temporary-file-directory))
buffer) (unwind-protect (progn (make-directory tmp-name1)
(write-region "foo" nil tmp-name3) (let* ((fn-4535 ...) (args-4536
...)) (let (...) (let ... ...) value-4537)) (let* ((fn-4540 ...)
(args-4541 ...)) (let (...) (let ... ...) value-4542)) (make-directory
tmp-name2) (write-region "foo" nil tmp-name4) (let* ((fn-4545 ...)
(args-4546 ...)) (let (...) (let ... ...) value-4547)) (let* ((fn-4550
...) (args-4551 ...)) (let (...) (let ... ...) value-4552))
(save-current-buffer (set-buffer (setq buffer ...)) (goto-char
(point-min)) (let* (... ...) (let ... ... value-4557)) (goto-char
(point-min)) (let* (... ...) (let ... ... value-4562))) (kill-buffer
buffer) (save-current-buffer (set-buffer (setq buffer ...)) (goto-char
(point-min)) (let* (... ...) (let ... ... value-4567)) (goto-char
(point-min)) (let* (... ...) (let ... ... value-4572))) (kill-buffer
buffer) (setq tmp-name3 (expand-file-name "*?" tmp-name1)) (setq
tmp-name4 (expand-file-name "[a-z0-9]" tmp-name2)) (write-region "foo"
nil tmp-name3) (let* ((fn-4575 ...) (args-4576 ...)) (let (...) (let
... ...) value-4577)) (write-region "foo" nil tmp-name4) (let*
((fn-4580 ...) (args-4581 ...)) (let (...) (let ... ...) value-4582))
(save-current-buffer (set-buffer (setq buffer ...)) (goto-char
(point-min)) (let* (... ...) (let ... ... value-4587)) (goto-char
(point-min)) (let* (... ...) (let ... ... value-4592))) (kill-buffer
buffer)) (condition-case nil (progn (kill-buffer buffer)) (error nil))
(condition-case nil (progn (delete-directory tmp-name1 'recursive))
(error nil)) (condition-case nil (progn (delete-directory tmp-name2
'recursive)) (error nil)))) (setq tail (cdr tail))))
(let ((tail (if (tramp--test-expensive-test-p) '(nil t) '(nil))))
(while tail (let ((quoted (car tail))) (let* ((tmp-name1
(expand-file-name (tramp--test-make-temp-name nil quoted))) (tmp-name2
(expand-file-name (tramp--test-make-temp-name nil quoted))) (tmp-name3
(expand-file-name "foo" tmp-name1)) (tmp-name4 (expand-file-name "bar"
tmp-name2)) (ert-remote-temporary-file-directory (funcall (if quoted
... ...) ert-remote-temporary-file-directory)) buffer) (unwind-protect
(progn (make-directory tmp-name1) (write-region "foo" nil tmp-name3)
(let* (... ...) (let ... ... value-4537)) (let* (... ...) (let ... ...
value-4542)) (make-directory tmp-name2) (write-region "foo" nil
tmp-name4) (let* (... ...) (let ... ... value-4547)) (let* (... ...)
(let ... ... value-4552)) (save-current-buffer (set-buffer ...)
(goto-char ...) (let* ... ...) (goto-char ...) (let* ... ...))
(kill-buffer buffer) (save-current-buffer (set-buffer ...) (goto-char
...) (let* ... ...) (goto-char ...) (let* ... ...)) (kill-buffer
buffer) (setq tmp-name3 (expand-file-name "*?" tmp-name1)) (setq
tmp-name4 (expand-file-name "[a-z0-9]" tmp-name2)) (write-region "foo"
nil tmp-name3) (let* (... ...) (let ... ... value-4577)) (write-region
"foo" nil tmp-name4) (let* (... ...) (let ... ... value-4582))
(save-current-buffer (set-buffer ...) (goto-char ...) (let* ... ...)
(goto-char ...) (let* ... ...)) (kill-buffer buffer)) (condition-case
nil (progn (kill-buffer buffer)) (error nil)) (condition-case nil
(progn (delete-directory tmp-name1 ...)) (error nil)) (condition-case
nil (progn (delete-directory tmp-name2 ...)) (error nil)))) (setq tail
(cdr tail)))))
#f(lambda () [tramp-use-connection-share
tramp-inline-compress-start-size tramp-fuse-unmount-on-cleanup
tramp-fuse-remove-hidden-files tramp-copy-size-limit
comp-warn-primitives ange-ftp-make-backup-files t] (let* ((fn-4505
#'not) (args-4506 (condition-case err ... ...))) (let ((value-4507
...)) (let (form-description-4509) (if ... nil ...)) value-4507))
(let* ((fn-4510 #'tramp--test-enabled) (args-4511 (condition-case err
... ...))) (let ((value-4512 ...)) (let (form-description-4514) (if
... nil ...)) value-4512)) (let* ((fn-4515 #'tramp--test-sh-p)
(args-4516 (condition-case err ... ...))) (let ((value-4517 ...)) (let
(form-description-4519) (if ... nil ...)) value-4517)) (let* ((fn-4520
#'not) (args-4521 (condition-case err ... ...))) (let ((value-4522
...)) (let (form-description-4524) (if ... nil ...)) value-4522))
(let* ((fn-4525 #'not) (args-4526 (condition-case err ... ...))) (let
((value-4527 ...)) (let (form-description-4529) (if ... nil ...))
value-4527)) (let* ((fn-4530 #'not) (args-4531 (condition-case err ...
...))) (let ((value-4532 ...)) (let (form-description-4534) (if ...
nil ...)) value-4532)) (let ((tail (if ... ... ...))) (while tail (let
(...) (let* ... ...) (setq tail ...)))) nil)()
#f(compiled-function () #<bytecode 0x27b3328d8edaeec>)()
handler-bind-1(#f(compiled-function () #<bytecode
0x27b3328d8edaeec>) (error quit) #f(compiled-function (err) #<bytecode
-0x138e5909ca3ae4a1>))
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
:name tramp-test17-dired-with-wildcards :documentation "Check `dired'
with wildcards." :body #f(lambda () ... ... ... ... ... ... ... ...
nil) :most-recent-result ... :expected-result-type :passed :tags nil
:file-name "/Users/user/wip/emacs/test/lisp/net/tramp-tests.el")
:result #s(ert-test-failed :messages "" :should-forms ... :duration
0.358962 :condition ... :backtrace ... :infos nil) :exit-continuation
#f(compiled-function () #<bytecode 0x51ad822b7943>)
:ert-debug-on-error nil))
ert-run-test(#s(ert-test :name tramp-test17-dired-with-wildcards
:documentation "Check `dired' with wildcards." :body #f(lambda ()
[tramp-use-connection-share tramp-inline-compress-start-size
tramp-fuse-unmount-on-cleanup tramp-fuse-remove-hidden-files
tramp-copy-size-limit comp-warn-primitives ange-ftp-make-backup-files
t] (let* (... ...) (let ... ... value-4507)) (let* (... ...) (let ...
... value-4512)) (let* (... ...) (let ... ... value-4517)) (let* (...
...) (let ... ... value-4522)) (let* (... ...) (let ... ...
value-4527)) (let* (... ...) (let ... ... value-4532)) (let (...)
(while tail ...)) nil) :most-recent-result #s(ert-test-failed
:messages "" :should-forms ((... :form ... :value t) (... :form ...
:value t) (... :form ... :value t) (... :form ... :value t) (... :form
... :value t) (... :form ... :value t) (... :form ... :value t) (...
:form ... :value t) (... :form ... :value t) (... :form ... :value t)
(... :form ... :value 237) (... :form ... :value 172)) :duration
0.358962 :condition (user-error "tramp-test*/*: No files matching
wildcard") :backtrace (#s(backtrace-frame :evald t :fun signal :args
... :flags nil :locals nil :buffer nil :pos nil) #s(backtrace-frame
:evald t :fun user-error :args ... :flags nil :locals nil :buffer nil
:pos nil) #s(backtrace-frame :evald t :fun dired-insert-directory
:args ... :flags nil :locals ... :buffer nil :pos nil)
#s(backtrace-frame :evald t :fun dired-readin-insert :args nil :flags
nil :locals nil :buffer nil :pos nil) #s(backtrace-frame :evald t :fun
#f(compiled-function () #<bytecode 0x961a9cabc66572>) :args nil :flags
nil :locals ... :buffer nil :pos nil) #s(backtrace-frame :evald t :fun
combine-change-calls-1 :args ... :flags nil :locals ... :buffer nil
:pos nil) #s(backtrace-frame :evald t :fun dired-readin :args nil
:flags nil :locals nil :buffer nil :pos nil) #s(backtrace-frame :evald
t :fun dired-internal-noselect :args ... :flags nil :locals nil
:buffer nil :pos nil) #s(backtrace-frame :evald t :fun dired-noselect
:args ... :flags nil :locals nil :buffer nil :pos nil)
#s(backtrace-frame :evald nil :fun setq :args ... :flags nil :locals
nil :buffer nil :pos nil) #s(backtrace-frame :evald nil :fun
set-buffer :args ... :flags nil :locals nil :buffer nil :pos nil)
#s(backtrace-frame :evald nil :fun save-current-buffer :args ...
:flags nil :locals nil :buffer nil :pos nil) #s(backtrace-frame :evald
nil :fun progn :args ... :flags nil :locals nil :buffer nil :pos nil)
#s(backtrace-frame :evald nil :fun unwind-protect :args ... :flags nil
:locals nil :buffer nil :pos nil) #s(backtrace-frame :evald nil :fun
let* :args ... :flags nil :locals ... :buffer nil :pos nil)
#s(backtrace-frame :evald nil :fun let :args ... :flags nil :locals
... :buffer nil :pos nil) #s(backtrace-frame :evald nil :fun while
:args ... :flags nil :locals nil :buffer nil :pos nil)
#s(backtrace-frame :evald nil :fun let :args ... :flags nil :locals
... :buffer nil :pos nil) #s(backtrace-frame :evald t :fun #f(lambda
() ... ... ... ... ... ... ... ... nil) :args nil :flags nil :locals
nil :buffer nil :pos nil) #s(backtrace-frame :evald t :fun
#f(compiled-function () #<bytecode 0x27b3328d8edaeec>) :args nil
:flags nil :locals nil :buffer nil :pos nil) #s(backtrace-frame :evald
t :fun handler-bind-1 :args ... :flags nil :locals nil :buffer nil
:pos nil) #s(backtrace-frame :evald t :fun ert--run-test-internal
:args ... :flags nil :locals ... :buffer nil :pos nil)
#s(backtrace-frame :evald t :fun ert-run-test :args #0 :flags nil
:locals ... :buffer nil :pos nil) #s(backtrace-frame :evald t :fun
ert-run-or-rerun-test :args ... :flags nil :locals ... :buffer nil
:pos nil) #s(backtrace-frame :evald t :fun ert-run-tests :args ...
:flags nil :locals ... :buffer nil :pos nil) #s(backtrace-frame :evald
t :fun ert-run-tests-batch :args ... :flags nil :locals nil :buffer
nil :pos nil) #s(backtrace-frame :evald t :fun
ert-run-tests-batch-and-exit :args ... :flags nil :locals nil :buffer
nil :pos nil) #s(backtrace-frame :evald t :fun eval :args ... :flags
nil :locals nil :buffer nil :pos nil) #s(backtrace-frame :evald t :fun
command-line-1 :args ... :flags nil :locals ... :buffer nil :pos nil)
#s(backtrace-frame :evald t :fun command-line :args nil :flags nil
:locals nil :buffer nil :pos nil) #s(backtrace-frame :evald t :fun
normal-top-level :args nil :flags nil :locals nil :buffer nil :pos
nil)) :infos nil) :expected-result-type :passed :tags nil :file-name
"/Users/user/wip/emacs/test/lisp/net/tramp-tests.el"))
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ...
:test-map #<hash-table eql 98/98 0x41dbee75 ...> :test-results ...
:test-start-times ... :test-end-times ... :passed-expected 29
:passed-unexpected 0 :failed-expected 0 :failed-unexpected 1 :skipped
1 :start-time ... :end-time nil :aborted-p nil ...) #s(ert-test :name
tramp-test17-dired-with-wildcards :documentation "Check `dired' with
wildcards." :body #f(lambda () ... ... ... ... ... ... ... ... nil)
:most-recent-result ... :expected-result-type :passed :tags nil
:file-name "/Users/user/wip/emacs/test/lisp/net/tramp-tests.el")
#f(compiled-function (event-type &rest event-args) #<bytecode
-0x1f51d8eb74ff2eab>))
ert-run-tests((not (or (tag :unstable) (tag :nativecomp)))
#f(compiled-function (event-type &rest event-args) #<bytecode
-0x1f51d8eb74ff2eab>) nil)
ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativecomp))))
eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag
:nativecomp)))) t)
command-line-1(("-L" ":." "-l" "ert" "--eval" "(setq
treesit-extra-load-path '(\"/Users/user/.emacs.d/tree-sitter\"))"
"--eval" "(setq ert-batch-backtrace-right-margin 9999)" "-l"
"lisp/net/tramp-tests.el" "--eval" "(ert-run-tests-batch-and-exit
(quote (not (or (tag :unstable) (tag :nativecomp)))))"))
command-line()
normal-top-level()
Test tramp-test17-dired-with-wildcards condition:
(user-error "tramp-test*/*: No files matching wildcard")
FAILED 31/98 tramp-test17-dired-with-wildcards (0.358962 sec) at
lisp/net/tramp-tests.el:3492
In GNU Emacs 30.0.50 (build 1, aarch64-apple-darwin23.3.0, NS
appkit-2487.40 Version 14.3.1 (Build 23D60)) of 2024-05-27 built on
My-MacBook-Pro.local
Repository revision: a2ada9094824a673b441f082857c3e77347a1ff8
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2487
System Description: macOS 14.3.1
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-05-27 21:32 bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards Stefan Kangas
@ 2024-05-28 7:44 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-28 22:56 ` Stefan Kangas
0 siblings, 1 reply; 19+ messages in thread
From: Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-05-28 7:44 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 71235
[-- Attachment #1: Type: text/plain, Size: 404 bytes --]
Stefan Kangas <stefankangas@gmail.com> writes:
Hi Stefan,
> I see one tramp test fail on macOS 14.3.1. Details below:
>
> Ran 98 tests, 82 results as expected, 1 unexpected, 15 skipped
> (2024-05-27 23:27:48+0200, 89.934240 sec)
>
> 1 unexpected results:
> FAILED tramp-test17-dired-with-wildcards
Could you pls instrument the test, and run it again? See appended patch.
Best regards, Michael.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 986 bytes --]
diff --git a/test/lisp/net/tramp-tests.el b/test/lisp/net/tramp-tests.el
index 2c61efb04d8..22758b07f0c 100644
--- a/test/lisp/net/tramp-tests.el
+++ b/test/lisp/net/tramp-tests.el
@@ -3502,6 +3502,7 @@ tramp-test17-dired-with-wildcards
;; Wildcards are not supported with "docker cp ..." or "podman cp ...".
(skip-unless (not (tramp--test-container-oob-p)))
+ (tramp--test-instrument-test-case 10
(dolist (quoted (if (tramp--test-expensive-test-p) '(nil t) '(nil)))
(let* ((tmp-name1
(expand-file-name (tramp--test-make-temp-name nil quoted)))
@@ -3603,7 +3604,7 @@ tramp-test17-dired-with-wildcards
;; Cleanup.
(ignore-errors (kill-buffer buffer))
(ignore-errors (delete-directory tmp-name1 'recursive))
- (ignore-errors (delete-directory tmp-name2 'recursive))))))
+ (ignore-errors (delete-directory tmp-name2 'recursive)))))))
;; The following test is inspired by Bug#45691.
(ert-deftest tramp-test17-insert-directory-one-file ()
^ permalink raw reply related [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-05-28 7:44 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-05-28 22:56 ` Stefan Kangas
2024-05-29 7:28 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 12:12 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 2 replies; 19+ messages in thread
From: Stefan Kangas @ 2024-05-28 22:56 UTC (permalink / raw)
To: Michael Albinus; +Cc: 71235
Michael Albinus <michael.albinus@gmx.de> writes:
>> I see one tramp test fail on macOS 14.3.1. Details below:
>>
>> Ran 98 tests, 82 results as expected, 1 unexpected, 15 skipped
>> (2024-05-27 23:27:48+0200, 89.934240 sec)
>>
>> 1 unexpected results:
>> FAILED tramp-test17-dired-with-wildcards
>
> Could you pls instrument the test, and run it again? See appended patch.
I've sent you the logs off-list.
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-05-28 22:56 ` Stefan Kangas
@ 2024-05-29 7:28 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 20:51 ` Stefan Kangas
2024-05-30 12:12 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 1 reply; 19+ messages in thread
From: Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-05-29 7:28 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 71235
Stefan Kangas <stefankangas@gmail.com> writes:
Hi Stefan,
>> Could you pls instrument the test, and run it again? See appended patch.
>
> I've sent you the logs off-list.
Sorry, that message was deleted in my Spam folder. Could you, pls,
resend the message?
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-05-29 7:28 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-05-29 20:51 ` Stefan Kangas
2024-05-30 8:54 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 19+ messages in thread
From: Stefan Kangas @ 2024-05-29 20:51 UTC (permalink / raw)
To: Michael Albinus; +Cc: 71235
Michael Albinus <michael.albinus@gmx.de> writes:
>> I've sent you the logs off-list.
>
> Sorry, that message was deleted in my Spam folder. Could you, pls,
> resend the message?
I've resent it. Please let me know if you still can't find it.
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-05-29 20:51 ` Stefan Kangas
@ 2024-05-30 8:54 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 19+ messages in thread
From: Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-05-30 8:54 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 71235
Stefan Kangas <stefankangas@gmail.com> writes:
Hi Stefan,
>>> I've sent you the logs off-list.
>>
>> Sorry, that message was deleted in my Spam folder. Could you, pls,
>> resend the message?
>
> I've resent it. Please let me know if you still can't find it.
I've got it now. Still in the Spam folder, but I was prepared this
time :-)
I have already seen the error in the log, but I have no clue yet where
it comes from. Needs further checks.
Best regards, Michael.
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-05-28 22:56 ` Stefan Kangas
2024-05-29 7:28 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-05-30 12:12 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31 9:22 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 10:19 ` Stefan Kangas
1 sibling, 2 replies; 19+ messages in thread
From: Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-05-30 12:12 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 71235
Stefan Kangas <stefankangas@gmail.com> writes:
Hi Stefan,
>>> I see one tramp test fail on macOS 14.3.1. Details below:
>>>
>>> Ran 98 tests, 82 results as expected, 1 unexpected, 15 skipped
>>> (2024-05-27 23:27:48+0200, 89.934240 sec)
>>>
>>> 1 unexpected results:
>>> FAILED tramp-test17-dired-with-wildcards
>>
>> Could you pls instrument the test, and run it again? See appended patch.
>
> I've sent you the logs off-list.
Thanks for this. The problem is obvious in the log:
--8<---------------cut here---------------start------------->8---
00:52:56.390327 tramp-send-command (6) # ( cd /var/folders/28/y4qn6tl11_126568wmx_6kpr0000gn/T/ && env INSIDE_EMACS\=30.0.50\,tramp\:2.7.1-pre /bin/sh -c gls\ -d\ -al\ tramp-test\*/\* </dev/null; echo tramp_exit_status $? )
00:52:56.394295 tramp-wait-for-regexp (6) #
/bin/sh: gls: command not found
tramp_exit_status 127
///75ffbd7d44c24c99d4107a0eba33363e#$
--8<---------------cut here---------------end--------------->8---
However, Tramp hasn't decided to use gls on its own. Debugging the test
case, it looks like it comes from dired-insert-directory:
--8<---------------cut here---------------start------------->8---
;; Expand directory wildcards and fill file-list.
(let ((dir-wildcard (and (null file-list) wildcard
(insert-directory-wildcard-in-dir-p dir))))
(cond ((and dir-wildcard (files--use-insert-directory-program-p))
(setq switches (concat "-d " switches))
(let* ((default-directory (car dir-wildcard))
(script (format "%s %s %s"
insert-directory-program
switches (cdr dir-wildcard)))
(sh (or (and remotep "/bin/sh")
(executable-find shell-file-name)
(executable-find "sh")))
(switch (if remotep "-c" shell-command-switch)))
;; Enable globstar
(when-let ((globstar dired-maybe-use-globstar)
(enable-it
(assoc-default
(file-truename sh) dired-enable-globstar-in-shell
(lambda (reg shell) (string-match reg shell)))))
(setq script (format "%s; %s" enable-it script)))
(unless
(zerop
(process-file sh nil (current-buffer) nil switch script))
(user-error
"%s: No files matching wildcard" (cdr dir-wildcard)))
(insert-directory-clean (point) switches)))
--8<---------------cut here---------------end--------------->8---
'script' is a formatted string, which includes
'insert-directory-program'. And that user option tells us
--8<---------------cut here---------------start------------->8---
Absolute or relative name of the ‘ls’-like program.
This is used by ‘insert-directory’ and ‘dired-insert-directory’
(thus, also by ‘dired’). For Dired, this should ideally point to
GNU ls, or another version of ls that supports the "--dired"
flag. See ‘dired-use-ls-dired’.
On GNU/Linux and other capable systems, the default is "ls".
On *BSD and macOS systems, the default "ls" does not support
the "--dired" flag. Therefore, the default is to use the
"gls" executable on such machines, if it exists. This means
that there should normally be no need to customize this when
installing GNU coreutils using something like ports or Homebrew.
--8<---------------cut here---------------end--------------->8---
So I guess 'insert-directory-program' is "gls" in your case, but Tramp
doesn't find it. Where is it installed? What does '(executable-find "gls")'
return on your machine?
Best regards, Michael.
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-05-30 12:12 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-05-31 9:22 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 10:37 ` Stefan Kangas
2024-06-02 10:19 ` Stefan Kangas
1 sibling, 1 reply; 19+ messages in thread
From: Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-05-31 9:22 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 71235
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Stefan,
> So I guess 'insert-directory-program' is "gls" in your case, but Tramp
> doesn't find it. Where is it installed? What does '(executable-find "gls")'
> return on your machine?
Could you pls check, whether the appended patch fixes the problem?
Best regards, Michael.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 875 bytes --]
diff --git a/lisp/dired.el b/lisp/dired.el
index f2a75df6ef1..c51e5e42c29 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -1710,9 +1710,10 @@ dired-insert-directory
(cond ((and dir-wildcard (files--use-insert-directory-program-p))
(setq switches (concat "-d " switches))
(let* ((default-directory (car dir-wildcard))
+ (ls (or (and remotep "ls")
+ insert-directory-program))
(script (format "%s %s %s"
- insert-directory-program
- switches (cdr dir-wildcard)))
+ ls switches (cdr dir-wildcard)))
(sh (or (and remotep "/bin/sh")
(executable-find shell-file-name)
(executable-find "sh")))
^ permalink raw reply related [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-05-30 12:12 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31 9:22 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-06-02 10:19 ` Stefan Kangas
2024-06-02 10:33 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
1 sibling, 1 reply; 19+ messages in thread
From: Stefan Kangas @ 2024-06-02 10:19 UTC (permalink / raw)
To: Michael Albinus; +Cc: 71235
Michael Albinus <michael.albinus@gmx.de> writes:
> So I guess 'insert-directory-program' is "gls" in your case, but Tramp
> doesn't find it. Where is it installed? What does '(executable-find "gls")'
> return on your machine?
(executable-find "gls")
=> "/opt/homebrew/bin/gls"
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-06-02 10:19 ` Stefan Kangas
@ 2024-06-02 10:33 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 11:04 ` Stefan Kangas
0 siblings, 1 reply; 19+ messages in thread
From: Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-06-02 10:33 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 71235
Stefan Kangas <stefankangas@gmail.com> writes:
Hi Stefan,
>> So I guess 'insert-directory-program' is "gls" in your case, but Tramp
>> doesn't find it. Where is it installed? What does '(executable-find "gls")'
>> return on your machine?
>
> (executable-find "gls")
> => "/opt/homebrew/bin/gls"
Hmm. Should we add "/opt/homebrew/bin" to the default
tramp-remote-path? It looks very special, even on macOS.
OTOH, we have directories like "/local/freeware/bin", "/local/gnu/bin",
"/usr/freeware/bin", "/usr/pkg/bin", "/usr/contrib/bin", "/opt/bin",
"/opt/sbin" and "/opt/local/bin" there, which are also special.
Best regards, Michael.
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-05-31 9:22 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-06-02 10:37 ` Stefan Kangas
0 siblings, 0 replies; 19+ messages in thread
From: Stefan Kangas @ 2024-06-02 10:37 UTC (permalink / raw)
To: Michael Albinus; +Cc: 71235
Michael Albinus <michael.albinus@gmx.de> writes:
> Could you pls check, whether the appended patch fixes the problem?
It does, thank you.
Ran 98 tests, 83 results as expected, 0 unexpected, 15 skipped
(2024-06-02 12:22:29+0200, 81.888878 sec)
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-06-02 10:33 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-06-02 11:04 ` Stefan Kangas
2024-06-02 11:07 ` Stefan Kangas
` (2 more replies)
0 siblings, 3 replies; 19+ messages in thread
From: Stefan Kangas @ 2024-06-02 11:04 UTC (permalink / raw)
To: Michael Albinus; +Cc: Gerd Möllmann, 71235, Mattias Engdegård
Michael Albinus <michael.albinus@gmx.de> writes:
>> (executable-find "gls")
>> => "/opt/homebrew/bin/gls"
>
> Hmm. Should we add "/opt/homebrew/bin" to the default
> tramp-remote-path? It looks very special, even on macOS.
>
> OTOH, we have directories like "/local/freeware/bin", "/local/gnu/bin",
> "/usr/freeware/bin", "/usr/pkg/bin", "/usr/contrib/bin", "/opt/bin",
> "/opt/sbin" and "/opt/local/bin" there, which are also special.
AFAIK, this is the default location where Homebrew (https://brew.sh/)
puts binaries, at least on new installations. (The Homebrew directory
structure has changed slightly over the years, but I don't know if this
is one of them since I only noticed it those changes passing.)
I think it might make sense to add it to `tramp-remote-path`, but I'm
not familiar enough with Tramp to understand all the implications of
doing so. I'm copying in Mattias and Gerd, who I believe are using
macOS, in case they have anything to add.
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-06-02 11:04 ` Stefan Kangas
@ 2024-06-02 11:07 ` Stefan Kangas
2024-06-02 13:14 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 14:03 ` Gerd Möllmann
2 siblings, 0 replies; 19+ messages in thread
From: Stefan Kangas @ 2024-06-02 11:07 UTC (permalink / raw)
To: Michael Albinus; +Cc: Gerd Möllmann, 71235, Mattias Engdegård
Stefan Kangas <stefankangas@gmail.com> writes:
> AFAIK, this is the default location where Homebrew (https://brew.sh/)
> puts binaries, at least on new installations. (The Homebrew directory
> structure has changed slightly over the years, but I don't know if this
> is one of them since I only noticed it those changes passing.)
That last sentence should read:
The Homebrew directory structure has changed slightly over the years,
but I don't know if this directory changed, since I only noticed
the changes in passing.
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-06-02 11:04 ` Stefan Kangas
2024-06-02 11:07 ` Stefan Kangas
@ 2024-06-02 13:14 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 17:51 ` Stefan Kangas
2024-06-02 14:03 ` Gerd Möllmann
2 siblings, 1 reply; 19+ messages in thread
From: Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-06-02 13:14 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Gerd Möllmann, Mattias Engdegård, 71235-done
Version: 30.1
Stefan Kangas <stefankangas@gmail.com> writes:
Hi Stefan,
>>> (executable-find "gls")
>>> => "/opt/homebrew/bin/gls"
>>
>> Hmm. Should we add "/opt/homebrew/bin" to the default
>> tramp-remote-path? It looks very special, even on macOS.
>>
>> OTOH, we have directories like "/local/freeware/bin", "/local/gnu/bin",
>> "/usr/freeware/bin", "/usr/pkg/bin", "/usr/contrib/bin", "/opt/bin",
>> "/opt/sbin" and "/opt/local/bin" there, which are also special.
>
> AFAIK, this is the default location where Homebrew (https://brew.sh/)
> puts binaries, at least on new installations. (The Homebrew directory
> structure has changed slightly over the years, but I don't know if this
> is one of them since I only noticed it those changes passing.)
Finally, I have done both: Adding "/opt/homebrew/bin" to
tramp-remote-path, and applying the patch to dired-insert-directory I've
shown the other message.
Pushed to master, and closing the bug.
Best regards, Michael.
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-06-02 11:04 ` Stefan Kangas
2024-06-02 11:07 ` Stefan Kangas
2024-06-02 13:14 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-06-02 14:03 ` Gerd Möllmann
2024-06-02 14:23 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2 siblings, 1 reply; 19+ messages in thread
From: Gerd Möllmann @ 2024-06-02 14:03 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 71235, Mattias Engdegård, Michael Albinus
Stefan Kangas <stefankangas@gmail.com> writes:
> Michael Albinus <michael.albinus@gmx.de> writes:
>
>>> (executable-find "gls")
>>> => "/opt/homebrew/bin/gls"
>>
>> Hmm. Should we add "/opt/homebrew/bin" to the default
>> tramp-remote-path? It looks very special, even on macOS.
>>
>> OTOH, we have directories like "/local/freeware/bin", "/local/gnu/bin",
>> "/usr/freeware/bin", "/usr/pkg/bin", "/usr/contrib/bin", "/opt/bin",
>> "/opt/sbin" and "/opt/local/bin" there, which are also special.
>
> AFAIK, this is the default location where Homebrew (https://brew.sh/)
> puts binaries, at least on new installations. (The Homebrew directory
> structure has changed slightly over the years, but I don't know if this
> is one of them since I only noticed it those changes passing.)
>
> I think it might make sense to add it to `tramp-remote-path`, but I'm
> not familiar enough with Tramp to understand all the implications of
> doing so. I'm copying in Mattias and Gerd, who I believe are using
> macOS, in case they have anything to add.
Homebrew uses different directories depending on if it's on a mac with
x64 or arm64. I have both, and find the easiest thing to do is to use
the brew shellenv command in my .zshenv to set up things. (I have a
common dotfles setup for my machines.)
/Users/gerd % brew shellenv
export HOMEBREW_PREFIX="/opt/homebrew";
export HOMEBREW_CELLAR="/opt/homebrew/Cellar";
export HOMEBREW_REPOSITORY="/opt/homebrew";
export PATH="/opt/homebrew/bin:/opt/homebrew/sbin${PATH+:$PATH}";
export MANPATH="/opt/homebrew/share/man${MANPATH+:$MANPATH}:";
export INFOPATH="/opt/homebrew/share/info:${INFOPATH:-}";
Then, I'm using exec-path-from-shell in my init.el to get the shell
environment into Emacs, even when started from Emacs.app. Starting an
.app bundle doesn't involve the shell, so one has to do something.
Works like a charm with everything I use, including things like Magit
over tramp, and so on.
(If you are using zsh from Homebrew and not the one from macOS, you
might want to call connection-local-set-profile-variables or something
to get the right zsh.)
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-06-02 14:03 ` Gerd Möllmann
@ 2024-06-02 14:23 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 14:46 ` Gerd Möllmann
0 siblings, 1 reply; 19+ messages in thread
From: Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-06-02 14:23 UTC (permalink / raw)
To: Gerd Möllmann; +Cc: 71235, Mattias Engdegård, Stefan Kangas
Gerd Möllmann <gerd.moellmann@gmail.com> writes:
Hi Gerd,
> Homebrew uses different directories depending on if it's on a mac with
> x64 or arm64. I have both, and find the easiest thing to do is to use
> the brew shellenv command in my .zshenv to set up things. (I have a
> common dotfles setup for my machines.)
>
> /Users/gerd % brew shellenv
> export HOMEBREW_PREFIX="/opt/homebrew";
> export HOMEBREW_CELLAR="/opt/homebrew/Cellar";
> export HOMEBREW_REPOSITORY="/opt/homebrew";
> export PATH="/opt/homebrew/bin:/opt/homebrew/sbin${PATH+:$PATH}";
> export MANPATH="/opt/homebrew/share/man${MANPATH+:$MANPATH}:";
> export INFOPATH="/opt/homebrew/share/info:${INFOPATH:-}";
>
> Then, I'm using exec-path-from-shell in my init.el to get the shell
> environment into Emacs, even when started from Emacs.app. Starting an
> .app bundle doesn't involve the shell, so one has to do something.
What's exec-path-from-shell? ELPA package?
> Works like a charm with everything I use, including things like Magit
> over tramp, and so on.
TL;DR: I should also add /opt/homebrew/sbin to tramp-remote-path, right?
Best regards, Michael.
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-06-02 14:23 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-06-02 14:46 ` Gerd Möllmann
2024-06-02 14:55 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 19+ messages in thread
From: Gerd Möllmann @ 2024-06-02 14:46 UTC (permalink / raw)
To: Michael Albinus; +Cc: 71235, Mattias Engdegård, Stefan Kangas
Michael Albinus <michael.albinus@gmx.de> writes:
> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>
> Hi Gerd,
>
>> Then, I'm using exec-path-from-shell in my init.el to get the shell
>> environment into Emacs, even when started from Emacs.app. Starting an
>> .app bundle doesn't involve the shell, so one has to do something.
>
> What's exec-path-from-shell? ELPA package?
ELPA or MELPA, yes.
>> Works like a charm with everything I use, including things like Magit
>> over tramp, and so on.
>
> TL;DR: I should also add /opt/homebrew/sbin to tramp-remote-path, right?
Yes :-)
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-06-02 14:46 ` Gerd Möllmann
@ 2024-06-02 14:55 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 19+ messages in thread
From: Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-06-02 14:55 UTC (permalink / raw)
To: Gerd Möllmann; +Cc: 71235, Mattias Engdegård, Stefan Kangas
Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>> TL;DR: I should also add /opt/homebrew/sbin to tramp-remote-path, right?
>
> Yes :-)
Done.
Best regards, Michael.
^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards
2024-06-02 13:14 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-06-02 17:51 ` Stefan Kangas
0 siblings, 0 replies; 19+ messages in thread
From: Stefan Kangas @ 2024-06-02 17:51 UTC (permalink / raw)
To: Michael Albinus; +Cc: 71235
Michael Albinus <michael.albinus@gmx.de> writes:
> Pushed to master, and closing the bug.
Thanks!
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2024-06-02 17:51 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-27 21:32 bug#71235: Failing test on macOS: tramp-test17-dired-with-wildcards Stefan Kangas
2024-05-28 7:44 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-28 22:56 ` Stefan Kangas
2024-05-29 7:28 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 20:51 ` Stefan Kangas
2024-05-30 8:54 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 12:12 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31 9:22 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 10:37 ` Stefan Kangas
2024-06-02 10:19 ` Stefan Kangas
2024-06-02 10:33 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 11:04 ` Stefan Kangas
2024-06-02 11:07 ` Stefan Kangas
2024-06-02 13:14 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 17:51 ` Stefan Kangas
2024-06-02 14:03 ` Gerd Möllmann
2024-06-02 14:23 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 14:46 ` Gerd Möllmann
2024-06-02 14:55 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).