From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Suhail Singh Newsgroups: gmane.emacs.bugs Subject: bug#73046: 29.4; Emacs 100% CPU usage for several seconds when opening dired buffer over TRAMP Date: Sun, 08 Sep 2024 11:34:18 -0400 Message-ID: <87frqai2h1.fsf@gmail.com> References: <87o75241qh.fsf@gmail.com> <86plpi2ixa.fsf@gnu.org> <87seudke20.fsf@gmail.com> <8634md2vc2.fsf@gnu.org> <87h6asrk42.fsf@gmx.de> <86a5gk28ht.fsf@gnu.org> <87le0450x8.fsf@gmx.de> <865xr8228d.fsf@gnu.org> <87jzfofzcl.fsf@gmail.com> <8634mc1ty0.fsf@gnu.org> <87h6asl3hl.fsf@gmail.com> <87frqbk0fx.fsf@gmx.de> <87plpf2vnx.fsf@gmail.com> <87wmjmidyt.fsf@gmx.de> <87mskii3m5.fsf@gmail.com> <87ed5ugokg.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38557"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Suhail Singh , 73046@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 08 17:36:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1snJxb-0009nf-KC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Sep 2024 17:36:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1snJxJ-0003KR-Cb; Sun, 08 Sep 2024 11:36:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1snJxI-0003KC-7A for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 11:36:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1snJxH-0004gt-UV for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 11:35:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=8yVzEZynGcXm4w+ruNeMya7w/frfDcNKyWcqdDxLM00=; b=AvFFonlEAn71YXZprXiiqlkJkBUgN8twVO2WHaA1KkWGMmUs/gA2tXLANcjSOkSlXz1hY2bDcz9JslqImbGd3CjQhdTg5ukBvgfpkGgjekN5+uQQ0dr1wd432N62GvkDoBAt3FTS3NQGm+uFEEfWySzMacZ0kA4HDDoZx7PTZs1XW/ICcDw6UyP9HG3Lyf26fpDTOF+KuOLhcSnN+qBIfAxXpVZTYll9d/3eEsgaZFvXLNArTr8M+D3STv4GxRbfVaDlqS+UYoZ9VrjBBQ1/PFvu8jk9v+CJVF3HuaE7sC+pBDHnRjFChOr36TJsKmVgJZsSblrgdmZffpWw+xC29g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1snJxK-0003Ly-0s for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 11:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Suhail Singh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Sep 2024 15:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73046 X-GNU-PR-Package: emacs Original-Received: via spool by 73046-submit@debbugs.gnu.org id=B73046.172580974012861 (code B ref 73046); Sun, 08 Sep 2024 15:36:01 +0000 Original-Received: (at 73046) by debbugs.gnu.org; 8 Sep 2024 15:35:40 +0000 Original-Received: from localhost ([127.0.0.1]:59910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snJwy-0003LM-CW for submit@debbugs.gnu.org; Sun, 08 Sep 2024 11:35:40 -0400 Original-Received: from mail-qv1-f66.google.com ([209.85.219.66]:54729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snJww-0003L7-DJ for 73046@debbugs.gnu.org; Sun, 08 Sep 2024 11:35:39 -0400 Original-Received: by mail-qv1-f66.google.com with SMTP id 6a1803df08f44-6c53bc6f9faso4455346d6.1 for <73046@debbugs.gnu.org>; Sun, 08 Sep 2024 08:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725809670; x=1726414470; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8yVzEZynGcXm4w+ruNeMya7w/frfDcNKyWcqdDxLM00=; b=D4edcu3qIBpOsF6QJVaFSseH6P/OZTg9JP9m0DZkh8tYRsTWp56xQcqrGP9n6/0g0l Ie0ee3hkowpZZP3bUQNMuCiiQS2I/XSfwl5rnt9cDaDrgeu7n1yevJCDCUnFDCa9FScF RbgdCf8cU2YitonM4d1/tmizvkEYYkMfV/mp1RE6VUssHcabDi/BUwDOmF7QGTxhdKAO /B/2er7rU/eDVk+Zz1jpR9ulSDYe4zQ5lTz/Fx8Er4c+x9wcimP9MM4WM8l7U4VmJAGQ /qY+XxEUz8X1eHmA2BURAU/2K62z/RdJ+8+Rs2PEikbyu4QWO2t+8LuVu17GKYQOWIXJ bPFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725809670; x=1726414470; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8yVzEZynGcXm4w+ruNeMya7w/frfDcNKyWcqdDxLM00=; b=qRYb5glZB7H0SNpEqTYUQJ/e785lRqQi1HT2pPII3yAzyJ24VtNKNurQYmBMc41DVi 5siBN3pZKggkYCu5lAWfOQIdQm7ZZqvZUVLoByQbM0t4YDSLxBHs3svisqvXWlYiJO8T jn+NFIM0P4jAvaSp7scYq+wmZXO/NK71OkQ8Oe5cIxOIsmZKqEzwUhbTXaR9zaIPTJAE tFtyKEo76McNFispGrR3jgVjBAV3oU3vx6G6V8+hT98XKDLdOl8gNX0OQI5+4EGFuhJ5 iMTy4hWaSfxgfbPqjOyCaCPEowKx6OZfdPIj8KXNIgHLcowZutS/c9mjEHyXnagyQBOu uomw== X-Forwarded-Encrypted: i=1; AJvYcCULu1YJKNnBO3tv58tRenlRHcZ1+yr/oGIDXqslEImZgYhzsCCX6NL+i6/TVan55P62S3inxg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyYIDlzWk+UfWu2BiC50leKQHSkVVypkyAjYEiYqPHHzNdXHLyR 3eAZGw0jQNaWTNlhmLmyPlEiuDb7iv+ZkY0/5y7GQpyWAf5/wWJ4lSLV04iN X-Google-Smtp-Source: AGHT+IFT9iGouv8QvtOyC1kA29JvdGq77SUyql/sHmqZQND0gxhwRzOUfv1zIqD1YJMyuVXOijaIAA== X-Received: by 2002:a05:6214:460b:b0:6c1:6a94:52d2 with SMTP id 6a1803df08f44-6c5282fdf96mr116332546d6.13.1725809669817; Sun, 08 Sep 2024 08:34:29 -0700 (PDT) Original-Received: from gnus ([65.94.70.53]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6c5347749b7sm13385116d6.125.2024.09.08.08.34.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 08:34:29 -0700 (PDT) In-Reply-To: <87ed5ugokg.fsf@gmx.de> (Michael Albinus's message of "Sun, 08 Sep 2024 17:19:59 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291463 Archived-At: Michael Albinus writes: >>> ;; Symbolic link to a non-directory. >>> ... >>> + "\\(.+-> ?\\)\\(.+\\)" end t)))))) >> >> Minor nitpick: given the comment for this section (which seems to >> suggest this only applies to symlinks to non-directories), wouldn't it >> be "better" to simply have something like below instead for the if-then >> case? I.e., a separate entry in dired-font-lock-keywords for the >> failsafe. >> >> #+begin_src emacs-lisp >> ;; Generic face for symbolic links >> (list dired-re-sym >> (when (not (connection-local-value dired-check-symlinks)) >> '(".+" (dired-move-to-filename) nil (0 dired-symlink-face)))) >> #+end_src >> >> This is essentially what I have in my config today, and seems to behave >> as expected. > > Possible, but I don't see that one version is "better" or "worse" than > the other. Understood. > So I don't see a need to change it. The comment ";; Symbolic link to a non-directory." should probably be updated in that case, right? Apologies for the noise, in case I have misunderstood the patch. I should be able to test out the patch later this coming week. In case that would be helpful, please let me know. Thank you for adding this. -- Suhail