From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dan Jacobson Newsgroups: gmane.emacs.bugs Subject: bug#73635: dired-do-query-replace-regexp should check if files are selected first Date: Sat, 05 Oct 2024 11:44:56 +0800 Message-ID: <87frpbb4cn.3.fsf@jidanni.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7043"; mail-complaints-to="usenet@ciao.gmane.io" To: 73635@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 05 05:46:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1swvkI-0001hp-2h for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Oct 2024 05:46:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1swvk1-00011n-Gn; Fri, 04 Oct 2024 23:46:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swvjy-00011S-HB for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 23:45:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1swvjy-0002uZ-8U for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 23:45:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=MB3609t/RgX3OZ8DM2VfhRgBxuhvgtplaxwH7EwhUKs=; b=cm8/tNS0JLWcgzWlLckDvKMGQ7vdqY+xNd/TcOKHsNh8zD2LKh+kLKcyhKpqaC/37OED2rM7+EtyM5XsJmoZyN+O3MkjT6ycRgGrSIhdCh7z8S/Js4dEVIVfEh6nnm6f202nqrMyvqPTHckEo0RXxdj9cD5lv22tEQVUSqjn4V0noDnT7lT9wJdrw+swPvbl3gAIwaKV9e/KfO1KhEW9VLczFwFJeZ7YIW4jjdRLneYPlcjDes8DweSq4NWy3/UsIXL36V5x/q8lgJdbM9LFwKV/cV9MtZ3BoyQHIiuW07cwiN3+K+f7EnU0PoAgWrEsiiUYIaXK4Hhzq/8jximv1A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1swvk2-00010U-0D for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 23:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dan Jacobson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Oct 2024 03:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73635 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.17280999113603 (code B ref -1); Sat, 05 Oct 2024 03:46:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Oct 2024 03:45:11 +0000 Original-Received: from localhost ([127.0.0.1]:37094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swvjD-0000w3-E5 for submit@debbugs.gnu.org; Fri, 04 Oct 2024 23:45:11 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:58028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1swvjB-0000sg-3M for submit@debbugs.gnu.org; Fri, 04 Oct 2024 23:45:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swvj6-0000tK-GT for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 23:45:04 -0400 Original-Received: from iguana.tulip.relay.mailchannels.net ([23.83.218.253]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1swvj4-0002bD-Lc for bug-gnu-emacs@gnu.org; Fri, 04 Oct 2024 23:45:04 -0400 X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 07914181D38 for ; Sat, 5 Oct 2024 03:44:59 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a207.dreamhost.com (100-96-87-216.trex-nlb.outbound.svc.cluster.local [100.96.87.216]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 92DBB181F41 for ; Sat, 5 Oct 2024 03:44:58 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1728099898; a=rsa-sha256; cv=none; b=HPq5ToP5d+RwWGfMeoGgAuJ34o+yjajxGz1V1W/TYNBDKI5Gqxjx4UJhWHuJFSB5cx3Jl5 FxOdkUcNNt1PXdkWppusJszoa2kDpKl23FQmjf+5rMd79LG0C3a2e3ePTlY40kBIirpOKR mMBJzNz6k4TULs03FxPMzZxjY+Yy0jR3jCLNQGSDQaDmKMEGh9i48rBxbWOe0DRcSxm7Sz w2BcfOkyjLjyTa/LhdBTckU7kFXvzv5ge6jruyP4gLwKBpWXAVvylc07dZZW2HBbXgAnBW SQnPHrvUZaR/Wo/AVexNFlsGwxE29Xmvzptlw622RAedVCGezt5RWET9FKRgbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1728099898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: dkim-signature; bh=MB3609t/RgX3OZ8DM2VfhRgBxuhvgtplaxwH7EwhUKs=; b=Zvf4htIrtf5ibsGRMdc+jqsmFF40Qp/sCpJ+Qif26OIh56Qf5aUeoeBjOzq849CnFE/FBt 4QNtOqetvQ10MU3GbaORDZIlHCj5JaU0smnPwF9iqm+K43jyCB/M12nsHSAcKrIa8iGzfl iNjUhFFgdHG23CoJbzSJRNw3SgohshdWIv7sxe2RhG3cfbGQzfAZk+nXzbdcYl4hUQO/8n G3x7aE7zdFReXbD1H7AkpUvs3eRzzHy9QfecNxqAZNVTYRaG6fubImgqWZ4LoK2wJ6wVRR ZO3FR1Ot5RqEOhqbpP43k8SyIsw8iWX147mYqzQizrioPUyZLONtPmBezfBD2g== ARC-Authentication-Results: i=1; rspamd-5778c966d7-rh5xd; auth=pass smtp.auth=dreamhost smtp.mailfrom=jidanni@jidanni.org X-Sender-Id: dreamhost|x-authsender|jidanni@jidanni.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jidanni@jidanni.org X-MailChannels-Auth-Id: dreamhost X-Scare-Shrill: 0987beb152719997_1728099898809_135186992 X-MC-Loop-Signature: 1728099898809:1763207744 X-MC-Ingress-Time: 1728099898808 Original-Received: from pdx1-sub0-mail-a207.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.96.87.216 (trex/7.0.2); Sat, 05 Oct 2024 03:44:58 +0000 Original-Received: from jidanni.org (1-165-161-29.dynamic-ip.hinet.net [1.165.161.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by pdx1-sub0-mail-a207.dreamhost.com (Postfix) with ESMTPSA id 4XLBBL3G1SzBW for ; Fri, 4 Oct 2024 20:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jidanni.org; s=dreamhost; t=1728099898; bh=MB3609t/RgX3OZ8DM2VfhRgBxuhvgtplaxwH7EwhUKs=; h=From:To:Subject:Date:Content-Type; b=VaNzhq3MHHOnxEk2zcDlft8qG6HYf1Ffvjxc0qZGSVm79+gHulJS6qmx/jHIPRB4J mMcg1AMKw/Kx0IASJhFQWoQQStr2K+J1Za5Wgju8jGFtBrIp/WWleL2Gi6m1vDogC3 KpuKNdeRnxM9WBGbK/HfJHlbcdF04HNWMAfRXf52q/1yVDuo0EhmfOV0sIA02LadTG aANqF2cKjhYEPrZBHJlhYfy4eL8wYs4SFXKeFMzigJHgh9WLs0pfqGWqAafXnLksrV zeeWeqQWpEtfEgB3orIGE6JEzWqnAh/S67A/vWOm1NWwJnuk4x6BO77rBE7lKxuFry l2QqVT8LJ3lbw== Original-Received: from jidanni by jidanni.org with local (Exim 4.96) (envelope-from ) id 1swviz-0000ZF-1J for bug-gnu-emacs@gnu.org; Sat, 05 Oct 2024 11:44:57 +0800 Received-SPF: pass client-ip=23.83.218.253; envelope-from=jidanni@jidanni.org; helo=iguana.tulip.relay.mailchannels.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292996 Archived-At: dired-do-query-replace-regexp asks for the replace from value, then asks for the replace to value, and only then finally checks if any files are selected in the first place. It needs to check first. E.g., yes there were files selected, but we just did a first run, and are no longer looking at the dired buffer. We need to go back to the dired buffer first. Fine. But at least let the user know before they bother entering the from and to values.