From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74771: Native compilation bug with struct predicates when lexical binding enabled (HEAD) Date: Wed, 11 Dec 2024 14:01:13 +0000 Message-ID: <87frmul3pd.fsf@protonmail.com> References: <0446a656-1fa2-4160-a8ba-69c060a52589@risk-engineering.org> <87frmvmbnb.fsf@protonmail.com> <86ldwm4cz4.fsf@gnu.org> Reply-To: Pip Cet Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5890"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrea Corallo , 74771@debbugs.gnu.org, eric.marsden@risk-engineering.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 11 15:02:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLNIB-0001O5-SH for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Dec 2024 15:02:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLNHw-00043h-IW; Wed, 11 Dec 2024 09:02:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLNHu-00041Q-9x for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 09:02:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLNHt-0004ZU-Rt for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 09:02:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=0jA6/DWuJXJc65oXVTsvEDTGtfM36piCvOvEFickgSo=; b=XZneRS2rF7v5LwXO4BPQ+Qa043+BBh33otKio2fCxl9GGT9Y+7GlZbKXeH4Y4K/VRYtOGsix1G9c+O03bKENkHDQfnoGUI375jV0YVLZBtV+wwn7mPaImUx4KItSDrtp6n5v66lVc5XfWeFaMovIzPyiKTOBzL5CTmGzCP622bLCuiEAZP+9hoemeu8JQ2RweZrHP+eA6so9aqyckwKMRGOK76g9oarLfWmtGEUnlfIF9aOxIzXaBPgvRymgnqfPZdqEkYCNWSRLDYqeBAYbrfKZX8zi9HKSzCGqu/LWeVofX1Kd2npW4EH/3bg3Nj+xPgbWeoWr3P24FBhbPWeL3Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLNHt-0001XE-Lr for bug-gnu-emacs@gnu.org; Wed, 11 Dec 2024 09:02:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Pip Cet Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2024 14:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74771 X-GNU-PR-Package: emacs Original-Received: via spool by 74771-submit@debbugs.gnu.org id=B74771.17339256885754 (code B ref 74771); Wed, 11 Dec 2024 14:02:01 +0000 Original-Received: (at 74771) by debbugs.gnu.org; 11 Dec 2024 14:01:28 +0000 Original-Received: from localhost ([127.0.0.1]:33554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLNHL-0001Uj-LU for submit@debbugs.gnu.org; Wed, 11 Dec 2024 09:01:27 -0500 Original-Received: from mail-40131.protonmail.ch ([185.70.40.131]:11079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLNHH-0001UE-VH for 74771@debbugs.gnu.org; Wed, 11 Dec 2024 09:01:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1733925678; x=1734184878; bh=0jA6/DWuJXJc65oXVTsvEDTGtfM36piCvOvEFickgSo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=VaWSRt7VtVANI1oBbb22ed0RGWvnXSsU3+n5ULbBCaHmIUt7EDjOBtG7jAssMXWjb uttvwTrqBahTVPO71OJ4U5LddBRLujFLn4MXTPiDTZTXLuJ/qZQwVHUAIMG46YX2gr wcZXvE/4SPeXzIAu+F30PLIynWdOZRsfjbOymvvTo8+b+fYZt3PI3KQiDoDHl1N8Fa H9cYlJ+dlMQv+Kqdp1TgbSSo3Jra5TgkOOXU9/2N/RCWQy1eEPyzI3TuAG0l3JyMdN kudh/iVECIJnd9O1WQVR8xpRl32YcXpA2NYF+glPf32zz2fxdkcD385b1NmlRLbdZu L5A9tJz094yuA== In-Reply-To: <86ldwm4cz4.fsf@gnu.org> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 5f4e4a191696d808ce7b99e41bb0bcf6575b3ae6 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296825 Archived-At: "Eli Zaretskii" writes: >> Cc: 74771@debbugs.gnu.org >> Date: Tue, 10 Dec 2024 22:12:03 +0000 >> From: Pip Cet via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> Pip Cet writes: >> >> > IIUC, the code blindly assumes that cond-jump would use t as its secon= d >> > argument. In your code, the second argument was nil, so the assumptio= ns >> > were put into the wrong basic blocks. >> >> I did not understand correctly. It seems cond-jump is still limited to >> a nil second argument, which is an undocumented assumption that comp.el >> continues to rely on. >> >> I still think comp--emit-assume does the wrong thing when negating an >> assumption, but we've been there before... > > Let's hear from Andrea (CC'ed) about this. You're right. I have a new theory, but as it boils down to something that has been discussed before (whether "assume" pseudo-insns apply to individual mvars or to all mvars sharing a slot - my understanding is it has to be the latter, so we end up making invalid assumptions about the new mvar in the slot based on things we know about the old, clobbered mvar), it's best to let Andrea handle this one. I'll just disable nativecomp assume pseudo-insns for my builds as I don't want to run into this bug. Pip