bug#2865: 23.0.92; tramp chmod on remote ftp fails

bug#2865: 23.0.92; tramp chmod on remote ftp fails

[Walter Alejandro Iglesias]

chmod files in remote server using tramp ftp fails without reporting
any error.  I've tried this tramp version with emacs 22 and works so
the problem may be in dired.el.  My elisp knowledge is poor I am not
able to give you more help, sorry.


In GNU Emacs 23.0.92.1 (i686-pc-linux-gnu, GTK+ Version 2.8.20)
 of 2009-04-02 on localhost
Windowing system distributor `The X.Org Foundation', version 11.0.70101000
configured using `configure  '--prefix=/home/morlock''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Internal Ange-ftp

Minor modes in effect:
  shell-dirtrack-mode: t
  xterm-mouse-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x 1 <help-echo> <help-echo> <help-echo> C-x C-f <M-backspace> 
<M-backspace> <M-backspace> / f t p : r o q u e s o 
r # <backspace> @ r o q u e s o r . c o m : / w w w 
<return> C-n C-n C-n C-n C-n C-n C-n C-n C-n M 8 <backspace> 
5 <backspace> 4 <backspace> 6 0 0 <return> C-n C-n 
C-n C-n C-p C-p C-p C-p C-p C-p C-p C-n C-n C-n C-n 
C-n <return> C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-x k <return> C-x k <return> C-x b * f t <tab> <return> 
b y <return> <down-mouse-4> <mouse-4> <double-down-mouse-4> 
<double-mouse-4> <triple-down-mouse-4> <triple-mouse-4> 
<triple-down-mouse-4> <triple-mouse-4> <down-mouse-5> 
<mouse-5> <double-down-mouse-5> <double-mouse-5> <down-mouse-5> 
<mouse-5> <down-mouse-5> <mouse-5> <down-mouse-5> <mouse-5> 
<down-mouse-5> <mouse-5> <double-down-mouse-5> <double-mouse-5> 
<down-mouse-4> <mouse-4> <double-down-mouse-4> <double-mouse-4> 
<triple-down-mouse-4> <triple-mouse-4> <triple-down-mouse-4> 
<triple-mouse-4> <down-mouse-5> <mouse-5> <down-mouse-5> 
<mouse-5> <down-mouse-5> <mouse-5> <down-mouse-5> <mouse-5> 
<double-down-mouse-5> <double-mouse-5> <down-mouse-5> 
<mouse-5> <down-mouse-5> <mouse-5> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <menu-bar> 
<help-menu> <send-emacs-bug-report>

Recent messages:
Logging in as user roquesor@roquesor.com...done
Getting PWD...done
Trying passive mode...on
Doing CD...done
Listing /ftp:roquesor@roquesor.com:/www/...done
Redisplaying... /ftp:roquesor@roquesor.com:/www/ens.html
Doing CD...done
Listing /ftp:roquesor@roquesor.com:/www...done
Redisplaying...done
Retrieving index.html...done

bug#2865: 23.0.92; tramp chmod on remote ftp fails

[Michael Albinus]

Walter Alejandro Iglesias <roquesor@gmail.com> writes:

> chmod files in remote server using tramp ftp fails without reporting
> any error.  I've tried this tramp version with emacs 22 and works so
> the problem may be in dired.el.  My elisp knowledge is poor I am not
> able to give you more help, sorry.

`dired-do-chmod' has changed its implementation; it uses
`set-file-modes' now. Ange-ftp lacks an implementation of this function.

I've added such an implementation; it shall work now. Could you, please, test?

Best regards, Michael.

bug#2865: 23.0.92; tramp chmod on remote ftp fails

[Chong Yidong]

> > chmod files in remote server using tramp ftp fails without reporting
> > any error.  I've tried this tramp version with emacs 22 and works so
> > the problem may be in dired.el.  My elisp knowledge is poor I am not
> > able to give you more help, sorry.
>
> `dired-do-chmod' has changed its implementation; it uses
> `set-file-modes' now. Ange-ftp lacks an implementation of this function.
>
> I've added such an implementation; it shall work now. Could you, please,
> test?

Could you verify whether the bug is gone?  Thanks.