From: "Óscar Fuentes" <ofv@wanadoo.es>
To: Eli Zaretskii <eliz@gnu.org>
Cc: lekktu@gmail.com, 6674@debbugs.gnu.org
Subject: bug#6674: PATCH: fix assignment of grep-find-use-xargs on Windows/MS-DOS
Date: Tue, 20 Jul 2010 21:51:39 +0200 [thread overview]
Message-ID: <87eiey2apg.fsf@telefonica.net> (raw)
In-Reply-To: <83vd8acbbv.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 20 Jul 2010 20:28:04 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
[snip]
> By trial and error I established that the limit beyond which rgrep
> fails is 1024 characters. This is consistent with the MSDN
> documentation of _spawn, e.g.
[snip]
> So we could either (1) install Óscar's patch, with the disadvantage
> that rgrep will be slower on MS-Windows (because a separate Grep is
> invoked on each file found by Find), or (2) fix cmdproxy to use a
> better API, such as CreateProcess, which doesn't have this limitation.
cmdproxy.c does not call the C runtime `_spawn' function. It defines its
own `spawn' that calls CreateProcess.
The issue is that "cmd.exe -c" seems to have a 1024 char limit when the
command contains a pipe (my guess is that the limit applies separatelly
to every command on the pipe chain) and cmdproxy.c prepends "cmd.exe -c"
to the command when it has a pipe, redirection, etc.
> In any case, please do NOT install the patch for the MS-DOS build. As
> I wrote earlier, it does not have this problem.
Okay.
next prev parent reply other threads:[~2010-07-20 19:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 3:49 bug#6674: PATCH: fix assignment of grep-find-use-xargs on Windows/MS-DOS Óscar Fuentes
2010-07-20 12:57 ` Juanma Barranquero
2010-07-20 13:39 ` Óscar Fuentes
2010-07-20 14:24 ` Óscar Fuentes
2010-07-20 15:18 ` Juanma Barranquero
2010-07-20 16:56 ` Eli Zaretskii
2010-07-20 17:28 ` Eli Zaretskii
2010-07-20 17:42 ` Juanma Barranquero
2010-07-20 19:51 ` Óscar Fuentes [this message]
2010-07-20 21:41 ` Eli Zaretskii
2010-07-20 22:18 ` Eli Zaretskii
2010-07-21 0:38 ` Christoph
2010-07-21 1:22 ` Óscar Fuentes
2010-08-02 10:26 ` Laimonas Vėbra
2010-08-02 15:23 ` Óscar Fuentes
2010-08-02 15:48 ` bug#6674: [PATCH] bug#6674: " Óscar Fuentes
2010-08-02 17:11 ` Andreas Schwab
2010-08-02 17:48 ` bug#6674: [PATCH fixed] " Óscar Fuentes
2010-08-02 19:07 ` Eli Zaretskii
2010-08-02 19:47 ` Juanma Barranquero
2010-08-02 19:57 ` Óscar Fuentes
2010-08-02 20:11 ` Juanma Barranquero
2010-08-02 20:15 ` Óscar Fuentes
2010-08-03 2:56 ` Eli Zaretskii
2010-07-20 16:46 ` bug#6674: PATCH: " Eli Zaretskii
2010-07-20 23:18 ` bug#6674: PATCH: fix assignment of grep-find-use-xargs on Windows Óscar Fuentes
2010-07-21 0:44 ` Christoph
2010-07-21 0:50 ` Juanma Barranquero
2010-07-21 0:57 ` Óscar Fuentes
2010-07-21 4:02 ` Eli Zaretskii
2010-07-21 4:05 ` Christoph
2010-08-02 2:21 ` Christoph
2010-08-02 3:10 ` Eli Zaretskii
2010-08-02 4:03 ` Christoph
2010-08-02 18:02 ` Eli Zaretskii
2010-08-02 20:17 ` bug#6674: Closing bug 6674 Óscar Fuentes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eiey2apg.fsf@telefonica.net \
--to=ofv@wanadoo.es \
--cc=6674@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).