unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Jambunathan K <kjambunathan@gmail.com>
Cc: 9820@debbugs.gnu.org
Subject: bug#9820: 24.0.90; Behaviour of add-file-local-variable
Date: Fri, 21 Oct 2011 17:06:10 +0300	[thread overview]
Message-ID: <87ehy61n79.fsf@mail.jurta.org> (raw)
In-Reply-To: <8162jjj5dp.fsf@gmail.com> (Jambunathan K.'s message of "Fri, 21 Oct 2011 10:41:30 +0530")

> Transcripts of exchanges on emacs-devel.
> http://lists.gnu.org/archive/html/emacs-devel/2011-10/msg00850.html
> http://lists.gnu.org/archive/html/emacs-devel/2011-10/msg00867.html

Thanks for filing the bug report based on that discussion.
As suggested, the following patch implements displaying a message.

> Additional note: All other file-local related commands may have to be
> audited for the requested behaviour.

It displays a message only in `add-file-local-variable' and
`add-file-local-variable-prop-line'.  I have no opinion
what other commands might do.

=== modified file 'lisp/files-x.el'
--- lisp/files-x.el	2011-04-19 13:44:55 +0000
+++ lisp/files-x.el	2011-10-21 14:04:22 +0000
@@ -214,7 +214,11 @@ (defun add-file-local-variable (variable
   (interactive
    (let ((variable (read-file-local-variable "Add file-local variable")))
      (list variable (read-file-local-variable-value variable))))
-  (modify-file-local-variable variable value 'add-or-replace))
+  (modify-file-local-variable variable value 'add-or-replace)
+  (when (and (called-interactively-p 'interactive)
+	     (symbolp variable) (boundp variable)
+	     (not (equal (symbol-value variable) value)))
+    (message "Revisit file to make this change take effect")))
 
 ;;;###autoload
 (defun delete-file-local-variable (variable)
@@ -335,7 +339,11 @@ (defun add-file-local-variable-prop-line
   (interactive
    (let ((variable (read-file-local-variable "Add -*- file-local variable")))
      (list variable (read-file-local-variable-value variable))))
-  (modify-file-local-variable-prop-line variable value 'add-or-replace))
+  (modify-file-local-variable-prop-line variable value 'add-or-replace)
+  (when (and (called-interactively-p 'interactive)
+	     (symbolp variable) (boundp variable)
+	     (not (equal (symbol-value variable) value)))
+    (message "Revisit file to make this change take effect")))
 
 ;;;###autoload
 (defun delete-file-local-variable-prop-line (variable)






  reply	other threads:[~2011-10-21 14:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21  5:11 bug#9820: 24.0.90; Behaviour of add-file-local-variable Jambunathan K
2011-10-21 14:06 ` Juri Linkov [this message]
2011-10-21 17:39   ` Stefan Monnier
2011-10-22  4:57   ` Jambunathan K
2011-10-22  5:48     ` Jambunathan K
2011-10-22 15:35       ` Juri Linkov
2011-10-23 17:59         ` Stefan Monnier
2013-06-15 22:58           ` Juri Linkov
2013-06-16  0:50             ` Stefan Monnier
2013-06-17 22:35               ` Juri Linkov
2013-06-18  0:53                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehy61n79.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=9820@debbugs.gnu.org \
    --cc=kjambunathan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).