From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#10650: view-mode inconsistencies wrt special mode-class Date: Thu, 02 Feb 2012 02:40:45 +0200 Organization: JURTA Message-ID: <87ehuegj8y.fsf@mail.jurta.org> References: <9vehugoa9d.fsf@fencepost.gnu.org> <87pqe08kgs.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1328143612 31008 80.91.229.3 (2 Feb 2012 00:46:52 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 2 Feb 2012 00:46:52 +0000 (UTC) Cc: Chong Yidong , 10650@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 02 01:46:51 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Rskp8-0002wf-M3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Feb 2012 01:46:50 +0100 Original-Received: from localhost ([::1]:59509 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rskp8-0003iU-5x for geb-bug-gnu-emacs@m.gmane.org; Wed, 01 Feb 2012 19:46:50 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:40539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rskp4-0003iN-Pi for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2012 19:46:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rskp3-0008Na-F2 for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2012 19:46:46 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rskp3-0008NO-DR for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2012 19:46:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RskpQ-0008Bo-PA for bug-gnu-emacs@gnu.org; Wed, 01 Feb 2012 19:47:08 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2012 00:47:07 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10650 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10650-submit@debbugs.gnu.org id=B10650.132814356331400 (code B ref 10650); Thu, 02 Feb 2012 00:47:07 +0000 Original-Received: (at 10650) by debbugs.gnu.org; 2 Feb 2012 00:46:03 +0000 Original-Received: from localhost ([127.0.0.1]:49667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RskoM-0008AE-Gb for submit@debbugs.gnu.org; Wed, 01 Feb 2012 19:46:03 -0500 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:33595 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RskoC-00089p-Hu for 10650@debbugs.gnu.org; Wed, 01 Feb 2012 19:45:58 -0500 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 9BD0A451C81A; Wed, 1 Feb 2012 16:44:14 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Wed, 01 Feb 2012 09:31:44 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:56359 Archived-At: >> Personally I think a separate variable controlling which modes are >> incompatible with view-mode would be better, but I'm not going to >> complain if the definition of special modes is extended to cover this. > > I'm not sure exactly what's the idea with view-mode's use of special > mode class, but IIUC it's that we don't want to enable view-mode in > major modes that already have view-mode-like keybindings, which might > boil down to something along the lines of "major modes which use > suppress-keymap". Without using the special mode class or adding a new separate variable, the closest condition to match modes incompatible with view-mode would be: (and (buffer-file-name) (or (derived-mode-p 'special-mode) (equal (keymap-parent (current-local-map)) special-mode-map))) What is worth to note is that these modes don't suppress the special-mode keymap, but inherit from it and override most of its key bindings. But this heuristics is too unreliable, so explicitly declaring incompatible modes is better.